Skip to content

[HOLD for payment 1/12][$8000] Profile - Create a limit for Avatar file types or size  #13006

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Save the below image to your local drive
  2. Open staging.new.expensify.com.
  3. Open Settings, click on Avatar to open Profile Page.
  4. Click on Edit photo and upload the below image
  5. Try to scroll the slider to zoom in or zoom out the photo.
  6. Notice that the slider can't not be scrolled for a while and it's delayed.

Expected Result:

  • Slider need be scrolled smoothly without any delay
  • We need to create an error message if a user is uploading a file/size too large to scroll smoothly

Actual Result:

Slider can't not be scrolled for a while and it's delayed after that.

  • Based on our code we have:

  • Max size: 6291456

  • Min Width: 80

  • Min Height: 80

  • Max Width: XX

  • Max Height: XX

We need to figure out what is causing this issue (is it pixels, weight, file type) and create an error message for the user

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.31-5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/203830021-84c9a597-6507-490b-881e-fb08fe57c900.mov
https://user-images.githubusercontent.com/43996225/203830045-659ad4c2-2fc4-4d86-870c-c3cb6338284f.mp4
Used this image : kinnd-02 (1)

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669089889220939

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017185b708f6ccd9fb
  • Upwork Job ID: 1597776558088036352
  • Last Price Increase: 2022-12-26

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 24, 2022
  2. melvin-bot commented on Nov 24, 2022

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. s77rt commented on Nov 25, 2022

    @s77rt
    Member

    The image is 9001px by 9000px
    That's too much, I won't say this is a bug

  4. Christinadobrzyn commented on Nov 28, 2022

    @Christinadobrzyn
    Contributor

    I am not able to replicate this.

    Staging v1.2.32-1

    1. Open staging.new.expensify.com.
    2. Open Settings, click on Avatar to open Profile Page.
    3. Click on Edit photo and choose an image from local.
    4. Scroll the slider to zoom
    5. Notice that the slider can't not be scrolled for a while and it's delayed.

    Image used 80kb:

    2022-11-28_13-54-44 (1)

    Based on the chat in the Slack link and as @s77rt mentioned, this seems to be an issue with large images. Do we want to change the focus of this to compress images before uploading or send a popup asking for a lighter image?

  5. Beamanator commented on Nov 28, 2022

    @Beamanator
    Contributor

    Do we want to change the focus of this to compress images before uploading or send a popup asking for a lighter image?

    I like these ideas (prefer asking for a smaller image) - added my comments in Slack!

  6. Christinadobrzyn commented on Nov 29, 2022

    @Christinadobrzyn
    Contributor

    I think we need to figure out what is causing the issue b/c it sounds like it might not be file size based on this comment.

    The avatar limit code is here:

    AVATAR_MAX_ATTACHMENT_SIZE: 6291456
    AVATAR_MIN_WIDTH_PX: 80
    AVATAR_MIN_HEIGHT_PX: 80

    The image that @hungvu193 has very high pixelation - maybe that's the issue? @hungvu193 or @kavimuru do you have another image with a heavy pixelation/DPI that we can test?

    image

  7. Christinadobrzyn commented on Nov 29, 2022

    @Christinadobrzyn
    Contributor

    Kinda came to a resolution in the Slack convo but love to get your thoughts on what to do next with this GH @Beamanator

  8. self-assigned this
    on Nov 29, 2022
  9. Beamanator commented on Nov 29, 2022

    @Beamanator
    Contributor

    Adding myself here too b/c I'm involved in lots of avatar-related issues, and this is very intriguing 😅

    Also noting (as is noted in Slack) this is the same as #13005, which was closed w/out reproduction but it seems there's a few images we can use to reproduce at the moment (in Slack):

    (Chose download free => Original size): https://unsplash.com/photos/SiwI2DVMZHI

  10. Christinadobrzyn commented on Nov 30, 2022

    @Christinadobrzyn
    Contributor

    Thanks @Beamanator and @hungvu193! I updated the title and the OP to hopefully match what we're looking for. Going to all the external label.

  11. 101 remaining items

  12. changed the title [-][$8000] Profile - Create a limit for Avatar file types or size [/-] [+][HOLD for payment 1/12][$8000] Profile - Create a limit for Avatar file types or size [/+] on Jan 9, 2023
  13. mallenexpensify commented on Jan 9, 2023

    @mallenexpensify
    Contributor

    Deployed to Production on Jan 5, updating title to pay on 1/12
    #13899 (comment)

    I wonder why auto-bots didn't work for updating, maybe cuz there was additional data here in the PR?

    Fixed Issues
    $ #13006
    PROPOSAL: #13006 (comment)

  14. mallenexpensify commented on Jan 12, 2023

    @mallenexpensify
    Contributor

    Hired Dec 29th, Merged Jan 3, eligible for the 50% bonus (weekend and holiday in between)

    @azimgd and @sobitneupane paid $12,000
    @hungvu193 , can you please accept the job and reply here once you have so I can pay the reporting bonus?
    https://www.upwork.com/jobs/~017185b708f6ccd9fb

  15. hungvu193 commented on Jan 13, 2023

    @hungvu193
    Contributor

    @mallenexpensify I've just applied, thank you

  16. Christinadobrzyn commented on Jan 13, 2023

    @Christinadobrzyn
    Contributor

    sorry, @mallenexpensify, would you be able to pay this? I'm really sick today and going to take ooo. thank you for taking it

  17. removed their assignment
    on Jan 13, 2023
  18. mallenexpensify commented on Jan 13, 2023

    @mallenexpensify
    Contributor

    @hungvu193 paid, thanks!

    For regression test steps, proposing
    Add to TestRail here - Profile - Modify User Avatar

    1. Save an image that is between 80px and 2048px
    2. Open staging.new.expensify.com.
    3. Open Settings, click on Avatar to open Profile Page.
    4. Click on Edit photo and upload the image
    5. Verify the slides to zoom in and out scrolls smoothly.

    @tgolen @sobitneupane can you finish the top three items on the checklist?

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • The PR that introduced the bug has been identified. Link to the PR:
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/256180
  19. mallenexpensify commented on Jan 13, 2023

    @mallenexpensify
    Contributor

    Should have feedback on the regression test steps by Monday

  20. sobitneupane commented on Jan 16, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • The PR that introduced the bug has been identified. Link to the PR:

    I think this bug was present from the very beginning. This feature was implemented in #8511.

  21. mallenexpensify commented on Jan 17, 2023

    @mallenexpensify
    Contributor
  22. melvin-bot commented on Jan 19, 2023

    @melvin-bot

    @tgolen @mallenexpensify Be sure to fill out the Contact List!

  23. mallenexpensify commented on Jan 19, 2023

    @mallenexpensify
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions