You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 1/12][$8000] Profile - Create a limit for Avatar file types or size #13006
We need to figure out what is causing this issue (is it pixels, weight, file type) and create an error message for the user
Platform:
Where is this issue occurring?
Web
Version Number: 1.2.31-5 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Open Settings, click on Avatar to open Profile Page.
Click on Edit photo and choose an image from local.
Scroll the slider to zoom
Notice that the slider can't not be scrolled for a while and it's delayed.
Image used 80kb:
Based on the chat in the Slack link and as @s77rt mentioned, this seems to be an issue with large images. Do we want to change the focus of this to compress images before uploading or send a popup asking for a lighter image?
The image that @hungvu193 has very high pixelation - maybe that's the issue? @hungvu193 or @kavimuru do you have another image with a heavy pixelation/DPI that we can test?
Adding myself here too b/c I'm involved in lots of avatar-related issues, and this is very intriguing 😅
Also noting (as is noted in Slack) this is the same as #13005, which was closed w/out reproduction but it seems there's a few images we can use to reproduce at the moment (in Slack):
changed the title [-][$8000] Profile - Create a limit for Avatar file types or size [/-][+][HOLD for payment 1/12][$8000] Profile - Create a limit for Avatar file types or size [/+]on Jan 9, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
The PR that introduced the bug has been identified. Link to the PR:
I think this bug was present from the very beginning. This feature was implemented in #8511.
Activity
melvin-bot commentedon Nov 24, 2022
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.s77rt commentedon Nov 25, 2022
The image is 9001px by 9000px
That's too much, I won't say this is a bug
Christinadobrzyn commentedon Nov 28, 2022
I am not able to replicate this.
Staging v1.2.32-1
Image used 80kb:
Based on the chat in the Slack link and as @s77rt mentioned, this seems to be an issue with large images. Do we want to change the focus of this to compress images before uploading or send a popup asking for a lighter image?
Beamanator commentedon Nov 28, 2022
I like these ideas (prefer asking for a smaller image) - added my comments in Slack!
Christinadobrzyn commentedon Nov 29, 2022
I think we need to figure out what is causing the issue b/c it sounds like it might not be file size based on this comment.
The avatar limit code is here:
AVATAR_MAX_ATTACHMENT_SIZE: 6291456
AVATAR_MIN_WIDTH_PX: 80
AVATAR_MIN_HEIGHT_PX: 80
The image that @hungvu193 has very high pixelation - maybe that's the issue? @hungvu193 or @kavimuru do you have another image with a heavy pixelation/DPI that we can test?
Christinadobrzyn commentedon Nov 29, 2022
Kinda came to a resolution in the Slack convo but love to get your thoughts on what to do next with this GH @Beamanator
Beamanator commentedon Nov 29, 2022
Adding myself here too b/c I'm involved in lots of avatar-related issues, and this is very intriguing 😅
Also noting (as is noted in Slack) this is the same as #13005, which was closed w/out reproduction but it seems there's a few images we can use to reproduce at the moment (in Slack):
Christinadobrzyn commentedon Nov 30, 2022
Thanks @Beamanator and @hungvu193! I updated the title and the OP to hopefully match what we're looking for. Going to all the external label.
101 remaining items
[-][$8000] Profile - Create a limit for Avatar file types or size [/-][+][HOLD for payment 1/12][$8000] Profile - Create a limit for Avatar file types or size [/+]mallenexpensify commentedon Jan 9, 2023
Deployed to Production on Jan 5, updating title to pay on 1/12
#13899 (comment)
I wonder why auto-bots didn't work for updating, maybe cuz there was additional data here in the PR?
mallenexpensify commentedon Jan 12, 2023
Hired Dec 29th, Merged Jan 3, eligible for the 50% bonus (weekend and holiday in between)
@azimgd and @sobitneupane paid $12,000
@hungvu193 , can you please accept the job and reply here once you have so I can pay the reporting bonus?
https://www.upwork.com/jobs/~017185b708f6ccd9fb
hungvu193 commentedon Jan 13, 2023
@mallenexpensify I've just applied, thank you
Christinadobrzyn commentedon Jan 13, 2023
sorry, @mallenexpensify, would you be able to pay this? I'm really sick today and going to take ooo. thank you for taking it
mallenexpensify commentedon Jan 13, 2023
@hungvu193 paid, thanks!
For regression test steps, proposing
Add to TestRail here - Profile - Modify User Avatar
@tgolen @sobitneupane can you finish the top three items on the checklist?
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mallenexpensify commentedon Jan 13, 2023
Should have feedback on the regression test steps by Monday
sobitneupane commentedon Jan 16, 2023
I think this bug was present from the very beginning. This feature was implemented in #8511.
mallenexpensify commentedon Jan 17, 2023
Thanks @sobitneupane , waiting for 👀 on the regression test steps
https://expensify.slack.com/archives/C01SKUP7QR0/p1673915154156849?thread_ts=1673578243.618989&cid=C01SKUP7QR0
melvin-bot commentedon Jan 19, 2023
@tgolen @mallenexpensify Be sure to fill out the Contact List!
mallenexpensify commentedon Jan 19, 2023
Regression test added https://github.com/Expensify/Expensify/issues/256180