Skip to content

Deploy Checklist: New Expensify 2022-11-28 #13099

Closed

Description

@OSBotify

Release Version: 1.2.33-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. self-assigned this
    on Nov 28, 2022
  2. OSBotify commented on Nov 28, 2022

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.33-1 🚀

  3. marcaaron commented on Nov 29, 2022

    @marcaaron
    Contributor

    Put up a fix for the second deploy blocker listed here: #13119

  4. OSBotify commented on Nov 29, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-2 🚀

  5. luacmartins commented on Nov 29, 2022

    @luacmartins
    Contributor

    Thanks for the fix @marcaaron

  6. arosiclair commented on Nov 29, 2022

    @arosiclair
    Contributor

    Closed #13139 as it is reproducible in prod

  7. OSBotify commented on Nov 29, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-2 has been deployed to staging 🎉

  8. mvtglobally commented on Nov 29, 2022

    @mvtglobally

    @luacmartins Regression is completed

    PR #12944 (comment) Can we check off? Dark mode is definitely On
    PR #13054 Error is not fixed.
    PR #13119 There is no option to autofill on Desktop/IOS/Android. Is it expected?
    PR #13077 is failing with KI #12777. There is also no option to zoom on mWeb. Can you double check its ok to checkoff? This one not working as expected

  9. luacmartins commented on Nov 29, 2022

    @luacmartins
    Contributor
  10. PauloGasparSv commented on Nov 29, 2022

    @PauloGasparSv
    Contributor

    @luacmartins @mvtglobally

    About #13077 I think there was no option to zoom on mWeb before so it's ok.
    I tested sending a picture and pinching it on https://new.expensify.com/ and https://staging.new.expensify.com/ in my phone here and they are both working the same way.

    Now I took a look at that build failure and I have no idea why it happened, the changes in that P.R. were very minimal. Re-running all failed jobs here to see if it works.

  11. PauloGasparSv commented on Nov 29, 2022

    @PauloGasparSv
    Contributor

    Also, what do you mean by This one not working as expected @mvtglobally @luacmartins?

  12. 14 remaining items

  13. luacmartins commented on Nov 29, 2022

    @luacmartins
    Contributor

    We just merged PRs to fix #13141 and #13163. Should be available to test soon.

  14. OSBotify commented on Nov 29, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-5 🚀

  15. luacmartins commented on Nov 29, 2022

    @luacmartins
    Contributor
  16. mvtglobally commented on Nov 29, 2022

    @mvtglobally

    Calendar icon issue is resolved @luacmartins

  17. luacmartins commented on Nov 30, 2022

    @luacmartins
    Contributor

    Awesome, checking off #13142

  18. OSBotify commented on Nov 30, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-5 has been deployed to staging 🎉

  19. OSBotify commented on Nov 30, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-6 🚀

  20. OSBotify commented on Nov 30, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-6 has been deployed to staging 🎉

  21. luacmartins commented on Nov 30, 2022

    @luacmartins
    Contributor

    #13164 is a pass. Checking off

    Screen.Recording.2022-11-29.at.6.40.31.PM.mov
  22. OSBotify commented on Nov 30, 2022

    @OSBotify
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-7 🚀

  23. luacmartins commented on Nov 30, 2022

    @luacmartins
    Contributor

    #13174 is a pass. Checking it off.
    Screenshot 2022-11-29 at 7 05 14 PM

  24. luacmartins commented on Nov 30, 2022

    @luacmartins
    Contributor

    Checklist is clear. Starting the deploy!

  25. luacmartins commented on Nov 30, 2022

    @luacmartins
    Contributor

    :shipit:

  26. OSBotify commented on Nov 30, 2022

    @OSBotify
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-7 has been deployed to staging 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions