You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD #227234] Receiving Notifications from chats sent months ago #13140
Notifications received would be from our chats happening now
Actual Result:
Received notifications from chats received months ago. When I look at those chats they also show “Invalid Date”
Workaround:
unknown
Platform:
Where is this issue occurring?
Desktop App
Version Number: 1.2.30-0 Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Seeing the browser notifications makes sense too since we use the created field to determine whether to show a notification. The created being invalid means the front end interprets it as "new"
IMO this is in part of a consequence of this issue (needs a better general design) and in part due to some API change that we haven't connected to this bug yet (which seems more urgent to solve).
I don't think it should be on HOLD, no. It seems like an API change has triggered this and we should make this Internal so someone on the team can prioritize it.
Only path forward I see is getting affected reportIDs and running a CQ to see what these invalid created values look like. That should give us a hint as to what the issue is.
@garrettmknight@RobertLadue@joekaufmanexpensify could you share the report IDs for the chats you guys experienced this Invalid Date issue? You can open the chat in web and grab the ID from the URL here
Sorry I completely missed the ping here. It seems like the PRs Andrew linked are probably the cause. I agree that we could run a CQ to get the created dates for those reports to see how we are storing the date and then fix it.
I know I did experience this issue at some point in the past, but I don't remember which report, and didn't record it. Sorry! For me, signing out and back in resolved the issue at the time.
No real updates atm. Signing out and back in resolving the issue suggests that Onyx might have had an invalid created value cached and the API was only able to replace it with a valid one after signing out and clearing Onyx.
changed the title [-]Receiving Notifications from chats sent months ago[/-][+][HOLD #227234] Receiving Notifications from chats sent months ago[/+]on Dec 27, 2022
Given the relation to sequence numbers PRs, I'm going to proactively add a HOLD on that project and simultaneously take this issue over (I'm the BZ person assigned and responsible for SQN bugs).
Even then, given that signing in and out resolves the issue, that indicates that this is temporary, so I could equally see the argument that we should close this for focus. Leaving that up to @arosiclair.
Yeah let's just close this out for now as this may never come up again after sequence numbers is finished. If it does, we can just reopen and take another look.
Activity
melvin-bot commentedon Nov 29, 2022
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.garrettmknight commentedon Nov 30, 2022
Updated to v1.2.33-7, 'invalid date' persists:

dylanexpensify commentedon Nov 30, 2022
working on reproducing now
dylanexpensify commentedon Nov 30, 2022
@garrettmknight is this only with your chat with Gabi?
garrettmknight commentedon Nov 30, 2022
There's another chat with her that has the 'Invalid Date' text on the same day, but no others.
garrettmknight commentedon Nov 30, 2022
Happened to @RobertLadue as well:

marcaaron commentedon Dec 1, 2022
possible theory - something in the API layer changed and is sending an invalid
action.createdWe render the date here ->
App/src/pages/home/report/ReportActionItemDate.js
Lines 15 to 19 in 820e876
So like the UI says it is probably invalid...
Seeing the browser notifications makes sense too since we use the
createdfield to determine whether to show a notification. Thecreatedbeing invalid means the front end interprets it as "new"App/src/libs/actions/Report.js
Lines 1330 to 1331 in 820e876
IMO this is in part of a consequence of this issue (needs a better general design) and in part due to some API change that we haven't connected to this bug yet (which seems more urgent to solve).
dylanexpensify commentedon Dec 2, 2022
Ah very interesting @marcaaron. Should we put this on hold then while we work on the linked issue? Or can we work on this externally in the meantime?
marcaaron commentedon Dec 2, 2022
I don't think it should be on HOLD, no. It seems like an API change has triggered this and we should make this
Internalso someone on the team can prioritize it.13 remaining items
dylanexpensify commentedon Dec 19, 2022
@arosiclair any updates by chance?
arosiclair commentedon Dec 19, 2022
Only path forward I see is getting affected reportIDs and running a CQ to see what these invalid
createdvalues look like. That should give us a hint as to what the issue is.@garrettmknight @RobertLadue @joekaufmanexpensify could you share the report IDs for the chats you guys experienced this Invalid Date issue? You can open the chat in web and grab the ID from the URL here
luacmartins commentedon Dec 19, 2022
Sorry I completely missed the ping here. It seems like the PRs Andrew linked are probably the cause. I agree that we could run a CQ to get the created dates for those reports to see how we are storing the date and then fix it.
joekaufmanexpensify commentedon Dec 19, 2022
I know I did experience this issue at some point in the past, but I don't remember which report, and didn't record it. Sorry! For me, signing out and back in resolved the issue at the time.
melvin-bot commentedon Dec 23, 2022
@arosiclair, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
arosiclair commentedon Dec 26, 2022
No real updates atm. Signing out and back in resolving the issue suggests that Onyx might have had an invalid
createdvalue cached and the API was only able to replace it with a valid one after signing out and clearing Onyx.Bumping @garrettmknight @RobertLadue for those report IDs
[-]Receiving Notifications from chats sent months ago[/-][+][HOLD #227234] Receiving Notifications from chats sent months ago[/+]JmillsExpensify commentedon Dec 27, 2022
A couple of things:
Given the relation to sequence numbers PRs, I'm going to proactively add a HOLD on that project and simultaneously take this issue over (I'm the BZ person assigned and responsible for SQN bugs).
Let's still have @garrettmknight and @RobertLadue share their reportIDs when they are both back from vacay.
Even then, given that signing in and out resolves the issue, that indicates that this is temporary, so I could equally see the argument that we should close this for focus. Leaving that up to @arosiclair.
arosiclair commentedon Dec 27, 2022
Yeah let's just close this out for now as this may never come up again after sequence numbers is finished. If it does, we can just reopen and take another look.