Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to https://staging.new.expensify.com/
- Login with any account
- Click on the global create button.
- Press "CTRL+K" (command + k on mac).
- Notice that the global create menu stays open with right pane.
- Click the chat area outside of both global create menu and right pane. Notice that neither close.
- Try to click the X in the top right corner of right pane. Notice it does not close.
Expected Result:
Global create menu must close when typing command + K (which opens right pane). Further, when this happens, the user should be able to successfully interact with the menu options in the right pane, and close it,
Actual Result:
- The global create menu stays open alongside the right pane when typing command + k
- User cannot close global create or right pane menus.
Workaround:
command + r force reloads the browser on web and resolves the issue.
Platform:
Where is this issue occurring?
- Web
Version Number: 1.2.33.2
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5841380_Recording__3139.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~015fb8fe5245972fe6
- Upwork Job ID: 1598081974853922816
Activity
melvin-bot commentedon Nov 29, 2022
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.joekaufmanexpensify commentedon Nov 29, 2022
From this SO: https://stackoverflow.com/c/expensify/questions/14418
joekaufmanexpensify commentedon Nov 29, 2022
This is def a bug. I reproduced on web:

Discussing the exact scope of the bug in slack before proceeding.
0xmiroslav commentedon Nov 29, 2022
Proposal
This is a regression from #12369 while refactoring SidebarScreen component
I think @hannojg copy & pasted wrong code while moving from
BaseSidebarScreentoFloatingActionButtonAndPopoverbefore:
https://github.com/Expensify/App/pull/12369/files#diff-f7e236efc5a983c060cc5a2d7cc21f7652846c2ba06d60fe423923d34fb65d07L135-L142
after:
https://github.com/Expensify/App/pull/12369/files#diff-40808ea273b560cf38c380dba4aec5e6ee292520491ca8d78882df891e4f550dR149-R158
Solution:
https://github.com/Expensify/App/blob/main/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js#L149-L158
hideCreateMenu() { - if (this.isScreenInactive()) { + if (!this.state.isCreateMenuActive) { - // Prevent showing menu when click FAB icon quickly after opening other pages return; } this.props.onHideCreateMenu(); this.setState({ isCreateMenuActive: false, }); }hannojg commentedon Nov 30, 2022
Oh yeah, that's very likely - good catch!
joekaufmanexpensify commentedon Nov 30, 2022
Finished triaging this. My thinking is we can handle this externally. Assigning engineering to confirm!
melvin-bot commentedon Nov 30, 2022
Triggered auto assignment to @mountiny (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Nov 30, 2022
Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.
mountiny commentedon Nov 30, 2022
@0xmiroslav Good catch, can you please create a PR for this with all the testing it requires
29 remaining items
[-][$1000] Web - The "FAB" menu and the sidebar can be opened at the same time[/-][+][Hold for payment 2022-12-20] Web - The "FAB" menu and the sidebar can be opened at the same time[/+]mountiny commentedon Dec 14, 2022
I dont think there are any changes to the checklist or our process required to prevent this issue, this was a mistake all reviewers missed so the best way is for us to be more thorough in the review and with the testrail test, this should not happen again.
mountiny commentedon Dec 14, 2022
@joekaufmanexpensify Will you be able to add a testRail regression test please?
joekaufmanexpensify commentedon Dec 14, 2022
Yep, will work on getting this added!
joekaufmanexpensify commentedon Dec 19, 2022
Proposed new regression test here.
joekaufmanexpensify commentedon Dec 20, 2022
Linked new regression test above in BZ checklist.
joekaufmanexpensify commentedon Dec 20, 2022
This was an issue where the BZ checklist/payment automation was not working, so moving this one back to daily manually as 7 days have passed with no regressions, so we can now issue payment.
joekaufmanexpensify commentedon Dec 20, 2022
@0xmiroslav $1,500 sent, and contract ended!
joekaufmanexpensify commentedon Dec 20, 2022
@sobitneupane $1,500 sent, and contract ended!
joekaufmanexpensify commentedon Dec 20, 2022
Job closed in Upwork.
joekaufmanexpensify commentedon Dec 20, 2022
Closing as this is all set!