Skip to content

[Hold for payment 2022-12-20] Web - The "FAB" menu and the sidebar can be opened at the same time #13159

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login with any account
  3. Click on the global create button.
  4. Press "CTRL+K" (command + k on mac).
  5. Notice that the global create menu stays open with right pane.
  6. Click the chat area outside of both global create menu and right pane. Notice that neither close.
  7. Try to click the X in the top right corner of right pane. Notice it does not close.

Expected Result:

Global create menu must close when typing command + K (which opens right pane). Further, when this happens, the user should be able to successfully interact with the menu options in the right pane, and close it,

Actual Result:

  1. The global create menu stays open alongside the right pane when typing command + k
  2. User cannot close global create or right pane menus.

Workaround:

command + r force reloads the browser on web and resolves the issue.

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.33.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5841380_Recording__3139.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 29, 2022
  2. melvin-bot commented on Nov 29, 2022

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. joekaufmanexpensify commented on Nov 29, 2022

    @joekaufmanexpensify
    Contributor

    From this SO: https://stackoverflow.com/c/expensify/questions/14418

    • The "bug" is actually a bug:
    • The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead):
    • The bug is reproducible, following the reproduction steps:
    • If you're unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.:
    • The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?):
    • The GH was created by an Expensify employee or a QA tester:
    • If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it's better to wait, close the GH & provide this justification:
    • If there's a link to Slack, check the discussion to see if we decided not to fix it:
    • Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label:
  4. joekaufmanexpensify commented on Nov 29, 2022

    @joekaufmanexpensify
    Contributor

    This is def a bug. I reproduced on web:
    2022-11-29_16-16-33 (1)

    Discussing the exact scope of the bug in slack before proceeding.

  5. 0xmiroslav commented on Nov 29, 2022

    @0xmiroslav
    Contributor

    Proposal

    This is a regression from #12369 while refactoring SidebarScreen component

    I think @hannojg copy & pasted wrong code while moving from BaseSidebarScreen to FloatingActionButtonAndPopover

    before:
    https://github.com/Expensify/App/pull/12369/files#diff-f7e236efc5a983c060cc5a2d7cc21f7652846c2ba06d60fe423923d34fb65d07L135-L142

        hideCreateMenu() {
            if (!this.state.isCreateMenuActive) {
                return;
            }
            this.props.onHideCreateMenu();
            this.setState({
                isCreateMenuActive: false,
            });
    

    after:
    https://github.com/Expensify/App/pull/12369/files#diff-40808ea273b560cf38c380dba4aec5e6ee292520491ca8d78882df891e4f550dR149-R158

        hideCreateMenu() {
            if (this.isScreenInactive()) {
                // Prevent showing menu when click FAB icon quickly after opening other pages
                return;
            }
            this.props.onHideCreateMenu();
            this.setState({
                isCreateMenuActive: false,
            });
        }
    

    Solution:

    https://github.com/Expensify/App/blob/main/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js#L149-L158

        hideCreateMenu() {
    -       if (this.isScreenInactive()) {
    +       if (!this.state.isCreateMenuActive) {
    -           // Prevent showing menu when click FAB icon quickly after opening other pages
                return;
            }
            this.props.onHideCreateMenu();
            this.setState({
                isCreateMenuActive: false,
            });
        }
  6. hannojg commented on Nov 30, 2022

    @hannojg
    Contributor

    I think @hannojg copy & pasted wrong code while moving from BaseSidebarScreen to FloatingActionButtonAndPopover

    Oh yeah, that's very likely - good catch!

  7. joekaufmanexpensify commented on Nov 30, 2022

    @joekaufmanexpensify
    Contributor

    Finished triaging this. My thinking is we can handle this externally. Assigning engineering to confirm!

  8. melvin-bot commented on Nov 30, 2022

    @melvin-bot

    Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 30, 2022
  10. melvin-bot commented on Nov 30, 2022

    @melvin-bot

    Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

  11. mountiny commented on Nov 30, 2022

    @mountiny
    Contributor

    @0xmiroslav Good catch, can you please create a PR for this with all the testing it requires

  12. 29 remaining items

  13. changed the title [-][$1000] Web - The "FAB" menu and the sidebar can be opened at the same time[/-] [+][Hold for payment 2022-12-20] Web - The "FAB" menu and the sidebar can be opened at the same time[/+] on Dec 14, 2022
  14. mountiny commented on Dec 14, 2022

    @mountiny
    Contributor

    I dont think there are any changes to the checklist or our process required to prevent this issue, this was a mistake all reviewers missed so the best way is for us to be more thorough in the review and with the testrail test, this should not happen again.

  15. mountiny commented on Dec 14, 2022

    @mountiny
    Contributor

    @joekaufmanexpensify Will you be able to add a testRail regression test please?

  16. joekaufmanexpensify commented on Dec 14, 2022

    @joekaufmanexpensify
    Contributor

    Yep, will work on getting this added!

  17. joekaufmanexpensify commented on Dec 19, 2022

    @joekaufmanexpensify
    Contributor

    Proposed new regression test here.

  18. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    Linked new regression test above in BZ checklist.

  19. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    This was an issue where the BZ checklist/payment automation was not working, so moving this one back to daily manually as 7 days have passed with no regressions, so we can now issue payment.

  20. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    @0xmiroslav $1,500 sent, and contract ended!

  21. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    @sobitneupane $1,500 sent, and contract ended!

  22. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    Job closed in Upwork.

  23. joekaufmanexpensify commented on Dec 20, 2022

    @joekaufmanexpensify
    Contributor

    Closing as this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions