Repository navigation
[HOLD for payment 2022-12-08] Workspace - Delete workspace error icon & message do not appear for failed scenario #13192
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Access staging.new.expensify.com
- Log into an account that has the necessary pre conditions applausetester@applause.expensifail.com
- Navigate to Workspaces > Error Test
- Disable the internet connection in the device
- Click/Tap on the 3 dots and select "Delete Workspace"
- Confirm the modal to delete the workspace
- Verify the workspace is now displayed with a strikethrough indicating it will be deleted when back online
- Enable the internet connection in the device
Expected Result:
User should see a red dot on the profile icon and the workspace has an error below indicating "You cannot delete this workspace because it's set as the domain restricted one for a domain security group"
Actual Result:
The user sees a red dot on the profile icon but the user does not see any error message on the workspace setting. The workspace that was deleted when offline also no longer shows
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.34.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5842354_No_error_message_is_seen.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
[-]Delete workspace error icon & message do not appear for failed scenario[/-][+]Workspace - Delete workspace error icon & message do not appear for failed scenario[/+]OSBotify commentedon Nov 30, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 30, 2022
Triggered auto assignment to @aldo-expensify (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.aldo-expensify commentedon Nov 30, 2022
The backend is responding with the expected error:
aldo-expensify commentedon Nov 30, 2022
The policy is still in Onyx, with the error, this looks fine...
aldo-expensify commentedon Nov 30, 2022
This may be the PR that caused the regression: #12971
I'm not sure why it is intentionally filtering out workspaces that have pending action 'delete':
aldo-expensify commentedon Nov 30, 2022
cc @jasperhuangg
aldo-expensify commentedon Nov 30, 2022
Closed by mistake
luacmartins commentedon Nov 30, 2022
Fix was merged. Closing this issue!
luacmartins commentedon Nov 30, 2022
Thanks for the quick work @aldo-expensify!
[-]Workspace - Delete workspace error icon & message do not appear for failed scenario[/-][+][HOLD for payment 2022-12-08] Workspace - Delete workspace error icon & message do not appear for failed scenario[/+]melvin-bot commentedon Dec 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-08. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue: