Repository navigation
Description
Problem
Coming from this comment and this thread, there are a few inconsistencies with the Split Bill flow that we need to address:
-
Users should be able to deselect members when the split is initiated from an existing group Correct the logic for when bill split particpants can be selected #13279
-
Splits initiated from an existing group should always post the Split message to the respective group. Additionally, it should not create a separate group if users deselected participants. There's a limit of 9 participants in the selection.
Example:
- As memberA: create a groupDM with memberB, memberC & memberD
- Go to the “+” menu inside the groupDM > click “Split bill”
- Enter $100 > click Next
- Deselect memberD > click Split $100
- The split message from memberA is added to the groupDM: Split $100 with memberB and memberC
- In the memberA:memberB DM the request action from memberA is added: Requested $33.33 from memberB
- In the memberA:memberC DM the request action from memberA is added: Requested $33.33 from memberC
- In the memberA:memberD DM there is nothing added, as memberD was excluded from the split.
-
Similarly, a bill split initiated from within a policy room should add a split message to the room and create off-policy IOUs in each individual DM. There's no participant limit here.
-
When splitting a bill with a single participant, the split message should still be posted to the chat.
Example:
- As memberA, create a groupDM with memberB and memberC
- Go to the + menu inside the groupDM > click Split bill
- Enter $100 > click Next
- Deselect memberC > click Split $100
- The split message from memberA is added to the groupDM: Split $100 with memberB
- In the memberA:memberB DM the request action from memberA is added: Requested $50.00 from memberB
- In the memberA:memberC DM there is nothing added, as memberC was excluded from the split.
Why is this important?
It's the expected behavior for Split Bill flows
Solution
Fix the flow!
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0181093ec5c397a56b
- Upwork Job ID: 1608288606003535872
- Last Price Increase: 2022-12-29
Activity
melvin-bot commentedon Dec 16, 2022
@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
luacmartins commentedon Dec 16, 2022
PR in review!
melvin-bot commentedon Dec 26, 2022
@luacmartins Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Dec 28, 2022
@luacmartins Still overdue 6 days?! Let's take care of this!
mananjadhav commentedon Dec 29, 2022
@luacmartins Can you please assign someone to help with the payment of the issue?
melvin-bot commentedon Dec 29, 2022
Job added to Upwork: https://www.upwork.com/jobs/~0181093ec5c397a56b
melvin-bot commentedon Dec 29, 2022
Current assignee @mananjadhav is eligible for the Internal assigner, not assigning anyone new.
mallenexpensify commentedon Dec 29, 2022
@mananjadhav can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0181093ec5c397a56b
mananjadhav commentedon Dec 30, 2022
Accepted @mallenexpensify
mallenexpensify commentedon Dec 30, 2022
Paid @mananjadhav $1000
@luacmartins we want regression test steps for this since it was a bug, right?
luacmartins commentedon Jan 4, 2023
@mallenexpensify thanks for checking! Yes, we should update the Split Bill tests to match the new expected behavior as follows:
No extra groups created
Splitting a bill with a single participant
Split a bill from a policy room
mallenexpensify commentedon Jan 4, 2023
Thanks @luacmartins, For
No extra groups createdandSplitting a bill with a single participantthe current steps listed here are below. #9 has an abbreviated version of what you recommend, do you think it's good enough to leave as is?I think we need a whole new test for
Split a bill from a policy roomluacmartins commentedon Jan 4, 2023
@mallenexpensify I think that we need new tests for all scenarios, since they are distinct from the steps you linked.
luacmartins commentedon Jan 5, 2023
Created a regression test issue here. I believe that we are all done here. Closing.
mallenexpensify commentedon Jan 6, 2023
Thanks @luacmartins. I'm still learning the details on the regression test steps.
How often do you think the test steps listed in the PR will align with the test steps added to TestRail? I wonder if it's best practice for BZ to review and possibly use those steps instead of starting from scratch each time.
luacmartins commentedon Jan 6, 2023
I'd say that the QA steps listed in the PR should almost always align with what is on TestRail. We are asking Applause to test the PR with those steps once after all, so this should be the case during regression tests too. We just need to make sure that the steps fit in with the other existing steps if we are updating an existing test case though.