You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-31] Display avatars & avatar thumbnails correctly in app #13555
Ok problem number one: There's a few places in the server & OldDot that need to be updated to get avatar thumbnail URL no matter what the URL is (now that we're storing different avatar URLs like png, jpg, gif, bmp [update: only should be storing JPEG & PNG soon])
changed the title [-]Display avatars & avatar thumbnails correctly in app[/-][+][HOLD for payment 2023-03-31] Display avatars & avatar thumbnails correctly in app[/+]on Mar 24, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-31. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rushatgabhane / @Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rushatgabhane / @Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@isabelastisser] Determine if we should create a regression test for this bug.
[@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@Beamanator I just noticed the title of this issue payment and wanted to confirm that since this is internal, I don't need to hire contributors in Upwork and process payments, correct?
What are the next steps here before this can be closed?
Activity
melvin-bot commentedon Dec 13, 2022
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Beamanator commentedon Dec 13, 2022
WIP PR is here: #13366
isabelastisser commentedon Dec 14, 2022
Hey @Beamanator, is this an internal issue? I noticed the Engineering label, and I'm not sure what are my next steps in the process.
Beamanator commentedon Dec 14, 2022
@isabelastisser yes! I'm working on the fix so I just marked it internal :D
Beamanator commentedon Dec 14, 2022
Ok problem number one: There's a few places in the server & OldDot that need to be updated to get avatar thumbnail URL no matter what the URL is (now that we're storing different avatar URLs like png, jpg, gif, bmp [update: only should be storing JPEG & PNG soon])
Problem number two: For some reason I only see
avatarstored in Onyx, notavatarThumbnail, which comes back from the server and is stored in Onyx here: https://github.com/Expensify/Web-Expensify/blob/da84c28aa29364b043189faf240af69683079be4/lib/UserAPI.php#L2768-L2769avatarfor some reasonformatPersonalDetails) but we deleted thatBeamanator commentedon Dec 15, 2022
Dropping to weekly b/c I can't get to this immediately & it's not super high priority (I have a WIP PR: https://github.com/Expensify/Web-Expensify/pull/35828)
49 remaining items
[-]Display avatars & avatar thumbnails correctly in app[/-][+][HOLD for payment 2023-03-31] Display avatars & avatar thumbnails correctly in app[/+]MelvinBot commentedon Mar 24, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 24, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-31. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Mar 24, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
MelvinBot commentedon Mar 24, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
isabelastisser commentedon Mar 31, 2023
@Beamanator I just noticed the title of this issue
paymentand wanted to confirm that since this isinternal, I don't need to hire contributors in Upwork and process payments, correct?What are the next steps here before this can be closed?
Thanks!
Beamanator commentedon Apr 3, 2023
@isabelastisser Actually we do need to pay out @rushatgabhane as the C+ since he reviewed my internal PR 👍 😬
isabelastisser commentedon Apr 3, 2023
I created the job in Upwork and hired @rushatgabhane for the C+ review.
isabelastisser commentedon Apr 3, 2023
Payment issued in Upwork, all set!
@Beamanator can we close the issue?
Beamanator commentedon Apr 3, 2023
Awesome sauce! Yep we can close now 👍