Skip to content

[HOLD for payment 2023-03-31] Display avatars & avatar thumbnails correctly in app #13555

Closed

Description

@Beamanator

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Inspect avatar in LHN (in chrome dev tools)

Expected Result:

  1. The avatar URL should be the thumbnail avatar, which is the URL ending in _128.

Actual Result:

  1. Notice the avatar URL doesn't have _128. at the end, indicating it's not the thumbnail URL

Workaround:

Yes

Platform:

Where is this issue occurring?

  • Web
  • iOS (probably)
  • Android (probably)
  • Desktop App
  • Mobile Web

Version Number: Latest
Reproducible in staging?: Y
Reproducible in production?: Y
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670258536848779?thread_ts=1669089889.220939&cid=C049HHMV9SM

View all open jobs on GitHub

Activity

  1. self-assigned this
    on Dec 13, 2022
  2. melvin-bot commented on Dec 13, 2022

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Dec 13, 2022
  4. Beamanator commented on Dec 13, 2022

    @Beamanator
    ContributorAuthor

    WIP PR is here: #13366

  5. isabelastisser commented on Dec 14, 2022

    @isabelastisser
    Contributor

    Hey @Beamanator, is this an internal issue? I noticed the Engineering label, and I'm not sure what are my next steps in the process.

  6. added
    InternalRequires API changes or must be handled by Expensify staff
    on Dec 14, 2022
  7. Beamanator commented on Dec 14, 2022

    @Beamanator
    ContributorAuthor

    @isabelastisser yes! I'm working on the fix so I just marked it internal :D

  8. Beamanator commented on Dec 14, 2022

    @Beamanator
    ContributorAuthor

    Ok problem number one: There's a few places in the server & OldDot that need to be updated to get avatar thumbnail URL no matter what the URL is (now that we're storing different avatar URLs like png, jpg, gif, bmp [update: only should be storing JPEG & PNG soon])

    Problem number two: For some reason I only see avatar stored in Onyx, not avatarThumbnail, which comes back from the server and is stored in Onyx here: https://github.com/Expensify/Web-Expensify/blob/da84c28aa29364b043189faf240af69683079be4/lib/UserAPI.php#L2768-L2769

  9. Beamanator commented on Dec 15, 2022

    @Beamanator
    ContributorAuthor

    Dropping to weekly b/c I can't get to this immediately & it's not super high priority (I have a WIP PR: https://github.com/Expensify/Web-Expensify/pull/35828)

  10. 49 remaining items

  11. changed the title [-]Display avatars & avatar thumbnails correctly in app[/-] [+][HOLD for payment 2023-03-31] Display avatars & avatar thumbnails correctly in app[/+] on Mar 24, 2023
  12. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-03-31. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane / @Beamanator] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane / @Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane / @Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@isabelastisser] Determine if we should create a regression test for this bug.
    • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. MelvinBot commented on Mar 24, 2023

    @MelvinBot
    Contributor

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  16. isabelastisser commented on Mar 31, 2023

    @isabelastisser
    Contributor

    @Beamanator I just noticed the title of this issue payment and wanted to confirm that since this is internal, I don't need to hire contributors in Upwork and process payments, correct?

    What are the next steps here before this can be closed?

    Thanks!

  17. Beamanator commented on Apr 3, 2023

    @Beamanator
    ContributorAuthor

    @isabelastisser Actually we do need to pay out @rushatgabhane as the C+ since he reviewed my internal PR 👍 😬

  18. isabelastisser commented on Apr 3, 2023

    @isabelastisser
    Contributor

    I created the job in Upwork and hired @rushatgabhane for the C+ review.

  19. isabelastisser commented on Apr 3, 2023

    @isabelastisser
    Contributor

    Payment issued in Upwork, all set!

    @Beamanator can we close the issue?

  20. Beamanator commented on Apr 3, 2023

    @Beamanator
    ContributorAuthor

    Awesome sauce! Yep we can close now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions