You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-02-23] Web - Chat - Overlapping of two modal windows #13871
// There are modals that can show up on top of these pop-overs, for example, the keyboard shortcut menu,
// if that happens, close the pop-over as if we were clicking outside.
props.onClose();
returnnull;
}
Solution:
call onClose() only when isShortcutsModalOpen is updated.
Since this is function component, useEffect() can be used, but I think it's better to move this logic to PopoverMenucomponentDidUpdate
That's funny because I used to have it in the componentDidUpdate and changed it back 😄 Either way, the issue you link it's going to refactor the whole thing so I don't think we need to fix it right now since it's not breaking anything in particular.
That's funny because I used to have it in the componentDidUpdate and changed it back 😄 Either way, the issue you link it's going to refactor the whole thing so I don't think we need to fix it right now since it's not breaking anything in particular.
Oh, any reason you decided to revert back? Just to avoid using useEffect?
Yeah, it's not a regression, it has never worked since it was a limitation of modals as the solution here was actually closing whatever is already open because modals don't support more than one in a efficient way.
Activity
davidcardoza commentedon Dec 29, 2022
i am heading out of the office. I am going to reassign this out to make sure the issue is being evaluated properly.
pecanoro commentedon Dec 29, 2022
@laurenreidexpensify I think we have two options here:
pecanoro commentedon Jan 3, 2023
Bringing this discussion to slack! https://expensify.slack.com/archives/C01GTK53T8Q/p1672748440121389
39 remaining items
situchan commentedon Feb 19, 2023
I found regression from #13956 which fixes this issue.

Dev console error shows when press Cmd+I while any popover is open
Root cause:
It's bad practice to call function directly in
render():App/src/components/Popover/index.js
Lines 26 to 32 in a5b9c9b
Solution:
call
onClose()only whenisShortcutsModalOpenis updated.Since this is function component,
useEffect()can be used, but I think it's better to move this logic to PopoverMenucomponentDidUpdatepecanoro commentedon Feb 20, 2023
That's funny because I used to have it in the componentDidUpdate and changed it back 😄 Either way, the issue you link it's going to refactor the whole thing so I don't think we need to fix it right now since it's not breaking anything in particular.
situchan commentedon Feb 20, 2023
Oh, any reason you decided to revert back? Just to avoid using
useEffect?pecanoro commentedon Feb 20, 2023
No reason at all, to simplify the code after @mananjadhav suggestion here.
mananjadhav commentedon Feb 24, 2023
@pecanoro @MitchExpensify Are we good to use the Testing steps from the PR for regression test proposal? I think they're straight forward.
Do we agree 👍 or 👎
Also I am not sure how do I link the PR? This didn't work since the time we've added the Popovers and KeyboardShortcutsModal .
pecanoro commentedon Feb 24, 2023
Yeah, it's not a regression, it has never worked since it was a limitation of modals as the solution here was actually closing whatever is already open because modals don't support more than one in a efficient way.
mananjadhav commentedon Feb 24, 2023
Thanks for the comment.
@MitchExpensify quick follow up on the payment here.
MitchExpensify commentedon Feb 27, 2023
Thanks @mananjadhav ! I was OOO on Friday, paying now!
MitchExpensify commentedon Feb 27, 2023
Done!
mananjadhav commentedon Feb 27, 2023
Thanks @MitchExpensify