You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-02-07] Make app start TTI more accurate #13996
When the app starts we measure the time it takes until the SidebarLinks are rendered, known as "App start TTI".
This measurement is reported to Grafana. Currently any waiting time due to waiting on network data is included in the TTI. This PR changes that, and will only report the TTI when we render the SidebarLinks with cached data on the first render.
Currently when reporting to grafana no information about the environment is included, meaning data from staging and production is mixed. This PR also adds env info to the grafana logging.
Only report TTI from cached render results (we want to know if we introduced performance regression issues in the code, not whether the API is slow to respond)
Events reported to grafana include environment information
Actual Result:
/
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes they can, this is just for internal performance monitoring.
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.48-2 Reproducible in staging?: N/A Reproducible in production?: N/A Email or phone of affected tester (no customers): N/A Logs: N/A Notes/Photos/Videos: N/A Expensify/Expensify Issue URL: N/A Issue reported by:@hannojg Slack conversation: None, but this issue #11997
@AndrewGable LOL so I do need to make a payment via Upwork?
Who is the C+ on this that needs payment? I'm not sure who was considered Margelo and who needs to be paid via Upwork.
Activity
melvin-bot commentedon Jan 5, 2023
📣 @hannojg! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖
melvin-bot commentedon Jan 5, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.hannojg commentedon Jan 5, 2023
I just created this PR for the issue: #13997
abekkala commentedon Jan 5, 2023
@hannojg did you report this bug in the #expensify-open-source Slack channel? (As you don't directly open issues in this repo)
If so, can you link to that slack conversation please?
hannojg commentedon Jan 5, 2023
Oh yeah, sorry, I didn't 😅 I am from Margelo and this issue was created as part of Margelos collaboration working week in SF with Expensify.
AndrewGable commentedon Jan 6, 2023
Confirmed @abekkala - Working with @hannojg on this one. They get paid hourly so no need to worry about upwork.
melvin-bot commentedon Jan 13, 2023
@AndrewGable, @abekkala, @hannojg Whoops! This issue is 2 days overdue. Let's get this updated quick!
14 remaining items
aimane-chnaif commentedon Feb 9, 2023
C+ Payment is pending for internal PR review
AndrewGable commentedon Feb 9, 2023
@abekkala - Can you please handle? Thanks!
abekkala commentedon Feb 10, 2023
@AndrewGable LOL so I do need to make a payment via Upwork?
Who is the C+ on this that needs payment? I'm not sure who was considered Margelo and who needs to be paid via Upwork.
aimane-chnaif commentedon Feb 10, 2023
I am C+ and @hannojg is from Margelo. I am only the one to be paid via upwork
abekkala commentedon Feb 10, 2023
@aimane-chnaif I've sent you a contract/offer via Upwork.
Once accepted I'll send payment :)
abekkala commentedon Feb 10, 2023
Payment has been sent, the contract has been completed, and the Upwork job post has been closed.