Skip to content

[HOLD for payment 2023-02-07] Make app start TTI more accurate #13996

Closed

Description

@hannojg

Action Performed:

  • When the app starts we measure the time it takes until the SidebarLinks are rendered, known as "App start TTI".
    This measurement is reported to Grafana. Currently any waiting time due to waiting on network data is included in the TTI. This PR changes that, and will only report the TTI when we render the SidebarLinks with cached data on the first render.
  • Currently when reporting to grafana no information about the environment is included, meaning data from staging and production is mixed. This PR also adds env info to the grafana logging.

This is an effort towards: #11997

Expected Result:

  • Only report TTI from cached render results (we want to know if we introduced performance regression issues in the code, not whether the API is slow to respond)
  • Events reported to grafana include environment information

Actual Result:

/

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Yes they can, this is just for internal performance monitoring.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.48-2
Reproducible in staging?: N/A
Reproducible in production?: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Notes/Photos/Videos: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @hannojg
Slack conversation: None, but this issue #11997

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 5, 2023
  2. melvin-bot commented on Jan 5, 2023

    @melvin-bot

    📣 @hannojg! 📣
    Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
    Instructions here to join the channel 📖

  3. melvin-bot commented on Jan 5, 2023

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. hannojg commented on Jan 5, 2023

    @hannojg
    ContributorAuthor

    I just created this PR for the issue: #13997

  5. abekkala commented on Jan 5, 2023

    @abekkala
    Contributor

    @hannojg did you report this bug in the #expensify-open-source Slack channel? (As you don't directly open issues in this repo)

    If so, can you link to that slack conversation please?

  6. hannojg commented on Jan 5, 2023

    @hannojg
    ContributorAuthor

    Oh yeah, sorry, I didn't 😅 I am from Margelo and this issue was created as part of Margelos collaboration working week in SF with Expensify.

  7. AndrewGable commented on Jan 6, 2023

    @AndrewGable
    Contributor

    Confirmed @abekkala - Working with @hannojg on this one. They get paid hourly so no need to worry about upwork.

  8. melvin-bot commented on Jan 13, 2023

    @melvin-bot

    @AndrewGable, @abekkala, @hannojg Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. 14 remaining items

  10. removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Feb 9, 2023
  11. aimane-chnaif commented on Feb 9, 2023

    @aimane-chnaif
    Contributor

    C+ Payment is pending for internal PR review

  12. AndrewGable commented on Feb 9, 2023

    @AndrewGable
    Contributor

    @abekkala - Can you please handle? Thanks!

  13. abekkala commented on Feb 10, 2023

    @abekkala
    Contributor

    @AndrewGable LOL so I do need to make a payment via Upwork?
    Who is the C+ on this that needs payment? I'm not sure who was considered Margelo and who needs to be paid via Upwork.

  14. aimane-chnaif commented on Feb 10, 2023

    @aimane-chnaif
    Contributor

    I am C+ and @hannojg is from Margelo. I am only the one to be paid via upwork

  15. abekkala commented on Feb 10, 2023

    @abekkala
    Contributor

    @aimane-chnaif I've sent you a contract/offer via Upwork.
    Once accepted I'll send payment :)

  16. abekkala commented on Feb 10, 2023

    @abekkala
    Contributor

    Payment has been sent, the contract has been completed, and the Upwork job post has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions