Repository navigation
Request/Split bill - Page crash after money request/Split bill while offline #14136
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Preconditions: Login to yuriy.turbo+ch7@gmail.com/Aa111111
- Open Desktop App or Chrome Web
- Go Offline
- Make money request or Split bill
- Restart the App if issue is not reproduced and try again
Expected Result:
The user should be able to use Money request or Split bill while offline without any issues
Actual Result:
Page crash after money request/Split bill while offline
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Web / Chrome
- Android app
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.50.13
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): yuriy.turbo+ch7@gmail.com/Aa111111
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5889289_Screen_Recording_2023-01-09_at_12.07.49.mp4
mobizen_20230109_220400.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ad625fac3be8adfa
- Upwork Job ID: 1613530024908873728
- Last Price Increase: 2023-01-12
Activity
melvin-bot commentedon Jan 9, 2023
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.amyevans commentedon Jan 9, 2023
Self-assigning. I tried a few times on prod to repro and couldn't, so I'm still curious to see if you can repro @adelekennedy (and if there are more reliable repro steps to do so). But I see the line of code where the error is from the video and should be able to add some defense against a crash. Will look into this one a bit closer later today or early tomorrow.
adelekennedy commentedon Jan 9, 2023
@amyevans it's not reproducible for me either, adding the needs reproducing label for additional 👀
adelekennedy commentedon Jan 11, 2023
hmm still not able to reproduce @amyevans did you want to take this and make it internal?
amyevans commentedon Jan 12, 2023
Sounds good!
1 remaining item
melvin-bot commentedon Jan 12, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ad625fac3be8adfa
melvin-bot commentedon Jan 12, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (
Internal)amyevans commentedon Jan 23, 2023
Have more pressing priorities, will circle back to this as soon as possible though (but it's just clean up at this point).
adelekennedy commentedon Feb 2, 2023
not overdue!
sobitneupane commentedon Feb 2, 2023
I believe this issue is not reproducible any longer. This issue was handled in #14355 by this PR.
amyevans commentedon Feb 2, 2023
Oh nice, thanks for calling attention to that @sobitneupane. This issue definitely looks to be a dupe of #14355, which has a fixed deployed as of last week. Closing.