You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[hold for payment 2023-01-30] Profile picture on profile page should have 0 px padding or margin from top navigation #14182
Open settings and check the padding from top navigation for profile image
Open Workspaces
Open any Workspace and check the margin from top navigation for Workspace profile
Open general settings and check the margin from top navigation for Workspace profile
Open any report
Click on any user name and check the padding from top navigation for user profile
Open settings
Open profile and check the padding or margin from top navigation for profile image
Expected Result:
All instances where the Profile image appears in the app should have a consistent amount of top padding.
Actual Result:
Profile image has no margin or padding on the top.
Note: (Other pages with profile maintains 20 px margin or padding from navigation)
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.51-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead): N/A
The bug is reproducible, following the reproduction steps: Y
If you're unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.: N/A
The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?): Y
The GH was created by an Expensify employee or a QA tester: Y
If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it's better to wait, close the GH & provide this justification: N/A
If there's a link to Slack, check the discussion to see if we decided not to fix it: N/A
Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label: Going to keep this internal.
Okay, this is reproduced. Before we proceed, discussing what the actual fix looks like here in the slack thread. Let's hold off on proceeding until we're crisp on that.
Discussed in the slack thread, and the solution we want for fixing this bug is leaving no top padding on the profile page, and removing the top padding for the profile image on the Settings page, the workspace page, the workspace general settings page, and the details page accessed when clicking another user's profile image.
Updating the OP of the issue to make this clear, and then making this internal.
Besides that, only other step here is the BZ checklist. Not sure why it didn't get automatically created, so will add it manually!
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@arosiclair ] The PR that introduced the bug has been identified. Link to the PR:
[@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@arosiclair ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: LINK
changed the title [-]Profile picture on profile page should have 20 px padding or margin from top navigation[/-][+][hold for payment 2023-01-30] Profile picture on profile page should have 20 px padding or margin from top navigation[/+]on Jan 26, 2023
Finding it very hard to find when exactly the spacing on top of the profile page was removed. It definitely had some spacing originally, but the profile page history is long with a lot of layout changes. Since this is a low impact bug and we had a big redesign, I'll skip that part and just post a thread on how to possibly keep this from occurring again.
changed the title [-][hold for payment 2023-01-30] Profile picture on profile page should have 20 px padding or margin from top navigation[/-][+][hold for payment 2023-01-30] Profile picture on profile page should have 0 px padding or margin from top navigation[/+]on Jan 31, 2023
Okay, ended up not creating a new regression test here. Since this is more design focused, I instead added it to the new design testing guidelines we're creating for applause.
Activity
joekaufmanexpensify commentedon Jan 10, 2023
Discussing here.
joekaufmanexpensify commentedon Jan 11, 2023
Working on triaging this:
From this SO: https://stackoverflow.com/c/expensify/questions/14418
joekaufmanexpensify commentedon Jan 11, 2023
@arosiclair once this is triaged, I'm thinking you want to take this one and keep it internal?
arosiclair commentedon Jan 12, 2023
Yup that's correct!
joekaufmanexpensify commentedon Jan 12, 2023
Sounds good!
joekaufmanexpensify commentedon Jan 12, 2023
Reproduced on web:
joekaufmanexpensify commentedon Jan 12, 2023
Okay, this is reproduced. Before we proceed, discussing what the actual fix looks like here in the slack thread. Let's hold off on proceeding until we're crisp on that.
joekaufmanexpensify commentedon Jan 13, 2023
Discussed in the slack thread, and the solution we want for fixing this bug is leaving no top padding on the profile page, and removing the top padding for the profile image on the Settings page, the workspace page, the workspace general settings page, and the details page accessed when clicking another user's profile image.
Updating the OP of the issue to make this clear, and then making this internal.
17 remaining items
joekaufmanexpensify commentedon Jan 26, 2023
Besides that, only other step here is the BZ checklist. Not sure why it didn't get automatically created, so will add it manually!
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-]Profile picture on profile page should have 20 px padding or margin from top navigation[/-][+][hold for payment 2023-01-30] Profile picture on profile page should have 20 px padding or margin from top navigation[/+]arosiclair commentedon Jan 30, 2023
Finding it very hard to find when exactly the spacing on top of the profile page was removed. It definitely had some spacing originally, but the profile page history is long with a lot of layout changes. Since this is a low impact bug and we had a big redesign, I'll skip that part and just post a thread on how to possibly keep this from occurring again.
joekaufmanexpensify commentedon Jan 30, 2023
Switching to daily as payment is due today.
joekaufmanexpensify commentedon Jan 30, 2023
@dhanashree-sawant $250 sent and contract ended!
joekaufmanexpensify commentedon Jan 30, 2023
Closed upwork job.
joekaufmanexpensify commentedon Jan 30, 2023
Proposed new regression test here.
[-][hold for payment 2023-01-30] Profile picture on profile page should have 20 px padding or margin from top navigation[/-][+][hold for payment 2023-01-30] Profile picture on profile page should have 0 px padding or margin from top navigation[/+]joekaufmanexpensify commentedon Jan 31, 2023
Okay, ended up not creating a new regression test here. Since this is more design focused, I instead added it to the new design testing guidelines we're creating for applause.
joekaufmanexpensify commentedon Jan 31, 2023
Closing as this is all set!