You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-02-02] Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates #14452
Pusher + UrbanAirship notifications may include ReportActions Onyx updates. However, we're in the process of re-keying reportActions to be keyed in Onyx by their reportActionID instead of their sequenceNumber. You can see the PR for that here.
Solution (part 1)
This issue represents part 1 of the rollout plan laid out here.
The task for this issue is to create an E/App PR with a temporary hack that intercepts Pusher / UrbanAirship Onyx updates, finds any reportActions updates, looks at the payload, and discards any update in which reportActions are not keyed by sequence-.
I know we reverted the PR, but commenting here to let you know that when it was deployed, it also caused this. Just so that we can test that next time to ensure it does not happen again.
changed the title [-]Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates[/-][+][HOLD for payment 2023-02-02] Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates[/+]on Jan 26, 2023
Activity
roryabraham commentedon Jan 23, 2023
PR merged, CPing to staging for #urgency here.
iwiznia commentedon Jan 24, 2023
I know we reverted the PR, but commenting here to let you know that when it was deployed, it also caused this. Just so that we can test that next time to ensure it does not happen again.
iwiznia commentedon Jan 24, 2023
ok, seems the revert did not change the behavior, some people can still reproduce the issue I was seeing (but not me)
roryabraham commentedon Jan 24, 2023
The code merged for this has since been reverted, and we decided not to implement this.
[-]Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates[/-][+][HOLD for payment 2023-02-02] Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates[/+]melvin-bot commentedon Jan 26, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 26, 2023
roryabraham commentedon Jan 26, 2023
No payments are due here, and the solution was merged.