Skip to content

[HOLD for payment 2023-02-02] Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates #14452

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Coming from https://expensify.slack.com/archives/C04DC6LU2UB/p1674243288556829?thread_ts=1674242808.964579&cid=C04DC6LU2UB

Problem

Pusher + UrbanAirship notifications may include ReportActions Onyx updates. However, we're in the process of re-keying reportActions to be keyed in Onyx by their reportActionID instead of their sequenceNumber. You can see the PR for that here.

Solution (part 1)

This issue represents part 1 of the rollout plan laid out here.

The task for this issue is to create an E/App PR with a temporary hack that intercepts Pusher / UrbanAirship Onyx updates, finds any reportActions updates, looks at the payload, and discards any update in which reportActions are not keyed by sequence-.

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bd6dfaa7206afad4
  • Upwork Job ID: 1616591563120336896
  • Last Price Increase: 2023-01-21

Activity

  1. self-assigned this
    on Jan 21, 2023
  2. locked and limited conversation to collaborators on Jan 21, 2023
  3. unlocked this conversation on Jan 21, 2023
  4. roryabraham commented on Jan 23, 2023

    @roryabraham
    ContributorAuthor

    PR merged, CPing to staging for #urgency here.

  5. iwiznia commented on Jan 24, 2023

    @iwiznia
    Contributor

    I know we reverted the PR, but commenting here to let you know that when it was deployed, it also caused this. Just so that we can test that next time to ensure it does not happen again.

  6. iwiznia commented on Jan 24, 2023

    @iwiznia
    Contributor

    ok, seems the revert did not change the behavior, some people can still reproduce the issue I was seeing (but not me)

  7. roryabraham commented on Jan 24, 2023

    @roryabraham
    ContributorAuthor

    The code merged for this has since been reverted, and we decided not to implement this.

  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 26, 2023
  9. changed the title [-]Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates[/-] [+][HOLD for payment 2023-02-02] Intercept Pusher + UrbanAirship notifications and only apply sequenceNumber-keyed updates[/+] on Jan 26, 2023
  10. melvin-bot commented on Jan 26, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jan 26, 2023

    @melvin-bot
  12. roryabraham commented on Jan 26, 2023

    @roryabraham
    ContributorAuthor

    No payments are due here, and the solution was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions