Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to URL https://staging.new.expensify.com/
- Log in with any account
- Go to Settings -> Workspace
- Navigate to the "Connect Bank Account" step
- Complete all necessary steps until you reach the personal information page (choose "connect manually")
- In the "issuing country" dropdown menu activate one value with the mouse and the other with the up/down tab arrows
Expected Result:
Only one value is highlighted
Actual Result:
Two values are highlighted simultaneously
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Web / Chrome
Version Number: 1.2.58.2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5908838_14414_Web.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010b3cf93c49bc4303
- Upwork Job ID: 1620664830680940544
- Last Price Increase: 2023-02-01
Metadata
Metadata
Assignees
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

Activity
melvin-bot commentedon Jan 23, 2023
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.sonialiap commentedon Jan 25, 2023
Sorry, reassigning. OOO for family situation
tjferriss commentedon Jan 26, 2023
I was able to reproduce the issue. I've started a conversation in Slack to confirm this is worth fixing now.
[-]Web - Onfido - Two values are highlighted simultaneously[/-][+][$1000] Web - Onfido - Two values are highlighted simultaneously[/+]11 remaining items
esh-g commentedon Feb 1, 2023
I think the country selection is done by the
onfido sdkand the fix would require an upstream fix in their repo, or we we could make another selection menu independent ofonfido sdkbut I doubt wether this issue is worth creating a new menuPujan92 commentedon Feb 1, 2023
I have raised the issue in the
onfido sdkrepo heres77rt commentedon Feb 5, 2023
A bit out of topic, anyone knows how to contribute in the
onfido-sdk-uilib? Edit: we can'tWithout source code we can't do much than ask the maintainers to fix the issue
rushatgabhane commentedon Feb 6, 2023
Looks like onfido doesn't think it's a bug https://github.com/onfido/onfido-sdk-ui/issues/2141
Let's close this issue?
MelvinBot commentedon Feb 6, 2023
@tjferriss @joelbettner @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
MelvinBot commentedon Feb 6, 2023
@tjferriss @joelbettner @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
MelvinBot commentedon Feb 6, 2023
@tjferriss @joelbettner @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
tjferriss commentedon Feb 6, 2023
Yes, if they're not going to fix then let's close this.
Pujan92 commentedon Mar 9, 2023
@tjferriss Shall we consider the mentioned selectors here for differentiate the hover and focus background colors and use the same colors which we have for our Options list in the application?
tjferriss commentedon Mar 14, 2023
Sorry, @Pujan92 I'm a little lost on your suggestion. Which application are you referring to? Could you spell out the proposal a little more clearly for me?
Pujan92 commentedon Mar 15, 2023
@tjferriss Currently in Expensify app we have
Options List(eg. currencies)where we have different bg colors for hover and focus option which is in the below image.So Onfido team suggested to use selectors to update color for that country selection dropdown and I meant to use same bg colors which we are using for
Options Listfor consistency. But now I am seeing we are not showing that country selection page with the help of this PR. With that my suggestion will be Void now.tjferriss commentedon Mar 15, 2023
Thanks for spelling that out. If we're removing this selector than it sounds like we should keep this issue closed.