Skip to content

[$1000] Web - Onfido - Two values are highlighted simultaneously #14489

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account
  3. Go to Settings -> Workspace
  4. Navigate to the "Connect Bank Account" step
  5. Complete all necessary steps until you reach the personal information page (choose "connect manually")
  6. In the "issuing country" dropdown menu activate one value with the mouse and the other with the up/down tab arrows

Expected Result:

Only one value is highlighted

Actual Result:

Two values are highlighted simultaneously

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Web / Chrome

Version Number: 1.2.58.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (1)

Bug5908838_14414_Web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010b3cf93c49bc4303
  • Upwork Job ID: 1620664830680940544
  • Last Price Increase: 2023-02-01

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 23, 2023
  2. melvin-bot commented on Jan 23, 2023

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Jan 23, 2023
  4. sonialiap commented on Jan 25, 2023

    @sonialiap
    Contributor

    Sorry, reassigning. OOO for family situation

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 25, 2023
  6. removed their assignment
    on Jan 25, 2023
  7. tjferriss commented on Jan 26, 2023

    @tjferriss
    Contributor

    I was able to reproduce the issue. I've started a conversation in Slack to confirm this is worth fixing now.

    Screen Shot 2023-01-26 at 12 49 25 PM

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 1, 2023
  9. unlocked this conversation on Feb 1, 2023
  10. changed the title [-]Web - Onfido - Two values are highlighted simultaneously[/-] [+][$1000] Web - Onfido - Two values are highlighted simultaneously[/+] on Feb 1, 2023
  11. 11 remaining items

  12. esh-g commented on Feb 1, 2023

    @esh-g
    Contributor

    I think the country selection is done by the onfido sdk and the fix would require an upstream fix in their repo, or we we could make another selection menu independent of onfido sdk but I doubt wether this issue is worth creating a new menu

  13. Pujan92 commented on Feb 1, 2023

    @Pujan92
    Contributor

    I have raised the issue in the onfido sdk repo here

  14. s77rt commented on Feb 5, 2023

    @s77rt
    Member

    A bit out of topic, anyone knows how to contribute in the onfido-sdk-ui lib? Edit: we can't
    Without source code we can't do much than ask the maintainers to fix the issue

  15. rushatgabhane commented on Feb 6, 2023

    @rushatgabhane
    Member

    Looks like onfido doesn't think it's a bug https://github.com/onfido/onfido-sdk-ui/issues/2141

    Let's close this issue?

  16. MelvinBot commented on Feb 6, 2023

    @MelvinBot
    Contributor

    @tjferriss @joelbettner @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  17. MelvinBot commented on Feb 6, 2023

    @MelvinBot
    Contributor

    @tjferriss @joelbettner @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  18. MelvinBot commented on Feb 6, 2023

    @MelvinBot
    Contributor

    @tjferriss @joelbettner @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  19. tjferriss commented on Feb 6, 2023

    @tjferriss
    Contributor

    Yes, if they're not going to fix then let's close this.

  20. Pujan92 commented on Mar 9, 2023

    @Pujan92
    Contributor

    @tjferriss Shall we consider the mentioned selectors here for differentiate the hover and focus background colors and use the same colors which we have for our Options list in the application?

  21. tjferriss commented on Mar 14, 2023

    @tjferriss
    Contributor

    Sorry, @Pujan92 I'm a little lost on your suggestion. Which application are you referring to? Could you spell out the proposal a little more clearly for me?

  22. Pujan92 commented on Mar 15, 2023

    @Pujan92
    Contributor

    @tjferriss Currently in Expensify app we have Options List(eg. currencies) where we have different bg colors for hover and focus option which is in the below image.

    Screenshot 2023-03-15 at 9 54 35 PM

    So Onfido team suggested to use selectors to update color for that country selection dropdown and I meant to use same bg colors which we are using for Options List for consistency. But now I am seeing we are not showing that country selection page with the help of this PR. With that my suggestion will be Void now.

  23. tjferriss commented on Mar 15, 2023

    @tjferriss
    Contributor

    Thanks for spelling that out. If we're removing this selector than it sounds like we should keep this issue closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions