You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-13] [$4000] The details view is broken for the room that is inaccessible to the user #14513
Sign in with another user that does not have access to that room
When "Hmm... it's not here" message shows up, append /details at the end of the URL to get details of that room
Expected Result:
If the user doesn't have access to the details view they visit, we should show a similar Hmm...it's not here page that we show when you try accessing a chat you don't have access to.
Actual Result:
The details view is broken
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
MacOS / Chrome / Safari
Version Number: v1.2.58-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Yeah, can't really think of any reason why someone would get themselves into this situation. But if you are on a Details view of a report you can't access then it would be fine to see the same "Hmm... it's not here" view on that screen.
changed the title [-]The details view is broken for the room that is inaccessible to the user[/-][+][$1000] The details view is broken for the room that is inaccessible to the user[/+]on Jan 30, 2023
changed the title [-][$4000] The details view is broken for the room that is inaccessible to the user[/-][+][HOLD for payment 2023-03-13] [$4000] The details view is broken for the room that is inaccessible to the user[/+]on Mar 8, 2023
Activity
melvin-bot commentedon Jan 24, 2023
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.sakluger commentedon Jan 24, 2023
This seems like a very specific edge-case issue. I'm asking in Slack if other people think we should fix it.
marcaaron commentedon Jan 27, 2023
Yeah, can't really think of any reason why someone would get themselves into this situation. But if you are on a
Detailsview of a report you can't access then it would be fine to see the same "Hmm... it's not here" view on that screen.sakluger commentedon Jan 30, 2023
Alright, for the sake of consistency, let's get this one fixed. Adding the
Externallabel![-]The details view is broken for the room that is inaccessible to the user[/-][+][$1000] The details view is broken for the room that is inaccessible to the user[/+]melvin-bot commentedon Jan 30, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fa0bb1360012489a
melvin-bot commentedon Jan 30, 2023
Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.
113 remaining items
mountiny commentedon Feb 27, 2023
@s77rt Updated
@luacmartins no, as commented above, that was the External label automation which assigned her because Andrew was ooo at the time.
MelvinBot commentedon Mar 6, 2023
@AndrewGable, @sakluger, @s77rt, @parasharrajat, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!
s77rt commentedon Mar 6, 2023
@MelvinBot The PR has been deployed to staging / production 4 days / 5 hours ago.
[-][$4000] The details view is broken for the room that is inaccessible to the user[/-][+][HOLD for payment 2023-03-13] [$4000] The details view is broken for the room that is inaccessible to the user[/+]parasharrajat commentedon Mar 9, 2023
My assignment was wrong. Bot marked it internal and assign me while proposals were being reviewed by another C+.
sakluger commentedon Mar 14, 2023
Looks like the automation didn't work perfectly here, so I'll add some items manually. Payments due:
Merged 4 days after Contributor assignment, so pretty quick, but does not qualify for efficiency bonus.
@s77rt I paid you out in Upwork. @adeel0202 @0xmiroslav I send you offers in Upwork, once you accept I can pay out.
Regarding regression testing, I don't think we need to add anything since we'll be updating the details view.
0xmiroslav commentedon Mar 14, 2023
There was a weekend 🙂
s77rt commentedon Mar 20, 2023
@sakluger I think timeline bonus applies here as @0xmiroslav clarified those 4 days included the weekend so it's about 2 business days.
mountiny commentedon Mar 20, 2023
Agree with @0xmiroslav and @s77rt it was merged on Feb 28 evening and @s77rt was assigned in the evening of Feb 24 so it was completed in two days
sakluger commentedon Mar 24, 2023
Thanks for clarifying, I added bonuses. Everyone has been paid out now, thanks!