Skip to content

[HOLD for payment 2023-03-13] [$4000] The details view is broken for the room that is inaccessible to the user #14513

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Sign in on web
  2. Open any room
  3. Copy its URL from the address bar
  4. Open incognito mode and paste the copied URL
  5. Sign in with another user that does not have access to that room
  6. When "Hmm... it's not here" message shows up, append /details at the end of the URL to get details of that room

Expected Result:

If the user doesn't have access to the details view they visit, we should show a similar Hmm...it's not here page that we show when you try accessing a chat you don't have access to.

image

Actual Result:

The details view is broken

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • MacOS / Chrome / Safari

Version Number: v1.2.58-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1353.mp4
broken.details.page.mov

Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674498377054109

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fa0bb1360012489a
  • Upwork Job ID: 1620192912854851584
  • Last Price Increase: 2023-02-24

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 24, 2023
  2. melvin-bot commented on Jan 24, 2023

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Jan 24, 2023
  4. sakluger commented on Jan 24, 2023

    @sakluger
    Contributor

    This seems like a very specific edge-case issue. I'm asking in Slack if other people think we should fix it.

  5. marcaaron commented on Jan 27, 2023

    @marcaaron
    Contributor

    Yeah, can't really think of any reason why someone would get themselves into this situation. But if you are on a Details view of a report you can't access then it would be fine to see the same "Hmm... it's not here" view on that screen.

  6. sakluger commented on Jan 30, 2023

    @sakluger
    Contributor

    Alright, for the sake of consistency, let's get this one fixed. Adding the External label!

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 30, 2023
  8. unlocked this conversation on Jan 30, 2023
  9. changed the title [-]The details view is broken for the room that is inaccessible to the user[/-] [+][$1000] The details view is broken for the room that is inaccessible to the user[/+] on Jan 30, 2023
  10. melvin-bot commented on Jan 30, 2023

    @melvin-bot
  11. melvin-bot commented on Jan 30, 2023

    @melvin-bot

    Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

  12. 113 remaining items

  13. mountiny commented on Feb 27, 2023

    @mountiny
    Contributor

    @s77rt Updated

    @luacmartins no, as commented above, that was the External label automation which assigned her because Andrew was ooo at the time.

  14. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    @AndrewGable, @sakluger, @s77rt, @parasharrajat, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. s77rt commented on Mar 6, 2023

    @s77rt
    Member

    @MelvinBot The PR has been deployed to staging / production 4 days / 5 hours ago.

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Mar 8, 2023
  17. changed the title [-][$4000] The details view is broken for the room that is inaccessible to the user[/-] [+][HOLD for payment 2023-03-13] [$4000] The details view is broken for the room that is inaccessible to the user[/+] on Mar 8, 2023
  18. removed their assignment
    on Mar 9, 2023
  19. parasharrajat commented on Mar 9, 2023

    @parasharrajat
    Member

    My assignment was wrong. Bot marked it internal and assign me while proposals were being reviewed by another C+.

  20. sakluger commented on Mar 14, 2023

    @sakluger
    Contributor

    Looks like the automation didn't work perfectly here, so I'll add some items manually. Payments due:

    Merged 4 days after Contributor assignment, so pretty quick, but does not qualify for efficiency bonus.

    @s77rt I paid you out in Upwork. @adeel0202 @0xmiroslav I send you offers in Upwork, once you accept I can pay out.

    Regarding regression testing, I don't think we need to add anything since we'll be updating the details view.

  21. 0xmiroslav commented on Mar 14, 2023

    @0xmiroslav
    Contributor

    Merged 4 days after Contributor assignment, so pretty quick, but does not qualify for efficiency bonus.

    There was a weekend 🙂

  22. s77rt commented on Mar 20, 2023

    @s77rt
    Member

    @sakluger I think timeline bonus applies here as @0xmiroslav clarified those 4 days included the weekend so it's about 2 business days.

  23. mountiny commented on Mar 20, 2023

    @mountiny
    Contributor

    Agree with @0xmiroslav and @s77rt it was merged on Feb 28 evening and @s77rt was assigned in the evening of Feb 24 so it was completed in two days

  24. sakluger commented on Mar 24, 2023

    @sakluger
    Contributor

    Thanks for clarifying, I added bonuses. Everyone has been paid out now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions