Repository navigation
[hold for payment 2023-02-02] Payment issue for E/App PR#13118 #14533
Description
Issue created to compensate the Contributor+ member for their work on #13118
E/E issue linked to the PR - https:://www.github.com/Expensify/App/issues/240913.
Contributor+ member who reviewed the PR - @rushatgabhane.
Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0103ceb0b6bee9b33a
- Upwork Job ID: 1618060006345211904
- Last Price Increase: 2023-01-25
Activity
melvin-bot commentedon Jan 25, 2023
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.joekaufmanexpensify commentedon Jan 25, 2023
PR is not yet on production, so 7 day waiting period hasn't yet begun.
joekaufmanexpensify commentedon Jan 26, 2023
Same.
joekaufmanexpensify commentedon Jan 27, 2023
App was deployed to prod yesterday, so payment will be issued on 2023-02-02 (assuming no regressions).
[-]Payment issue for E/App PR#13118[/-][+][hold for payment 2023-02-02] Payment issue for E/App PR#13118[/+]joekaufmanexpensify commentedon Jan 27, 2023
@rushatgabhane offer sent for $1000 via upwork!
joekaufmanexpensify commentedon Feb 2, 2023
The PR linked to this issue was mentioned in another issue . Just making sure that the individual who commented there didn't mean that they thought the PR here introduced the bug there before issuing payment. Will issue right after that is confirmed!
rushatgabhane commentedon Feb 3, 2023
@joekaufmanexpensify ah yes, that's a regression.
I encountered it whilst testing the PR, didn't report it for unknown reasons 🤷♀️.
Screen.Recording.2023-02-04.at.3.27.46.AM.mov
joekaufmanexpensify commentedon Feb 6, 2023
@rushatgabhane No worries! Just to clarify though, you didn't think that the PR captured in this issue caused this regression though, right? I'm thinking it did not (as that's what our QA tester advised), but just want to confirm.
joekaufmanexpensify commentedon Feb 7, 2023
@rushatgabhane bump on this when you have a sec. just want to make sure my understanding about this is correct before issuing payment.
rushatgabhane commentedon Feb 7, 2023
@joekaufmanexpensify i don't know what caused the regression.
But it was explicitly mentioned in the test steps for that PR. So yes, 50% cut should be applicable here
I hope that clears it up :)
joekaufmanexpensify commentedon Feb 7, 2023
Got it, thanks for confirming!
joekaufmanexpensify commentedon Feb 7, 2023
$500 sent (50% cut due to regression) and contract ended!
joekaufmanexpensify commentedon Feb 7, 2023
Upwork job closed.
joekaufmanexpensify commentedon Feb 7, 2023
Closing as this is all set!