Skip to content

[$1000] Workspace - The welcome message in Spanish is very close to the edge of the page #14564

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Preconditional: the language of account is Spanish

  1. Open the app and login
  2. Go to Settings -> Workspaces
  3. Delete all workspaces if they present

Expected Result:

The welcome message is NOT very close to the edge of the page

Actual Result:

The welcome message in Spanish is very close to the edge of the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome

Version Number: 1.2.59.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017201bf4137ca3d49
  • Upwork Job ID: 1619020840032911360
  • Last Price Increase: 2023-01-27

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 25, 2023
  2. locked and limited conversation to collaborators on Jan 25, 2023
  3. flaviadefaria commented on Jan 27, 2023

    @flaviadefaria
    Contributor

    I'm not really sure how to reproduce this given that the language of the account needs to be Spanish.

  4. kbecciv commented on Jan 27, 2023

    @kbecciv
    Author

    Please use expensifail account - change the language to Spanish and go to Settings - Workspace

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Jan 27, 2023
  6. unlocked this conversation on Jan 27, 2023
  7. changed the title [-]Workspace - The welcome message in Spanish is very close to the edge of the page[/-] [+][$1000] Workspace - The welcome message in Spanish is very close to the edge of the page[/+] on Jan 27, 2023
  8. melvin-bot commented on Jan 27, 2023

    @melvin-bot
  9. melvin-bot commented on Jan 27, 2023

    @melvin-bot

    Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

  10. flaviadefaria commented on Jan 27, 2023

    @flaviadefaria
    Contributor

    Thank you @kbecciv!

  11. 44 remaining items

  12. mananjadhav commented on Feb 12, 2023

    @mananjadhav
    Collaborator

    @flaviadefaria Can you please help with the payout? I've applied for the job post in the GH body.

  13. mananjadhav commented on Feb 13, 2023

    @mananjadhav
    Collaborator

    @flaviadefaria @francoisl quick bump on the payout

  14. francoisl commented on Feb 13, 2023

    @francoisl
    Contributor

    I don't have payment access in Upwork, sorry! I'll check in with @flaviadefaria to make sure she saw this.

  15. flaviadefaria commented on Feb 14, 2023

    @flaviadefaria
    Contributor

    Sorry I was OoO last Friday and catching up yesterday. I'll issue payment today.

    Also @francoisl @mananjadhav are you still going through this checklist? We can't close the issue until it's all checked off.

  16. mananjadhav commented on Feb 14, 2023

    @mananjadhav
    Collaborator

    Thanks for the comment @flaviadefaria. The BlockingView component was added to the WorkspacesListPage in this PR. Hence I think it makes sense to tag this PR for regression.

  17. flaviadefaria commented on Feb 14, 2023

    @flaviadefaria
    Contributor

    @situchan was assigned to the issue on Jan 31st and their PR was merged on Feb 1st = 50% bonus
    So both @situchan and @mananjadhav will receive a 50% bonus: $1000 + $500 = $1500

  18. flaviadefaria commented on Feb 14, 2023

    @flaviadefaria
    Contributor

    @mananjadhav you've been paid. @situchan I can't find you in Upwork, can you either apply for the job or share your first and last name in Upwork? Thanks!

  19. situchan commented on Feb 14, 2023

    @situchan
    Contributor

    @mananjadhav you've been paid. @situchan I can't find you in Upwork, can you either apply for the job or share your first and last name in Upwork? Thanks!

    Situ Chandra Shil

  20. flaviadefaria commented on Feb 14, 2023

    @flaviadefaria
    Contributor

    @mananjadhav are these the QA steps you're suggesting we use in the regression test?

    1. Login with any account
    2. If language is English, switch to Spanish in Settings -> Preferences
    3. Go to Settings -> Workspaces
    4. Delete all workspaces if they present
    5. Verify that title is centered and welcome message is NOT very close to the edge of the page
    6. Verify that no errors appear in the JS console
  21. flaviadefaria commented on Feb 14, 2023

    @flaviadefaria
    Contributor

    @mananjadhav and @situchan you've both been paid.

    @mananjadhav and @francoisl I've checked one of the tasks in this comment. Can you please look at the remaining ones with your names? Thanks!

  22. mananjadhav commented on Feb 14, 2023

    @mananjadhav
    Collaborator

    Yes @flaviadefaria we use the same steps.

    I've linked the PR for the regression. I am not sure if the discussion is needed in expensify-open-source. Will leave that to @francoisl .

  23. flaviadefaria commented on Feb 14, 2023

    @flaviadefaria
    Contributor

    I posted a discussion in Slack regarding adding the regression and it was decided we aren't optimizing tests for different languages yet.

    So @francoisl I guess now all remaining actions need to be done by you so that we can close this issue.

  24. francoisl commented on Feb 14, 2023

    @francoisl
    Contributor

    👍 All done.

  25. changed the title [-][HOLD for payment 2023-02-10] [$1000] Workspace - The welcome message in Spanish is very close to the edge of the page[/-] [+][$1000] Workspace - The welcome message in Spanish is very close to the edge of the page[/+] on Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions