Skip to content

[$500] Do not allow emojis to be formatted (ie italics) #14676

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to android app
  2. Go to any chat
  3. Try to make emoji in italic form:-Type in : insertemoji For example:⁦:100:, ⁦:purple_heart: , ⁦:partying_face: ,
  4. Notice that the top right part of the emoji cuts off. Few Example: the 💯, 💜, 🥳 emoji has its top right section cut , (It happens on android only latest)

Expected Result:

Users should not be able to format emojis, lets keep them with normal style (no bold, italics, strikethrough etc)

Actual Result:

Users can make emoji italic which leads to the emojis to cut off a few parts of the emoji (for some emojis)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • MacOS Desktop
  • MacOS Chrome Web

Version Number: 1.2.62-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675094271396099

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017d08e0c09284d31f
  • Upwork Job ID: 1620563000799895552
  • Last Price Increase: 2024-08-08
  • Automatic offers:
    • eh2077 | Reviewer | 0
    • wildan-m | Contributor | 0
Issue OwnerCurrent Issue Owner: @mallenexpensify / @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 30, 2023
  2. locked and limited conversation to collaborators on Jan 30, 2023
  3. anmurali commented on Jan 31, 2023

    @anmurali

    Confirmed that this happens on Android native app.

    Confirmed it does not happen on Mac/Chrome. But related, when I try the same reproduction steps on iOS native, iOS Chrome and Mac Safari - I cannot italicize emojis at all. Is that expected?

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 31, 2023
  5. unlocked this conversation on Jan 31, 2023
  6. changed the title [-]Making an emoji italic cuts the top right part of the emoji on android[/-] [+][$1000] Making an emoji italic cuts the top right part of the emoji on android[/+] on Jan 31, 2023
  7. melvin-bot commented on Jan 31, 2023

    @melvin-bot
  8. melvin-bot commented on Jan 31, 2023

    @melvin-bot

    Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on Jan 31, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 31, 2023
  11. melvin-bot commented on Jan 31, 2023

    @melvin-bot

    Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. 324 remaining items

  13. Skalakid commented on Dec 18, 2024

    @Skalakid
    Contributor

    Hi, we are waiting for this PR to be merged and after it's done we will merge my PR

  14. stitesExpensify commented on Jan 21, 2025

    @stitesExpensify
    Contributor

    Hey @Skalakid looks like your PR was closed, and we are moving things to expensimark, is that right?

  15. Skalakid commented on Jan 22, 2025

    @Skalakid
    Contributor

    Oh sorry, I totally forgot to write update under this issue. We've opened another PR that moves splitting logic from Android native code to TypeScript - new PR. It has been merged and we had to disable splitting logic for web in another PR. Both of them are deployed and now we are bumping the live markdown version to include these changes in the E/App - #55509

  16. stitesExpensify commented on Feb 25, 2025

    @stitesExpensify
    Contributor

    Hey @Skalakid just checking in again here 😄 Where are we at?

  17. Skalakid commented on Feb 26, 2025

    @Skalakid
    Contributor

    The issue has been fixed and the PR with the bump has been merged

  18. stitesExpensify commented on Feb 26, 2025

    @stitesExpensify
    Contributor

    Sorry, I'm not following. So what are the next steps?

  19. Skalakid commented on Feb 27, 2025

    @Skalakid
    Contributor

    I think the issue is fixed and we can close this one :D

  20. mallenexpensify commented on Feb 28, 2025

    @mallenexpensify
    Contributor
    Image

    eeeps, this is a doozy. Can contributors help me figure out who is owed what? (espec if there are multiple PRs and payments)

    Thx

  21. eh2077 commented on Feb 28, 2025

    @eh2077
    Contributor

    @mallenexpensify I think you can just close this as we have been paid here #14676 (comment) and @Skalakid is from agency.

  22. mallenexpensify commented on Feb 28, 2025

    @mallenexpensify
    Contributor

    Thanks, woah... payment was from forever ago
    Thanks @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions