You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Do not allow emojis to be formatted (ie italics) #14676
Try to make emoji in italic form:-Type in : insertemoji For example::100:, :purple_heart: , :partying_face: ,
Notice that the top right part of the emoji cuts off. Few Example: the 💯, 💜, 🥳 emoji has its top right section cut , (It happens on android only latest)
Expected Result:
Users should not be able to format emojis, lets keep them with normal style (no bold, italics, strikethrough etc)
Actual Result:
Users can make emoji italic which leads to the emojis to cut off a few parts of the emoji (for some emojis)
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
MacOS Desktop
MacOS Chrome Web
Version Number: 1.2.62-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Confirmed that this happens on Android native app.
Confirmed it does not happen on Mac/Chrome. But related, when I try the same reproduction steps on iOS native, iOS Chrome and Mac Safari - I cannot italicize emojis at all. Is that expected?
changed the title [-]Making an emoji italic cuts the top right part of the emoji on android[/-][+][$1000] Making an emoji italic cuts the top right part of the emoji on android[/+]on Jan 31, 2023
Oh sorry, I totally forgot to write update under this issue. We've opened another PR that moves splitting logic from Android native code to TypeScript - new PR. It has been merged and we had to disable splitting logic for web in another PR. Both of them are deployed and now we are bumping the live markdown version to include these changes in the E/App - #55509
Activity
anmurali commentedon Jan 31, 2023
Confirmed that this happens on Android native app.
Confirmed it does not happen on Mac/Chrome. But related, when I try the same reproduction steps on iOS native, iOS Chrome and Mac Safari - I cannot italicize emojis at all. Is that expected?
[-]Making an emoji italic cuts the top right part of the emoji on android[/-][+][$1000] Making an emoji italic cuts the top right part of the emoji on android[/+]melvin-bot commentedon Jan 31, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017d08e0c09284d31f
melvin-bot commentedon Jan 31, 2023
Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Jan 31, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)melvin-bot commentedon Jan 31, 2023
Triggered auto assignment to @flodnv (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.324 remaining items
Skalakid commentedon Dec 18, 2024
Hi, we are waiting for this PR to be merged and after it's done we will merge my PR
stitesExpensify commentedon Jan 21, 2025
Hey @Skalakid looks like your PR was closed, and we are moving things to expensimark, is that right?
Skalakid commentedon Jan 22, 2025
Oh sorry, I totally forgot to write update under this issue. We've opened another PR that moves splitting logic from Android native code to TypeScript - new PR. It has been merged and we had to disable splitting logic for web in another PR. Both of them are deployed and now we are bumping the live markdown version to include these changes in the E/App - #55509
stitesExpensify commentedon Feb 25, 2025
Hey @Skalakid just checking in again here 😄 Where are we at?
Skalakid commentedon Feb 26, 2025
The issue has been fixed and the PR with the bump has been merged
stitesExpensify commentedon Feb 26, 2025
Sorry, I'm not following. So what are the next steps?
Skalakid commentedon Feb 27, 2025
I think the issue is fixed and we can close this one :D
mallenexpensify commentedon Feb 28, 2025
eeeps, this is a doozy. Can contributors help me figure out who is owed what? (espec if there are multiple PRs and payments)
Thx
eh2077 commentedon Feb 28, 2025
@mallenexpensify I think you can just close this as we have been paid here #14676 (comment) and @Skalakid is from agency.
mallenexpensify commentedon Feb 28, 2025
Thanks, woah... payment was from forever ago
Thanks @eh2077