[HOLD for payment 2023-02-22] Blank screen appears tapping Start Over to continue to manual step

@hungvu193

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Login with any account
From LHN, open Workspace, make sure you already enter your bank account informations manually before.
Click on Start Over button, notice the background is empty, now close that modal

Expected Result:

If user close Start Over modal, it should stay at that screen and the background behind modal shouldn’t be blank when modal is opening.

Actual Result:

It still continues to Bank Account Manually steps after closing modal and the background of screen when opening modal is empty

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

iOS / native

Version Number: v1.2.62-1
Reproducible in staging?: y
Reproducible in production?: Could not test
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1674797028.MP4

RUWC5265.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674797406896359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b3c30fe0a5c6a556
Upwork Job ID: 1620757746894618624
Last Price Increase: 2023-02-01

@trjExpensify

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Seems super similar to this issue, which is also in the VBA flow and launching a modal: #14566

In the meantime, I can reproduce this consistently on iOS native v1.2.62-0

RPReplay_Final1675214387.MP4

@MariaHCD

I'm always a bit wary of sending anything in this flow external before a hip check, so adding the engineering label for a second pair of eyes before then.

Also, cc: @MariaHCD @nkuoch @ctkochan22 as resident experts in this domain! :)

@cristipaval

Looking into this, I think the root cause for this issue and #14566 is the same.

Because we return the WorkspaceResentBankAccountModal here, we're inadvertently hiding the Continue with setup page leading to a blank screen.

I think I can draft up the fix for this. Hope you don't mind @cristipaval!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.71-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix blank screen when showing the WorkspaceResetBankAccount modal #14726

If no regressions arise, payment will be issued on 2023-02-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue - N/A
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@rushatgabhane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rushatgabhane / @MariaHCD] The PR that introduced the bug has been identified. Link to the PR: Fix and refactor VBBA setup flow #13236 (specifically added here)
[@rushatgabhane / @MariaHCD] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix and refactor VBBA setup flow #13236 (comment)
[@rushatgabhane / @MariaHCD] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
I think the issue was it was a big refactor PR and we'd missed testing the Start over feature. Not really sure if we need another other steps here.
[@rushatgabhane] Propose regression test steps to ensure the same bug will not reach production again.
[@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@rushatgabhane

@rushatgabhane I've sent you an offer for $1k for the C+ review, @hungvu193 $250 for the bug report. Let me know when you get a sec to accept!

@rushatgabhane

[@rushatgabhane / @MariaHCD] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
I think the issue was it was a big refactor PR and we'd missed testing the Start over feature. Not really sure if we need another other steps here.

I agree with this btw. We do have Start Over in the regression test suite now, so this should be sufficient. Checking these off!

@trjExpensify

Thanks @trjExpensify , I accepted the offer

@hungvu193

📣 @hungvu193! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Alrighty, payments have been made. Thanks all!

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Navigation Menu

Repository navigation

[HOLD for payment 2023-02-22] Blank screen appears tapping `Start Over` to continue to manual step #14692

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

12 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-02-22] Blank screen appears tapping Start Over to continue to manual step #14692

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jan 31, 2023

trjExpensify commented on Feb 1, 2023

trjExpensify commented on Feb 1, 2023

trjExpensify commented on Feb 1, 2023

MariaHCD commented on Feb 1, 2023

12 remaining items

MelvinBot commented on Feb 15, 2023

MelvinBot commented on Feb 15, 2023

MelvinBot commented on Feb 15, 2023

trjExpensify commented on Feb 23, 2023

trjExpensify commented on Feb 23, 2023

hungvu193 commented on Feb 23, 2023

MelvinBot commented on Feb 23, 2023

trjExpensify commented on Feb 23, 2023

MelvinBot commented on Feb 24, 2023

MelvinBot commented on Feb 24, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[HOLD for payment 2023-02-22] Blank screen appears tapping `Start Over` to continue to manual step #14692