Skip to content

[HOLD for regression test] Bank account information is editable after reaching Personal information step #14705

New issue
New issue
Closed
Closed
[HOLD for regression test] Bank account information is editable after reaching Personal information step#14705
Assignees
michaelhaxhiuluacmartinsaimane-chnaif
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Description

@luacmartins
luacmartins
opened on Jan 31, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. On iOS or android, navigate to Settings > Workspace > Add bank account
  2. Complete the steps until you reach the Personal information step
  3. Tap < to navigate back to Company information
  4. Verify that Company name and Tax ID can be edited
  5. Tap < and then Continue with setup
  6. Verify that Routing number and Account number can be edited

Expected Result:

Company name, Tax ID, Routing number and Account number should not be editable once the user reaches the Personal information step

Actual Result:

Company name, Tax ID, Routing number and Account number are editable once the user reaches the Personal information step

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f0615bf33b37eff9
  • Upwork Job ID: 1620501620879507456
  • Last Price Increase: 2023-01-31

Activity

  1. luacmartins
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 31, 2023
  2. luacmartins
    self-assigned this
    on Jan 31, 2023
  3. melvin-bot
    locked and limited conversation to collaborators on Jan 31, 2023
  4. luacmartins
    added
    InternalRequires API changes or must be handled by Expensify staff
    on Jan 31, 2023
  5. melvin-bot
    assigned
    michaelhaxhiu
    on Jan 31, 2023
  6. melvin-bot
    unlocked this conversation on Jan 31, 2023

  7. melvin-bot commented on Jan 31, 2023

    @melvin-bot
    melvin-botBot
    on Jan 31, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  8. melvin-bot commented on Jan 31, 2023

    @melvin-bot
    melvin-botBot
    on Jan 31, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~01f0615bf33b37eff9

  9. melvin-bot
    assigned
    aimane-chnaif
    on Jan 31, 2023

  10. melvin-bot commented on Jan 31, 2023

    @melvin-bot
    melvin-botBot
    on Jan 31, 2023

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

  11. melvin-bot
    added
    ReviewingHas a PR in review
    on Jan 31, 2023

  12. luacmartins commented on Jan 31, 2023

    @luacmartins
    luacmartins
    on Jan 31, 2023
    ContributorAuthor

    PR up #14611

  13. melvin-bot
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Feb 6, 2023

  14. 22 remaining items

  15. melvin-bot
    removed
    Overdue
    on Feb 27, 2023

  16. michaelhaxhiu commented on Feb 28, 2023

    @michaelhaxhiu
    michaelhaxhiu
    on Feb 28, 2023
    Contributor

    Sorry for the delay here, got swamped with todos the past 2 weeks. Just coming up for air 🏊

  17. michaelhaxhiu commented on Feb 28, 2023

    @michaelhaxhiu
    michaelhaxhiu
    on Feb 28, 2023
    Contributor

    If no regressions arise, payment will be issued on 2023-02-13. 🎊

    This is internal and @aimane-chnaif was the C+ for review. Should be flat payment of $1000 for that.

    I just invited @aimane-chnaif to the job in Upwork. @aimane-chnaif is paid ✅

  18. michaelhaxhiu commented on Feb 28, 2023

    @michaelhaxhiu
    michaelhaxhiu
    on Feb 28, 2023
    Contributor

    [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

    Looking at this now.

  19. michaelhaxhiu commented on Feb 28, 2023

    @michaelhaxhiu
    michaelhaxhiu
    on Feb 28, 2023
    Contributor

    Next steps:

    • Requesting the buddy check on new QA steps in slack here

    • Then I'll cc @Expensify/applauseleads in the draft GH and assign applausebot

    • Close this GH

  20. michaelhaxhiu
    changed the title [-][HOLD for payment 2023-02-13] Bank account information is editable after reaching Personal information step[/-] [+][HOLD for regression test] Bank account information is editable after reaching Personal information step[/+] on Feb 28, 2023
  21. melvin-bot
    added
    Overdue
    on Mar 2, 2023

  22. luacmartins commented on Mar 2, 2023

    @luacmartins
    luacmartins
    on Mar 2, 2023
    ContributorAuthor

    Just missing the regression tests and we should be good to close this

  23. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Mar 2, 2023

  24. luacmartins commented on Mar 6, 2023

    @luacmartins
    luacmartins
    on Mar 6, 2023
    ContributorAuthor

    Just waiting for regression tests. @michaelhaxhiu I think we should be good to add the tests you posted in Slack.

  25. melvin-bot
    removed
    Overdue
    on Mar 6, 2023

  26. michaelhaxhiu commented on Mar 7, 2023

    @michaelhaxhiu
    michaelhaxhiu
    on Mar 7, 2023
    Contributor

    Ah sorry, just got sidetracked with ECX + internal GHs. Getting to this now 😓

  27. michaelhaxhiu commented on Mar 7, 2023

    @michaelhaxhiu
    michaelhaxhiu
    on Mar 7, 2023
    Contributor

    Updated checklist above ✅

    Closing.

  28. michaelhaxhiu
    closed this as completedon Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions