Skip to content

[HOLD for payment 2023-03-01] [$1000] Allow avatar image uploads: gif on Android #14751

Closed

Description

@Beamanator

Action Performed:

  1. Upload .gif as avatar image on Android

Expected Result:

It should upload and convert to .jpeg (the conversion can happen on the front end if needed, but we already have conversion code on the backend that works for every type of image in web)

Actual Result:

  1. Uploading GIF in Android throws console warning, isn't able to upload image

Note: Some investigation was done here, indicating this may be a problem with a library we use, RNImageManipulator

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012d6d474213ddb534
  • Upwork Job ID: 1621106096863707136
  • Last Price Increase: 2023-02-10

Activity

  1. self-assigned this
    on Feb 2, 2023
  2. locked and limited conversation to collaborators on Feb 2, 2023
  3. unlocked this conversation on Feb 2, 2023
  4. melvin-bot commented on Feb 2, 2023

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. locked and limited conversation to collaborators on Feb 2, 2023
  6. unlocked this conversation on Feb 2, 2023
  7. melvin-bot commented on Feb 2, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  8. locked and limited conversation to collaborators on Feb 2, 2023
  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 2, 2023
  10. 53 remaining items

  11. Beamanator commented on Feb 28, 2023

    @Beamanator
    ContributorAuthor

    @trjExpensify Ooh good points! I think it's fair to make sure all of those types work across all platforms to prevent any bugs leaking through 👍

  12. trjExpensify commented on Feb 28, 2023

    @trjExpensify
    Contributor

    Okay, so I think we add GIF, PNG and SVG to this test case under a new sub-header:

    GIF, SVG and PNG

    1. Repeat the steps to upload an avatar, but now choose a PNG file within the file size limits
    2. Verify that the avatar uploads successfully
    3. Repeat the steps to upload an avatar, but now choose an SVG file
    4. Verify that the avatar uploads successfully
    5. Repeat the steps to upload an avatar, but now choose a GIF file
    6. Verify that the avatar uploads successfully
    7. Verify that the saved avatar is a static image that only contains the first frame of the animation

    Let me know if you agree, and I'll create the GH.

  13. mananjadhav commented on Mar 1, 2023

    @mananjadhav
    Collaborator

    The test looks good.

    within the file size limits

    I don't have access to the Testrail but do we have this limit specified somewhere?


    @trjExpensify @Beamanator This is ready for payout today but I have a questions. While the review was done within the timelines (it had 2 PRs), it was merged a week later. Will the timeline bonus be affected with this?

  14. trjExpensify commented on Mar 1, 2023

    @trjExpensify
    Contributor

    I don't have access to the Testrail but do we have this limit specified somewhere?

    Ah yeah, the earlier part of this test script is about file size/limits, so here I'm not rehashing that:

    image

  15. mananjadhav commented on Mar 1, 2023

    @mananjadhav
    Collaborator

    thanks for posting the testcase.

  16. trjExpensify commented on Mar 1, 2023

    @trjExpensify
    Contributor

    @trjExpensify @Beamanator This is ready for payout today but I have a questions. While the review was done within the timelines (it had 2 PRs), it was merged a week later. Will the timeline bonus be affected with this?

    Hey @mananjadhav, the bonus won't apply on this issue because the review wasn't completed until 4 days later. I see you approved the PR on the 16th, but the checklist wasn't completed until the 17th. Those two actions should come together for a review to be deemed complete.

    I've gone ahead and settled up the contracts. I'll create the regression test issue for Applause now and close this issue out. Thanks everyone!

  17. trjExpensify commented on Mar 1, 2023

    @trjExpensify
    Contributor
  18. mananjadhav commented on Mar 1, 2023

    @mananjadhav
    Collaborator

    Thanks for confirmation @trjExpensify , but I had some questions on how we calculate timeline, so I've raised a question in the slack thread here.

  19. kbecciv commented on Apr 7, 2023

    @kbecciv

    @trjExpensify Can you please create the regression test issue or I can create one, please let me know.
    QA team is unable to update GIF file in avatar on Android, Save button is not responding.

    video_21.mp4
  20. trjExpensify commented on Apr 11, 2023

    @trjExpensify
    Contributor

    Hey @kbecciv, sorry for the slight delay, I've been OoO. The regression test issue was created a while back here, is that what you're looking for?

  21. kbecciv commented on Apr 11, 2023

    @kbecciv

    @trjExpensify Correct, steps are added in TR. QA team is having issue to update GIF file in avatar on Android device. "Save" button is not responding. Do you want me to create a separate GH issue?

  22. trjExpensify commented on Apr 11, 2023

    @trjExpensify
    Contributor

    Yep, please create a bug report for that 👍

  23. kbecciv commented on Apr 27, 2023

    @kbecciv

    @trjExpensify Logged separate issue #18088

  24. trjExpensify commented on Apr 27, 2023

    @trjExpensify
    Contributor

    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions