You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-01] [$1000] Allow avatar image uploads: gif on Android #14751
It should upload and convert to .jpeg (the conversion can happen on the front end if needed, but we already have conversion code on the backend that works for every type of image in web)
Actual Result:
Uploading GIF in Android throws console warning, isn't able to upload image
Note: Some investigation was done here, indicating this may be a problem with a library we use, RNImageManipulator
I don't have access to the Testrail but do we have this limit specified somewhere?
@trjExpensify@Beamanator This is ready for payout today but I have a questions. While the review was done within the timelines (it had 2 PRs), it was merged a week later. Will the timeline bonus be affected with this?
@trjExpensify@Beamanator This is ready for payout today but I have a questions. While the review was done within the timelines (it had 2 PRs), it was merged a week later. Will the timeline bonus be affected with this?
Hey @mananjadhav, the bonus won't apply on this issue because the review wasn't completed until 4 days later. I see you approved the PR on the 16th, but the checklist wasn't completed until the 17th. Those two actions should come together for a review to be deemed complete.
I've gone ahead and settled up the contracts. I'll create the regression test issue for Applause now and close this issue out. Thanks everyone!
@trjExpensify Can you please create the regression test issue or I can create one, please let me know.
QA team is unable to update GIF file in avatar on Android, Save button is not responding.
@trjExpensify Correct, steps are added in TR. QA team is having issue to update GIF file in avatar on Android device. "Save" button is not responding. Do you want me to create a separate GH issue?
Activity
melvin-bot commentedon Feb 2, 2023
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Feb 2, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)53 remaining items
Beamanator commentedon Feb 28, 2023
@trjExpensify Ooh good points! I think it's fair to make sure all of those types work across all platforms to prevent any bugs leaking through 👍
trjExpensify commentedon Feb 28, 2023
Okay, so I think we add GIF, PNG and SVG to this test case under a new sub-header:
GIF, SVG and PNG
Let me know if you agree, and I'll create the GH.
mananjadhav commentedon Mar 1, 2023
The test looks good.
I don't have access to the Testrail but do we have this limit specified somewhere?
@trjExpensify @Beamanator This is ready for payout today but I have a questions. While the review was done within the timelines (it had 2 PRs), it was merged a week later. Will the timeline bonus be affected with this?
trjExpensify commentedon Mar 1, 2023
Ah yeah, the earlier part of this test script is about file size/limits, so here I'm not rehashing that:
mananjadhav commentedon Mar 1, 2023
thanks for posting the testcase.
trjExpensify commentedon Mar 1, 2023
Hey @mananjadhav, the bonus won't apply on this issue because the review wasn't completed until 4 days later. I see you approved the PR on the 16th, but the checklist wasn't completed until the 17th. Those two actions should come together for a review to be deemed complete.
I've gone ahead and settled up the contracts. I'll create the regression test issue for Applause now and close this issue out. Thanks everyone!
trjExpensify commentedon Mar 1, 2023
Regression test here: https://github.com/Expensify/Expensify/issues/265438
mananjadhav commentedon Mar 1, 2023
Thanks for confirmation @trjExpensify , but I had some questions on how we calculate timeline, so I've raised a question in the slack thread here.
kbecciv commentedon Apr 7, 2023
@trjExpensify Can you please create the regression test issue or I can create one, please let me know.
QA team is unable to update GIF file in avatar on Android, Save button is not responding.
video_21.mp4
trjExpensify commentedon Apr 11, 2023
Hey @kbecciv, sorry for the slight delay, I've been OoO. The regression test issue was created a while back here, is that what you're looking for?
kbecciv commentedon Apr 11, 2023
@trjExpensify Correct, steps are added in TR. QA team is having issue to update GIF file in avatar on Android device. "Save" button is not responding. Do you want me to create a separate GH issue?
trjExpensify commentedon Apr 11, 2023
Yep, please create a bug report for that 👍
kbecciv commentedon Apr 27, 2023
@trjExpensify Logged separate issue #18088
trjExpensify commentedon Apr 27, 2023
Thanks!