You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-02-15] Show numerical keyboard on the magic code input #14795
The keypad should be numerical since the magic codes are numerical only
Actual Result:
Describe what actually happened
Normal keyboard is shown
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
User has to switch to number keyboard
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Reproducible in staging?: YES Reproducible in production?: YES If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by:@mountiny Slack conversation:
changed the title [-]Show numerical keyboard on the magic code input[/-][+][HOLD for payment 2023-02-15] Show numerical keyboard on the magic code input[/+]on Feb 8, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-02-15. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mountiny] Propose regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
mountiny commentedon Feb 6, 2023
Had issues running the App natively and that might still persist today, lets see
mountiny commentedon Feb 7, 2023
PR is up in a review.
lschurr commentedon Feb 8, 2023
This is all internal right @mountiny - no payments needed for contributors?
mountiny commentedon Feb 8, 2023
Thants correct @lschurr no payments here! Thanks for checking in
[-]Show numerical keyboard on the magic code input[/-][+][HOLD for payment 2023-02-15] Show numerical keyboard on the magic code input[/+]MelvinBot commentedon Feb 8, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Feb 8, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-02-15. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Feb 8, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
NikkiWines commentedon Feb 11, 2023
@vitHoracek can we close this out since #14901 is on prod?
mountiny commentedon Feb 11, 2023
yes