Skip to content

[HOLD for payment 2023-02-15] Show numerical keyboard on the magic code input #14795

Closed

Description

@mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. Be on the passwordless beta
  2. Log in - put in your email
  3. Get to the page requesting magic code

Expected Result:

Describe what you think should've happened

  1. The keypad should be numerical since the magic codes are numerical only

Actual Result:

Describe what actually happened

  1. Normal keyboard is shown

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

User has to switch to number keyboard

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

IMG_1697939E64A0-1

Version Number:
Reproducible in staging?: YES
Reproducible in production?: YES
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @mountiny
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01917b1ee1fc981f08
  • Upwork Job ID: 1621471765290807296
  • Last Price Increase: 2023-02-03

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 3, 2023
  2. self-assigned this
    on Feb 3, 2023
  3. locked and limited conversation to collaborators on Feb 3, 2023
  4. unlocked this conversation on Feb 6, 2023
  5. mountiny commented on Feb 6, 2023

    @mountiny
    ContributorAuthor

    Had issues running the App natively and that might still persist today, lets see

  6. mountiny commented on Feb 7, 2023

    @mountiny
    ContributorAuthor

    PR is up in a review.

  7. lschurr commented on Feb 8, 2023

    @lschurr
    Contributor

    This is all internal right @mountiny - no payments needed for contributors?

  8. mountiny commented on Feb 8, 2023

    @mountiny
    ContributorAuthor

    Thants correct @lschurr no payments here! Thanks for checking in

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 8, 2023
  10. changed the title [-]Show numerical keyboard on the magic code input[/-] [+][HOLD for payment 2023-02-15] Show numerical keyboard on the magic code input[/+] on Feb 8, 2023
  11. MelvinBot commented on Feb 8, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. MelvinBot commented on Feb 8, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-02-15. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. MelvinBot commented on Feb 8, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mountiny] The PR that introduced the bug has been identified. Link to the PR:
    • [@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mountiny] Propose regression test steps to ensure the same bug will not reach production again.
    • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. NikkiWines commented on Feb 11, 2023

    @NikkiWines
    Contributor

    @vitHoracek can we close this out since #14901 is on prod?

  15. mountiny commented on Feb 11, 2023

    @mountiny
    ContributorAuthor

    yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions