Repository navigation
App crash on entering test amount on Test transaction page #14847
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to any workspace
- Connect bank manually
- Select “Manually enter account details” and enter Routing number 011401533 and Account number 1111222233331111
- Company Info - enter random info but complete all fields. You will fail once and get asked to double check information. Select “Save & Continue” again
- Personal Info - use any test data. For last 4 SSN use 3333.
- Beneficial Owners:
- Toggle terms and conditions
- Toggle confirmation that the information provided is true and accurate
- Enter amount in test transaction page
Expected Result:
App doesn’t crash
Actual Result:
App crash with console error - amount.trim is not a function at ValidationStep.filterInput
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: v1.2.65-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Screen.Recording.2023-02-04.at.2.21.29.AM.1.mov
Recording.1448.mp4
Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675457749071149
Activity
melvin-bot commentedon Feb 6, 2023
Triggered auto assignment to @mateocole (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Feb 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon Feb 6, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:27 remaining items
[-][HOLD for payment 2023-02-14] [HOLD for payment 2023-02-13] App crash on entering test amount on Test transaction page[/-][+]App crash on entering test amount on Test transaction page[/+]robertjchen commentedon Feb 8, 2023
re: BugZero checklist
This code existed 20 months ago in #3587 so it probably wasn't the cause, the next place to look at would be
TextInput,BaseTextInput, andForm(which calls the validation) but nothing really stands out other than some recent styling changes. 🤔The base
react-nativecomponent returns a pure string, so somewhere along the line some type inference happens and we get a numeric type.Either way, we'll probably have to do some git bisects to find the cause- given the limited scope, I don't think we should sink too much time into it beyond this. We can create a dedicated issue to hunt this down if it happens again- going to close this out for now.
rushatgabhane commentedon Feb 8, 2023
@robertjchen @mateocole can you please re-open the issue for reporting bonus? Thanks
robertjchen commentedon Feb 9, 2023
Ah, my bad I forgot- re-opened!
mateocole commentedon Feb 14, 2023
here is a job to apply for https://www.upwork.com/jobs/~018c21815161da68ce
mateocole commentedon Feb 16, 2023
sry forgot to tag you @rushatgabhane
robertjchen commentedon Feb 17, 2023
Looks like this is all set!
rushatgabhane commentedon Feb 17, 2023
@robertjchen @mateocole reporting bonus is left. please reopen
mateocole commentedon Feb 17, 2023
@rushatgabhane all paid, apologies for the confusion i sent you a separate offer and withdrew it, but paid the contract in the link above!