You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-03-09] [$4000] Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search. #14889
options for adding payment method should not appear (Overlap) on search page
Actual Result:
options for adding payment method appear (Overlap) on search page
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
MacOS / Chrome / Safari
Version Number: 1.2.66-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
changed the title [-]Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/-][+][$1000] Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/+]on Feb 6, 2023
changed the title [-][$4000] Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/-][+][HOLD for payment 2023-03-09] [$4000] Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/+]on Mar 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.77-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif / @puneetlath] The PR that introduced the bug has been identified. Link to the PR: n/a
[@aimane-chnaif / @puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[@aimane-chnaif / @puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@situchan] Propose regression test steps to ensure the same bug will not reach production again.
[@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: added to general testing guidelines doc, since I think it makes more sense there than in a regression test
I don't think any PR caused regression.
This issue existed from the beginning when payment method popover is implemented here.
Modal is on top of view hierarchy and we should have handled opening another page behind modal cases when we implement this.
Activity
MelvinBot commentedon Feb 6, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Feb 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/-][+][$1000] Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/+]MelvinBot commentedon Feb 6, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0106757eb17dcdb76c
MelvinBot commentedon Feb 6, 2023
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.
MelvinBot commentedon Feb 6, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)MelvinBot commentedon Feb 6, 2023
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.
62 remaining items
MelvinBot commentedon Mar 2, 2023
@puneetlath, @aimane-chnaif, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
aimane-chnaif commentedon Mar 2, 2023
Not overdue. Waiting for PR to hit production
[-][$4000] Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/-][+][HOLD for payment 2023-03-09] [$4000] Opening search using the keyboard shortcut (ctrl+k) while options for adding payment method are visible, options overlap with search.[/+]MelvinBot commentedon Mar 2, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Mar 2, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.77-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-03-09. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Mar 2, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
puneetlath commentedon Mar 6, 2023
@situchan @Harshdeepjoshi can you please apply to the Upwork job? https://www.upwork.com/jobs/~0106757eb17dcdb76c
@aimane-chnaif can you please help with the checklist?
Thanks!
aimane-chnaif commentedon Mar 6, 2023
I don't think any PR caused regression.
This issue existed from the beginning when payment method popover is implemented here.
Modal is on top of view hierarchy and we should have handled opening another page behind modal cases when we implement this.
puneetlath commentedon Mar 9, 2023
@Harshdeepjoshi @situchan sent you hiring offers!
@aimane-chnaif paid!
puneetlath commentedon Mar 9, 2023
All paid. Thanks everyone!