Skip to content

[HOLD for payment 2023-04-04] [$1000] Compose box gets distorted when going to invalid url #15024

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any report on newDot
  2. type any invalid url after the expensify.com
  3. Click the back or cross button from the not found page

Expected Result

There should be no effect on the compose box

Actual Result

The compose box has a new line that cannot be erased with backspace/delete, it becomes normal if we enter a character

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • MacOS / Chrome / Safari

Version Number: 1.2.69-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-09.at.1.35.04.AM.mov
Recording.1490.mp4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675886973985059

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0198ba9650d230b7d3
  • Upwork Job ID: 1625208392553611264
  • Last Price Increase: 2023-02-13

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 10, 2023
  2. locked and limited conversation to collaborators on Feb 10, 2023
  3. MelvinBot commented on Feb 10, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Feb 10, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 13, 2023
  6. unlocked this conversation on Feb 13, 2023
  7. changed the title [-]Compose box gets distorted when going to invalid url[/-] [+][$1000] Compose box gets distorted when going to invalid url[/+] on Feb 13, 2023
  8. MelvinBot commented on Feb 13, 2023

    @MelvinBot
    Contributor
  9. MelvinBot commented on Feb 13, 2023

    @MelvinBot
    Contributor

    Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

  10. MelvinBot commented on Feb 13, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 13, 2023
  12. 47 remaining items

  13. garrettmknight commented on Apr 6, 2023

    @garrettmknight
    Contributor

    I think this is good for a regression test.

  14. MelvinBot commented on Apr 10, 2023

    @MelvinBot
    Contributor

    @garrettmknight, @marcochavezf, @Pujan92, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. MelvinBot commented on Apr 10, 2023

    @MelvinBot
    Contributor

    @garrettmknight, @marcochavezf, @Pujan92, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. garrettmknight commented on Apr 10, 2023

    @garrettmknight
    Contributor

    @thesahindia can you propose a regression test when you get a chance?

  17. thesahindia commented on Apr 12, 2023

    @thesahindia
    Member

    Sorry for the delay!

    Regression test proposal

    1. Navigate to an invalid route (e.g. https://new.expensify.com/a)
    2. Click on the X at the top right corner to dismiss the page
    3. Verify the composer height doesn't change
    4. Navigate to settings
    5. Click on left arrow of the browser (on the left side of the address bar)
    6. Click on the right arrow of the browser
    7. Verify the composer height doesn't change
  18. thesahindia commented on Apr 12, 2023

    @thesahindia
    Member

    was there a PR that introduced this or has it always been this way?

    It was always like this.

  19. thesahindia commented on Apr 12, 2023

    @thesahindia
    Member

    @garrettmknight, I had reported the same bug with different steps here but QA wasn't able to repro it so the issue wasn't logged. Since it was reproducible and got fixed in this issue, am I also eligible for the reporting compensation?

  20. garrettmknight commented on Apr 13, 2023

    @garrettmknight
    Contributor

    @thesahindia Since we weren't able to repro back then I don't think so.

    Had to create a new upwork job to pay out: https://www.upwork.com/ab/applicants/1646565742970630144/job-details
    @thesahindia @Pujan92 @esh-g can you accept the contracts?

  21. esh-g commented on Apr 13, 2023

    @esh-g
    Contributor

    Thanks @garrettmknight, I have accepted the contract! 😇

  22. Pujan92 commented on Apr 13, 2023

    @Pujan92
    Contributor

    Thanks @garrettmknight , accepted!

  23. thesahindia commented on Apr 13, 2023

    @thesahindia
    Member

    Accepted, thanks!

  24. garrettmknight commented on Apr 14, 2023

    @garrettmknight
    Contributor

    All paid up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions