[HOLD for payment 2023-02-28] Language in Onfido flow during bank account setup is not localized

@Prince-Mendiratta

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Log into an account that has the preferred language set to Spanish. Navigate to Workspace > Connect bank account
Click "Log into your bank"

Plaid modal - Choose Wells Fargo (use Bank of America if Wells Fargo is not available)
Plaid modal - User Id: user_good
Plaid modal - Password: pass_good
Plaid modal - Submit
Plaid modal - If they request a verification code via mobile sms, enter: credential_good when required
Choose the Saving account: Plaid Saving11122XXXXXX111
Save & Continue

Company Information (Enter the info below, and anything in non-specified fields):

Legal Business Name: Alberta Bobbeth Charleson
Company website: Enter any valid formatted website
Tax ID number: 123456789
Confirm company is not on list of restricted businesses

Requestor Information (Enter the info below, and anything in non-specified fields)

First name: Alberta
Second name: Charleson
Toggle confirmation you are authorized to use company bank account
Save & Continue (Note: You will receive an error asking to "Please verify you name and date of birth". Hit "Save & Continue" again without changing any inputs.)

Observe that the information displayed during the Onfido is still in English

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: NA
Email or phone of affected tester (no customers): NA
Logs: https://stackoverflow.com/c/expensify/questions/4856 NA
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @Prince-Mendiratta
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1676281424863799

View all open jobs on GitHub

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

https://expensify.slack.com/archives/C01GTK53T8Q/p1676281424863799

This will only be eligible for a reporting bonus since it is not really a bug so it will not entail the $1000 bug bounty.

@varshamb

I believe @varshamb was the original reporter (slack post)

Posting a proposal as per this comment. If I am allowed to contribute, well and good. If not, please feel free to apply changes internally as suggested in this proposal.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The language in Onfido Flow is not localized according to the language chosen by the user.

What is the root cause of that problem?

The root cause behind this issue is that we do not use the localisation feature in Onfido SDK.

What changes do you think we should make in order to solve the problem?

Native

On iOS and Android, the Onfido flow automatically shows the localised details according to the device language. It does not support passing the language as an argument and then changing to that specific locale. However, there is a workaround. Maybe we should make a feature request? I have some rough changes in my mind that can be used to propose and implement the feature.

iOS
A workaround for supporting and specifically changing the locale based on the locale set by the user on Expensify, this comment can be used as a guide for a workaround. This will allow us to show the Spanish language even when the device language is in English. Do note that this is only a workaround.

Android
No easy workaround possible.

Web, mWeb, Desktop

The language prop needs to be passed to OnfidoSDK with the respective locale.

@thesahindia

Thanks for the heads up, @thesahindia. We can issue the reporting bonus to both @varshamb and @Prince-Mendiratta. cc: @stephanieelliott

@Prince-Mendiratta

@Prince-Mendiratta For iOS and Android, it sounds like Onfido doesn't support localization? Or at least, it's not working?

Your proposal for web sounds good to me.

@MariaHCD

@MariaHCD Onfido does support localization for iOS and Android, however it does so based on the device language itself, instead of using a property. So if my device language is spanish, Onfido will show the details in spanish. It doesn't support setting the locale using a prop yet. Should we make a feature request for the same on the @onfido/react-native-sdk?

@Prince-Mendiratta

@Prince-Mendiratta I think we can just fix this on web, mWeb and desktop for now. Once localization is re-prioritized, we can have a discussion on what we'd like to do for native platforms.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.74-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Onfido] chosen locale specific language on Web based platforms #15179

If no regressions arise, payment will be issued on 2023-02-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@MariaHCD

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@MariaHCD] The PR that introduced the bug has been identified. Link to the PR:
[@MariaHCD] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@MariaHCD] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Prince-Mendiratta] Propose regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

This wasn't a bug (it was more of an improvement) so the BZ checklist doesn't quite apply here.

@slafortune

@slafortune I think we're good to issue the reporting bonus for 2 contributors here.

@slafortune

@slafortune Might need your help here too. I did the C+ review on this PR here. ~~I think here as well timeline bonus would apply. I think it got missed out because I am assigned to the PR but not in the issue here.~~

I just went through the thread and I am confused about C+ payment and raised a question here

Not overdue, discussion is ongoing in this Slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1677878835398299?thread_ts=1676281424.863799&cid=C01GTK53T8Q

@mananjadhav

@mananjadhav is paid - all good!

Navigation Menu

Repository navigation

[HOLD for payment 2023-02-28] Language in Onfido flow during bank account setup is not localized #15089

Action Performed:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Native

Web, mWeb, Desktop

21 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-02-28] Language in Onfido flow during bank account setup is not localized #15089

Description

Action Performed:

Platforms:

Activity

MelvinBot commented on Feb 13, 2023

MelvinBot commented on Feb 13, 2023

Bug0 Triage Checklist (Main S/O)

MariaHCD commented on Feb 13, 2023

thesahindia commented on Feb 13, 2023

Prince-Mendiratta commented on Feb 13, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Native

Web, mWeb, Desktop

MariaHCD commented on Feb 13, 2023

MariaHCD commented on Feb 13, 2023

Prince-Mendiratta commented on Feb 13, 2023

MariaHCD commented on Feb 14, 2023

21 remaining items

MelvinBot commented on Feb 21, 2023

MelvinBot commented on Feb 21, 2023

MelvinBot commented on Feb 21, 2023

MariaHCD commented on Feb 22, 2023

MariaHCD commented on Mar 2, 2023

mananjadhav commented on Mar 3, 2023

MariaHCD commented on Mar 6, 2023

slafortune commented on Mar 8, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions