Skip to content

[HOLD for payment 2023-05-23] Make it so we can run E2E performance tests on any branch #15605

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

When there's a performance regression on staging caught by the automated e2e performance tests, it's not always easy to trace that regression.

Sometimes, we want to just revert suspect PRs just to see if that works, but that gets messy quick if it we then revert the revert.

Solution

Make it so that we can run the E2E performance tests on any branch, not just when a PR is merged.

View all open jobs on GitHub

Activity

  1. self-assigned this
    on Mar 1, 2023
  2. locked and limited conversation to collaborators on Mar 1, 2023
  3. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 2, 2023
  4. changed the title [-]Make it so we can run E2E performance tests on any branch[/-] [+][HOLD for payment 2023-03-13] Make it so we can run E2E performance tests on any branch[/+] on Mar 6, 2023
  5. unlocked this conversation on Mar 6, 2023
  6. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.78-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-03-13. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  8. 27 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 16, 2023
  10. changed the title [-]Make it so we can run E2E performance tests on any branch[/-] [+][HOLD for payment 2023-05-23] Make it so we can run E2E performance tests on any branch[/+] on May 16, 2023
  11. melvin-bot commented on May 16, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on May 16, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-05-23. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. melvin-bot commented on May 29, 2023

    @melvin-bot

    @jczekalski, @roryabraham Huh... This is 4 days overdue. Who can take care of this?

  14. roryabraham commented on May 31, 2023

    @roryabraham
    ContributorAuthor

    This was completed by SWM w/o an additional bounty, so no additional payment is due here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions