You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Pressing space bar while details page is opened, scrolls up the reports #15631
After the details page has opened, press space bar
Expected Result
Nothing should happen
Actual Result
Chats are scrolled up
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.78-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Yeah this is weird behavior. Made a small tweak to the issue description (changed report to request money), looks all set to go to a contributor for a fix!
changed the title [-]Pressing space bar while details page is opened, scrolls up the reports[/-][+][$1000] Pressing space bar while details page is opened, scrolls up the reports[/+]on Mar 7, 2023
Love it when that happens! Ok, given that we had 3 PRs reviewed (2 of which were merged), I think payment is due here however the regression penalty would apply. Some quick math:
@kosmydel reports this was unknowingly fixed by #ideal-nav. I wasn't able to reproduce this anymore. I think we should close it out?
Hey, good to know that the issue doesn't occur anymore.
However, I want to confirm, if we don't want to introduce the FocusTrap anyway. It did not only meant to solve this issue, but also improved the accessibility and tab navigation on the web/desktop.
@kosmydel can you be more specific about what accessibility problem it solves?
Tab navigation is used together with e.g. VoiceOver on macOS to help people with visual disabilities.
Currently, if the e.g. RHP modals don't support focus trap, tab navigation is almost impossible (or at least cumbersome). We are "tabbing" outside the modal, which is probably not what a user expects after pressing the button that opens it. The navigation order is not correct.
Ok, I think that makes sense. @kosmydel can you create a separate issue using the standard issue template Action Performed / Expected Result / Actual Result / Workaround, and in the first comment post a proposal to fix it? Then tag me there.
Generally we aren't prioritizing accessibility too highly but given that this is already pretty much ready and we've already discovered then fixed the regressions it caused, we can talk about it.
Additionally, I believe @tienifr is eligible for partial payment since they were the ones who initially recommended utilizing the focus-trap-react library.
Activity
MelvinBot commentedon Mar 3, 2023
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 3, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MelvinBot commentedon Mar 6, 2023
@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!
MelvinBot commentedon Mar 6, 2023
@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
stephanieelliott commentedon Mar 7, 2023
Yeah this is weird behavior. Made a small tweak to the issue description (changed
reporttorequest money), looks all set to go to a contributor for a fix![-]Pressing space bar while details page is opened, scrolls up the reports[/-][+][$1000] Pressing space bar while details page is opened, scrolls up the reports[/+]MelvinBot commentedon Mar 7, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017ddd7486addffc52
221 remaining items
stephanieelliott commentedon Jan 10, 2024
PR is being actively reviewed!
stephanieelliott commentedon Jan 12, 2024
PR is reviewed, but we're going to do the QA before merging.
stephanieelliott commentedon Jan 16, 2024
Kicked off QA here
stephanieelliott commentedon Jan 25, 2024
Regression testing was completed (notes), no issues 🎉
stephanieelliott commentedon Jan 31, 2024
PR is under review
roryabraham commentedon Feb 2, 2024
@kosmydel reports this was unknowingly fixed by #ideal-nav. I wasn't able to reproduce this anymore. I think we should close it out?
JmillsExpensify commentedon Feb 2, 2024
Ha, well would you look at that!
stephanieelliott commentedon Feb 4, 2024
Love it when that happens! Ok, given that we had 3 PRs reviewed (2 of which were merged), I think payment is due here however the regression penalty would apply. Some quick math:
Original job price $1000
That would make the payout summary:
Upwork job is here: https://www.upwork.com/jobs/~0112187286e2fd23a2
stephanieelliott commentedon Feb 6, 2024
All paid!
kosmydel commentedon Feb 7, 2024
Hey, good to know that the issue doesn't occur anymore.
However, I want to confirm, if we don't want to introduce the FocusTrap anyway. It did not only meant to solve this issue, but also improved the accessibility and tab navigation on the web/desktop.
cc @luacmartins, @roryabraham
roryabraham commentedon Feb 8, 2024
@kosmydel can you be more specific about what accessibility problem it solves?
kosmydel commentedon Feb 9, 2024
Tab navigation is used together with e.g. VoiceOver on macOS to help people with visual disabilities.
Currently, if the e.g. RHP modals don't support focus trap, tab navigation is almost impossible (or at least cumbersome). We are "tabbing" outside the modal, which is probably not what a user expects after pressing the button that opens it. The navigation order is not correct.
Here is more info about navigation order.
roryabraham commentedon Feb 13, 2024
Ok, I think that makes sense. @kosmydel can you create a separate issue using the standard issue template
Action Performed/Expected Result/Actual Result/Workaround, and in the first comment post a proposal to fix it? Then tag me there.Generally we aren't prioritizing accessibility too highly but given that this is already pretty much ready and we've already discovered then fixed the regressions it caused, we can talk about it.
tienifr commentedon Feb 21, 2024
@roryabraham @stephanieelliott Sorry for coming late, I think I'm also eligible for partial compensation (suggested by @fedirjh here)