Skip to content

[$1000] Pressing space bar while details page is opened, scrolls up the reports #15631

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on an avatar in a money request
  2. After the details page has opened, press space bar

Expected Result

Nothing should happen

Actual Result

Chats are scrolled up

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-28.at.3.29.35.PM.mov
Recording.118.mp4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677578613083529

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017ddd7486addffc52
  • Upwork Job ID: 1632967018098249728
  • Last Price Increase: 2023-08-08
  • Automatic offers:
    • fedirjh | Reviewer | 26060321
    • esh-g | Reporter | 26060323

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 3, 2023
  2. MelvinBot commented on Mar 3, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Mar 3, 2023
  4. MelvinBot commented on Mar 3, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    Contributor

    @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. stephanieelliott commented on Mar 7, 2023

    @stephanieelliott
    Contributor

    Yeah this is weird behavior. Made a small tweak to the issue description (changed report to request money), looks all set to go to a contributor for a fix!

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 7, 2023
  9. unlocked this conversation on Mar 7, 2023
  10. changed the title [-]Pressing space bar while details page is opened, scrolls up the reports[/-] [+][$1000] Pressing space bar while details page is opened, scrolls up the reports[/+] on Mar 7, 2023
  11. MelvinBot commented on Mar 7, 2023

    @MelvinBot
    Contributor
  12. 221 remaining items

  13. stephanieelliott commented on Jan 10, 2024

    @stephanieelliott
    Contributor

    PR is being actively reviewed!

  14. stephanieelliott commented on Jan 12, 2024

    @stephanieelliott
    Contributor

    PR is reviewed, but we're going to do the QA before merging.

  15. stephanieelliott commented on Jan 16, 2024

    @stephanieelliott
    Contributor

    Kicked off QA here

  16. stephanieelliott commented on Jan 25, 2024

    @stephanieelliott
    Contributor

    Regression testing was completed (notes), no issues 🎉

  17. stephanieelliott commented on Jan 31, 2024

    @stephanieelliott
    Contributor

    PR is under review

  18. roryabraham commented on Feb 2, 2024

    @roryabraham
    Contributor

    @kosmydel reports this was unknowingly fixed by #ideal-nav. I wasn't able to reproduce this anymore. I think we should close it out?

  19. JmillsExpensify commented on Feb 2, 2024

    @JmillsExpensify
    Contributor

    Ha, well would you look at that!

  20. stephanieelliott commented on Feb 4, 2024

    @stephanieelliott
    Contributor

    Love it when that happens! Ok, given that we had 3 PRs reviewed (2 of which were merged), I think payment is due here however the regression penalty would apply. Some quick math:

    Original job price $1000


    That would make the payout summary:

    • Contributor: @kosmydel N/A, expert contributor
    • Contributor+: @fedirjh $250 via Upwork (offer extended, please accept)

    Upwork job is here: https://www.upwork.com/jobs/~0112187286e2fd23a2

  21. stephanieelliott commented on Feb 6, 2024

    @stephanieelliott
    Contributor

    All paid!

  22. kosmydel commented on Feb 7, 2024

    @kosmydel
    Contributor

    @kosmydel reports this was unknowingly fixed by #ideal-nav. I wasn't able to reproduce this anymore. I think we should close it out?

    Hey, good to know that the issue doesn't occur anymore.

    However, I want to confirm, if we don't want to introduce the FocusTrap anyway. It did not only meant to solve this issue, but also improved the accessibility and tab navigation on the web/desktop.

    cc @luacmartins, @roryabraham

  23. roryabraham commented on Feb 8, 2024

    @roryabraham
    Contributor

    It did not only meant to solve this issue, but also improved the accessibility and tab navigation on the web/desktop.

    @kosmydel can you be more specific about what accessibility problem it solves?

  24. kosmydel commented on Feb 9, 2024

    @kosmydel
    Contributor

    @kosmydel can you be more specific about what accessibility problem it solves?

    Tab navigation is used together with e.g. VoiceOver on macOS to help people with visual disabilities.

    Currently, if the e.g. RHP modals don't support focus trap, tab navigation is almost impossible (or at least cumbersome). We are "tabbing" outside the modal, which is probably not what a user expects after pressing the button that opens it. The navigation order is not correct.

    Here is more info about navigation order.

  25. roryabraham commented on Feb 13, 2024

    @roryabraham
    Contributor

    Ok, I think that makes sense. @kosmydel can you create a separate issue using the standard issue template Action Performed / Expected Result / Actual Result / Workaround, and in the first comment post a proposal to fix it? Then tag me there.

    Generally we aren't prioritizing accessibility too highly but given that this is already pretty much ready and we've already discovered then fixed the regressions it caused, we can talk about it.

  26. tienifr commented on Feb 21, 2024

    @tienifr
    Contributor

    @roryabraham @stephanieelliott Sorry for coming late, I think I'm also eligible for partial compensation (suggested by @fedirjh here)

    Additionally, I believe @tienifr is eligible for partial payment since they were the ones who initially recommended utilizing the focus-trap-react library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions