Skip to content

[HOLD for payment 2023-03-21] Extra comma in search placeholder text and Terms of service appears in connect bank account page #15664

New issue
New issue
Closed
Closed
[HOLD for payment 2023-03-21] Extra comma in search placeholder text and Terms of service appears in connect bank account page#15664
Assignees
puneetlatheVoloshchak
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffOverdue

Description

@kavimuru
kavimuru
opened on Mar 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open the app
  2. Open search and observe placeholder text in english
  3. Change language from settings->preferences to spanish
  4. Open search and observe placeholder text in spanish
  5. Open connect bank account
  6. Open connect manually
  7. On step 1, observe the checkbox link text

Expected Result:

Placeholder text on search should say 'Name, email or phone number' in english (without comma after email).
In step 7, Checkbox link in connect bank account step 1 should say 'Expensify Terms of Service' (with capital S)

Actual Result:

Placeholder text on search says 'Name, email, or phone number' in english (wrong grammer i.e. comma after email). Checkbox link in connect bank account step 1 says 'Expensify Terms of service'

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

3.small.issues.as.one.mp4
Recording.1629.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677927250728619

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ba1ae7334694dfc5
  • Upwork Job ID: 1632787967198875648
  • Last Price Increase: 2023-03-06

Activity

  1. kavimuru
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 5, 2023
  2. melvin-bot
    assigned
    puneetlath
    on Mar 5, 2023

  3. MelvinBot commented on Mar 5, 2023

    @MelvinBot
    MelvinBot
    on Mar 5, 2023
    Contributor

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot
    locked and limited conversation to collaborators on Mar 5, 2023

  5. MelvinBot commented on Mar 5, 2023

    @MelvinBot
    MelvinBot
    on Mar 5, 2023
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  6. puneetlath commented on Mar 6, 2023

    @puneetlath
    puneetlath
    on Mar 6, 2023
    Contributor

    I don't agree that , or is an issue. Posted in the slack thread.

    The Terms of service should definitely be Terms of Service.

  7. puneetlath
    added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 6, 2023
  8. melvin-bot
    unlocked this conversation on Mar 6, 2023

  9. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    MelvinBot
    on Mar 6, 2023
    Contributor

    Job added to Upwork: https://www.upwork.com/jobs/~01ba1ae7334694dfc5

  10. melvin-bot
    assigned
    eVoloshchak
    on Mar 6, 2023

  11. MelvinBot commented on Mar 6, 2023

    @MelvinBot
    MelvinBot
    on Mar 6, 2023
    Contributor

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

  12. melvin-bot
    added
    ReviewingHas a PR in review
    on Mar 6, 2023

  13. MelvinBot commented on Mar 13, 2023

    @MelvinBot
    MelvinBot
    on Mar 13, 2023
    Contributor

    @puneetlath, @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  14. melvin-bot
    removed
    DailyKSv2
    on Mar 14, 2023

  15. 2 remaining items

  16. melvin-bot
    changed the title [-]Extra comma in `search` placeholder text and `Terms of service` appears in `connect bank account` page[/-] [+][HOLD for payment 2023-03-21] Extra comma in `search` placeholder text and `Terms of service` appears in `connect bank account` page[/+] on Mar 14, 2023
  17. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 14, 2023

  18. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    MelvinBot
    on Mar 14, 2023
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  19. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    MelvinBot
    on Mar 14, 2023
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.83-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-03-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty

  20. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    MelvinBot
    on Mar 14, 2023
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  21. MelvinBot commented on Mar 14, 2023

    @MelvinBot
    MelvinBot
    on Mar 14, 2023 · Hidden as off-topic

  22. puneetlath commented on Mar 16, 2023

    @puneetlath
    puneetlath
    on Mar 16, 2023
    Contributor

    @dhanashree-sawant can you please apply to the job here: https://www.upwork.com/jobs/~01ba1ae7334694dfc5

  23. dhanashree-sawant commented on Mar 17, 2023

    @dhanashree-sawant
    dhanashree-sawant
    on Mar 17, 2023

    Hi @puneetlath , thanks I have applied to the job.

  24. melvin-bot
    added
    DailyKSv2
    Overdue
    and removed
    WeeklyKSv2
    on Mar 20, 2023

  25. puneetlath commented on Mar 22, 2023

    @puneetlath
    puneetlath
    on Mar 22, 2023
    Contributor

    All paid. Thanks everyone!

  26. puneetlath
    closed this as completedon Mar 22, 2023
  27. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffOverdue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions