Repository navigation
[HOLD][$1000] ‘ ’; appears in the notification for IOU #15733
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open chrome staging dot with User A
- Go to any chat with user B. Login with User B on android app.
- From user’s A account, request money to user B in a currency other than USD.
- Result: You’ll see that in the notification it’s still showing  .
Expected Result:
‘ ’; should not appear in the notification
Actual Result:
‘ ’; appears in the notification
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.80-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
html.mp4
Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678111778601099
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0177315dd58caa2700
- Upwork Job ID: 1636851567113011200
- Last Price Increase: 2023-03-17
Activity
MelvinBot commentedon Mar 7, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 7, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)strepanier03 commentedon Mar 7, 2023
I'm able to recreate this but only using a non-USD currency, so I think that's important and comes from us putting a different character aside from $ in the notification text.
It is very similar to another GH when we use foreign characters in the request money reason.
strepanier03 commentedon Mar 7, 2023
This PR looks like it was meant to fix this - #15578.
strepanier03 commentedon Mar 8, 2023
Putting this on hold and following along with #15340 and will test after merge, then either move forward or close.
[-] ‘ ’; appears in the notification for IOU[/-][+][HOLD] ‘ ’; appears in the notification for IOU[/+]strepanier03 commentedon Mar 8, 2023
#15665 - Closed a different GH for IOU requests. Will see if this is related and action.
strepanier03 commentedon Mar 10, 2023
18 remaining items
MelvinBot commentedon Mar 17, 2023
Triggered auto assignment to @arosiclair (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.aimane-chnaif commentedon Mar 20, 2023
Not overdue. Awaiting proposals...
arosiclair commentedon Mar 20, 2023
The PR you mentioned is still being worked on and looks to be addressing very similar issues. I think we should hold until those fixes are in.
[-][$1000] ‘ ’; appears in the notification for IOU[/-][+][HOLD][$1000] ‘ ’; appears in the notification for IOU[/+]strepanier03 commentedon Mar 21, 2023
Thanks @arosiclair - Will do.
strepanier03 commentedon Mar 29, 2023
PR on staging, will continue to follow.
strepanier03 commentedon Mar 29, 2023
PR is on production, testing again with a non-USD currency.
strepanier03 commentedon Mar 29, 2023
Looks like it's no longer a problem 🙌
I tested with a couple different currencies to be sure.
ANG currency:
GNF, NOK, and ZAR currencies:
strepanier03 commentedon Mar 29, 2023
I am going to close this one out now.