Skip to content

[HOLD for payment 2023-06-01] [HOLD PR#16052][$4000] Tooltip doesn't disappear while page is scrolling #15757

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login with any account.
  2. Go to any report that has a lots of request, click on one of those request to open Detail Page.
  3. Try to hover the user name to see the tooltip, after that scroll the page.
  4. Notice that tooltip doesn't disappear while page is scrolling.

Expected Result:

Tooltip should disappear while page is scrolling.

Actual Result:

Tooltip doesn't disappear while page is scrolling.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.80-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1657.mp4
Screen.Recording.2023-03-09.at.00.32.07.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678296752620849

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019546d7509b0c8a21
  • Upwork Job ID: 1636029730419101696
  • Last Price Increase: 2023-03-30

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 8, 2023
  2. locked and limited conversation to collaborators on Mar 8, 2023
  3. MelvinBot commented on Mar 8, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Mar 8, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. isabelastisser commented on Mar 9, 2023

    @isabelastisser
    Contributor

    Hey @kavimuru, @hungvu193 did you copy the email? From your recording, I'm unsure if you did it, but it looks like it was the case. Please provide more context and I will continue to review this. Thanks!

  6. isabelastisser commented on Mar 13, 2023

    @isabelastisser
    Contributor

    @kavimuru @hungvu193 please follow up on my question above, thanks! I'm unable to reproduce it.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 15, 2023
  8. unlocked this conversation on Mar 15, 2023
  9. changed the title [-]Tooltip doesn't disappear while page is scrolling[/-] [+][$1000] Tooltip doesn't disappear while page is scrolling[/+] on Mar 15, 2023
  10. MelvinBot commented on Mar 15, 2023

    @MelvinBot
    Contributor
  11. MelvinBot commented on Mar 15, 2023

    @MelvinBot
    Contributor

    Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

  12. 118 remaining items

  13. melvin-bot commented on May 25, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 25, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-01. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on May 25, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
    • [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@0xmiroslav] Determine if we should create a regression test for this bug.
    • [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. isabelastisser commented on Jun 1, 2023

    @isabelastisser
    Contributor

    @yuwenmemon @0xmiroslav I see the awaiting payment label, but reading through this long issue, I can't confirm that we picked a proposal. Can you please guide me on the next steps here? Thanks!

  17. 0xmiroslav commented on Jun 1, 2023

    @0xmiroslav
    Contributor

    @isabelastisser The PR which fixes #15229 also fixed this one. As no one assigned here, we can just close.
    Just one thing:
    May I request partial compensation as I reviewed initial proposals (as you see long comments history) as per C+ doc?

  18. isabelastisser commented on Jun 1, 2023

    @isabelastisser
    Contributor

    Hi @0xmiroslav, thanks for clarifying! I've sent you an offer in Upwork, please accept it, and I will process a partial payment for your review to multiple proposals. Thanks!

    We're all set!

  19. 0xmiroslav commented on Jun 1, 2023

    @0xmiroslav
    Contributor

    @isabelastisser accepted, thanks!

  20. jakub-trzebiatowski commented on Jun 2, 2023

    @jakub-trzebiatowski
    Contributor

    @yuwenmemon @flodnv @0xmiroslav

    I'd like to ask for clarification of the process for handling PRs that solve more than one issue, as they don't happen often. In my case, I've proposed a solution that deals with two different issues (check my proposal here). I made sure to create a solution that intentionally addresses both issues.

    Per the guidelines, I linked both issues in the PR, and this was acknowledged by @flodnv. The automatic system also recognized this.

    I believe that offering a single bounty for a PR that explicitly solves multiple issues could encourage contributors to focus on localized separate solutions instead of more comprehensive ones. This might not be the best approach for the project from a broader perspective.

  21. 0xmiroslav commented on Jun 2, 2023

    @0xmiroslav
    Contributor

    @cubuspl42 there's no guideline about that. If you claim more bounty in such cases, please raise discussion on slack. This closed issue seems not a good place to have such discussions.

  22. jakub-trzebiatowski commented on Jun 2, 2023

    @jakub-trzebiatowski
    Contributor

    @0xmiroslav I can't see why this is a bad place for this clarification, as if there's no guideline, there's no obvious reason to close the [HOLD for payment] issue without a payment or a clarification of the process. Still, I'll respect your request and will post this on Slack.

  23. getusha commented on Jun 2, 2023

    @getusha
    Contributor

    @cubuspl42 as far as i know payment will be issued for the issue that you proposed a solution for, i have seen multiple instances.

  24. flodnv commented on Jun 2, 2023

    @flodnv
    Contributor

    Discussed here https://expensify.slack.com/archives/C01GTK53T8Q/p1685711548218919

    @isabelastisser please issue $4000 payment to @cubuspl42 for fixing this bug, if it hasn't yet been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions