You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-01] [HOLD PR#16052][$4000] Tooltip doesn't disappear while page is scrolling #15757
Go to any report that has a lots of request, click on one of those request to open Detail Page.
Try to hover the user name to see the tooltip, after that scroll the page.
Notice that tooltip doesn't disappear while page is scrolling.
Expected Result:
Tooltip should disappear while page is scrolling.
Actual Result:
Tooltip doesn't disappear while page is scrolling.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.80-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Hey @kavimuru, @hungvu193 did you copy the email? From your recording, I'm unsure if you did it, but it looks like it was the case. Please provide more context and I will continue to review this. Thanks!
changed the title [-]Tooltip doesn't disappear while page is scrolling[/-][+][$1000] Tooltip doesn't disappear while page is scrolling[/+]on Mar 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-01. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@yuwenmemon@0xmiroslav I see the awaiting payment label, but reading through this long issue, I can't confirm that we picked a proposal. Can you please guide me on the next steps here? Thanks!
@isabelastisser The PR which fixes #15229 also fixed this one. As no one assigned here, we can just close.
Just one thing:
May I request partial compensation as I reviewed initial proposals (as you see long comments history) as per C+ doc?
Hi @0xmiroslav, thanks for clarifying! I've sent you an offer in Upwork, please accept it, and I will process a partial payment for your review to multiple proposals. Thanks!
I'd like to ask for clarification of the process for handling PRs that solve more than one issue, as they don't happen often. In my case, I've proposed a solution that deals with two different issues (check my proposal here). I made sure to create a solution that intentionally addresses both issues.
I believe that offering a single bounty for a PR that explicitly solves multiple issues could encourage contributors to focus on localized separate solutions instead of more comprehensive ones. This might not be the best approach for the project from a broader perspective.
@cubuspl42 there's no guideline about that. If you claim more bounty in such cases, please raise discussion on slack. This closed issue seems not a good place to have such discussions.
@0xmiroslav I can't see why this is a bad place for this clarification, as if there's no guideline, there's no obvious reason to close the [HOLD for payment] issue without a payment or a clarification of the process. Still, I'll respect your request and will post this on Slack.
Activity
MelvinBot commentedon Mar 8, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 8, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)isabelastisser commentedon Mar 9, 2023
Hey @kavimuru, @hungvu193 did you copy the email? From your recording, I'm unsure if you did it, but it looks like it was the case. Please provide more context and I will continue to review this. Thanks!
isabelastisser commentedon Mar 13, 2023
@kavimuru @hungvu193 please follow up on my question above, thanks! I'm unable to reproduce it.
[-]Tooltip doesn't disappear while page is scrolling[/-][+][$1000] Tooltip doesn't disappear while page is scrolling[/+]MelvinBot commentedon Mar 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~019546d7509b0c8a21
MelvinBot commentedon Mar 15, 2023
Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.
118 remaining items
melvin-bot commentedon May 25, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-01. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 25, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
isabelastisser commentedon Jun 1, 2023
@yuwenmemon @0xmiroslav I see the
awaiting paymentlabel, but reading through this long issue, I can't confirm that we picked a proposal. Can you please guide me on the next steps here? Thanks!0xmiroslav commentedon Jun 1, 2023
@isabelastisser The PR which fixes #15229 also fixed this one. As no one assigned here, we can just close.
Just one thing:
May I request partial compensation as I reviewed initial proposals (as you see long comments history) as per C+ doc?
isabelastisser commentedon Jun 1, 2023
Hi @0xmiroslav, thanks for clarifying! I've sent you an offer in Upwork, please accept it, and I will process a partial payment for your review to multiple proposals. Thanks!
We're all set!
0xmiroslav commentedon Jun 1, 2023
@isabelastisser accepted, thanks!
jakub-trzebiatowski commentedon Jun 2, 2023
@yuwenmemon @flodnv @0xmiroslav
I'd like to ask for clarification of the process for handling PRs that solve more than one issue, as they don't happen often. In my case, I've proposed a solution that deals with two different issues (check my proposal here). I made sure to create a solution that intentionally addresses both issues.
Per the guidelines, I linked both issues in the PR, and this was acknowledged by @flodnv. The automatic system also recognized this.
I believe that offering a single bounty for a PR that explicitly solves multiple issues could encourage contributors to focus on localized separate solutions instead of more comprehensive ones. This might not be the best approach for the project from a broader perspective.
0xmiroslav commentedon Jun 2, 2023
@cubuspl42 there's no guideline about that. If you claim more bounty in such cases, please raise discussion on slack. This closed issue seems not a good place to have such discussions.
jakub-trzebiatowski commentedon Jun 2, 2023
@0xmiroslav I can't see why this is a bad place for this clarification, as if there's no guideline, there's no obvious reason to close the
[HOLD for payment]issue without a payment or a clarification of the process. Still, I'll respect your request and will post this on Slack.getusha commentedon Jun 2, 2023
@cubuspl42 as far as i know payment will be issued for the issue that you proposed a solution for, i have seen multiple instances.
flodnv commentedon Jun 2, 2023
Discussed here https://expensify.slack.com/archives/C01GTK53T8Q/p1685711548218919
@isabelastisser please issue $4000 payment to @cubuspl42 for fixing this bug, if it hasn't yet been done.