Skip to content

[HOLD for payment 2023-04-12] [$1000] Web -If even the tone of the emoji is dark, the emoji that sent via emoji code is in light tone #15805

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to any chat
  4. Send and emoji via emoji code, for example :+1: 0 making sure you type out the full code (e.g. I type :facepalm: + Enter, it uses the default yellow emoji color). But if you type :face + Enter to auto-complete, it uses the correct skin tone from my profile.
  5. Pay attention to the tone of the emoji sent via the code and the tone of the account emoji

Expected Result:

The tone of the emoji sent via the code is identical to the account's emoji code

Actual Result:

The emojis I send via emoji code are always in light tone regardless of the emoji tone

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.81.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5970815_Recording__3870__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017e0cd67725884fcc
  • Upwork Job ID: 1640688255744696320
  • Last Price Increase: 2023-03-28

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 9, 2023
  2. locked and limited conversation to collaborators on Mar 9, 2023
  3. MelvinBot commented on Mar 9, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Mar 9, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. sophiepintoraetz commented on Mar 10, 2023

    @sophiepintoraetz
    Contributor

    @kbecciv - I'm not able to reproduce this on the Chrome (v1.2.81-1)?
    2023-03-10_15-45-31 (1)

  6. sophiepintoraetz commented on Mar 13, 2023

    @sophiepintoraetz
    Contributor

    Closing - waiting for confirmation.

  7. kavimuru commented on Mar 16, 2023

    @kavimuru

    @sophiepintoraetz Adding from emoji picker works fine. After changing skin color, if you type :+1: it appears in default color. Is this expected behavior?

  8. unlocked this conversation on Mar 21, 2023
  9. Pujan92 commented on Mar 22, 2023

    @Pujan92
    Contributor

    @sophiepintoraetz When we type the emoji code manually it is not considering the preferred skintone. Isn't it a bug?

  10. sakluger commented on Mar 25, 2023

    @sakluger
    Contributor

    @sophiepintoraetz I was able to reproduce this behavior. The issue occurs when you type out the emoji completely including the final :. So if I type :facepalm: + Enter, it uses the default yellow emoji color. But if I type :face + Enter to auto-complete, it uses the correct skin tone from my profile.

  11. 32 remaining items

  12. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.94-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-04-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@s77rt / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
    • [@s77rt / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@s77rt / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sophiepintoraetz] Determine if we should create a regression test for this bug.
    • [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. s77rt commented on Apr 5, 2023

    @s77rt
    Member
    • The PR that introduced the bug has been identified: None. Not a regression. This is a missing feature (from Render Emoji when typed with emoji code #10165)
    • The offending PR has been commented on: n/a
    • A discussion in #expensify-bugs has been started: I think this does not apply here (cc @mountiny)

    Regression Test Proposal

    1. Open App
    2. Go to any chat
    3. Send :+1:
    4. Verify the sent emoji has the correct skin tone
    5. Change emojis's skin tone
    6. Send :+1:
    7. Verify the sent emoji has the correct updated skin tone
  15. mountiny commented on Apr 5, 2023

    @mountiny
    Contributor

    Thank you @s77rt agreed

    @sophiepintoraetz lets add taht regression test thank you very much for help!

  16. sophiepintoraetz commented on Apr 12, 2023

    @sophiepintoraetz
    Contributor

    All right, payment date is coming up so as I understand it (@mountiny and @s77rt please confirm):

    • No reporting bonus as Applause reported this
    • $1000 to @perunt (PR submitted on 28 Mar and merged on 4 Apr - not eligible for bonus)
    • $1000 to @s77rt (PR submitted on 28 Mar and merged on 4 Apr- not eligible for bonus)

    Regression test here

  17. mountiny commented on Apr 12, 2023

    @mountiny
    Contributor

    I think that sounds good to me, but @perunt is not being paid through Upwork

  18. sophiepintoraetz commented on Apr 13, 2023

    @sophiepintoraetz
    Contributor

    @mountiny so how do we pay @perunt ?

  19. mountiny commented on Apr 13, 2023

    @mountiny
    Contributor

    @sophiepintoraetz Taras is from Margelo which is expert group which works with us, they invoice us for their work serparately, sorry for not clarifying this before

  20. sophiepintoraetz commented on Apr 14, 2023

    @sophiepintoraetz
    Contributor

    Thank you - got it. Offer sent to @s77rt - I guess we'll leave it for Taras to invoice us accordingly through Margelo! Closing (reopen if I have this wrong).

  21. s77rt commented on Apr 14, 2023

    @s77rt
    Member

    @sophiepintoraetz I think we usually close issues after payment and not during. But this should not take long anyway. I have accepted the offer. Thanks!

  22. sophiepintoraetz commented on Apr 14, 2023

    @sophiepintoraetz
    Contributor

    I think given that all actions are complete (i.e. offer is sent) and I get email notifications when you accept (and you can always follow up on the GH) - closing the issue slightly early doesn't matter @s77rt

    In any case, contract is paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions