You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-12] [$1000] Web -If even the tone of the emoji is dark, the emoji that sent via emoji code is in light tone #15805
Send and emoji via emoji code, for example :+1: 0 making sure you type out the full code (e.g. I type :facepalm: + Enter, it uses the default yellow emoji color). But if you type :face + Enter to auto-complete, it uses the correct skin tone from my profile.
Pay attention to the tone of the emoji sent via the code and the tone of the account emoji
Expected Result:
The tone of the emoji sent via the code is identical to the account's emoji code
Actual Result:
The emojis I send via emoji code are always in light tone regardless of the emoji tone
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.81.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
@sophiepintoraetz Adding from emoji picker works fine. After changing skin color, if you type :+1: it appears in default color. Is this expected behavior?
@sophiepintoraetz I was able to reproduce this behavior. The issue occurs when you type out the emoji completely including the final :. So if I type :facepalm: + Enter, it uses the default yellow emoji color. But if I type :face + Enter to auto-complete, it uses the correct skin tone from my profile.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.94-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sophiepintoraetz] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@sophiepintoraetz Taras is from Margelo which is expert group which works with us, they invoice us for their work serparately, sorry for not clarifying this before
Thank you - got it. Offer sent to @s77rt - I guess we'll leave it for Taras to invoice us accordingly through Margelo! Closing (reopen if I have this wrong).
@sophiepintoraetz I think we usually close issues after payment and not during. But this should not take long anyway. I have accepted the offer. Thanks!
I think given that all actions are complete (i.e. offer is sent) and I get email notifications when you accept (and you can always follow up on the GH) - closing the issue slightly early doesn't matter @s77rt
Activity
MelvinBot commentedon Mar 9, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sophiepintoraetz commentedon Mar 10, 2023
@kbecciv - I'm not able to reproduce this on the Chrome (v1.2.81-1)?

sophiepintoraetz commentedon Mar 13, 2023
Closing - waiting for confirmation.
kavimuru commentedon Mar 16, 2023
@sophiepintoraetz Adding from emoji picker works fine. After changing skin color, if you type
:+1:it appears in default color. Is this expected behavior?Pujan92 commentedon Mar 22, 2023
@sophiepintoraetz When we type the emoji code manually it is not considering the preferred skintone. Isn't it a bug?
sakluger commentedon Mar 25, 2023
@sophiepintoraetz I was able to reproduce this behavior. The issue occurs when you type out the emoji completely including the final
:. So if I type:facepalm: + Enter, it uses the default yellow emoji color. But if I type:face + Enterto auto-complete, it uses the correct skin tone from my profile.32 remaining items
MelvinBot commentedon Apr 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.94-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Apr 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Apr 5, 2023
Regression Test Proposal
:+1::+1:mountiny commentedon Apr 5, 2023
Thank you @s77rt agreed
@sophiepintoraetz lets add taht regression test thank you very much for help!
sophiepintoraetz commentedon Apr 12, 2023
All right, payment date is coming up so as I understand it (@mountiny and @s77rt please confirm):
Regression test here
mountiny commentedon Apr 12, 2023
I think that sounds good to me, but @perunt is not being paid through Upwork
sophiepintoraetz commentedon Apr 13, 2023
@mountiny so how do we pay @perunt ?
mountiny commentedon Apr 13, 2023
@sophiepintoraetz Taras is from Margelo which is expert group which works with us, they invoice us for their work serparately, sorry for not clarifying this before
sophiepintoraetz commentedon Apr 14, 2023
Thank you - got it. Offer sent to @s77rt - I guess we'll leave it for Taras to invoice us accordingly through Margelo! Closing (reopen if I have this wrong).
s77rt commentedon Apr 14, 2023
@sophiepintoraetz I think we usually close issues after payment and not during. But this should not take long anyway. I have accepted the offer. Thanks!
sophiepintoraetz commentedon Apr 14, 2023
I think given that all actions are complete (i.e. offer is sent) and I get email notifications when you accept (and you can always follow up on the GH) - closing the issue slightly early doesn't matter @s77rt
In any case, contract is paid!