You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-07] [$1000] Workspace - Default currency field doesn't look good if the field is disabled #15877
changed the title [-]Workspace - Default currency field doesn't look good if the field is disabled[/-][+][$1000] Workspace - Default currency field doesn't look good if the field is disabled[/+]on Mar 15, 2023
@rushatgabhane and @JmillsExpensify Can this regress now, it's a feature. I suppose we could ensure that the currency field can't be edited once a VBA is added, and it would be fairly easy to add.
Activity
MelvinBot commentedon Mar 11, 2023
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)twisterdotcom commentedon Mar 12, 2023
@kbecciv what do you mean by "looks good" here?
kbecciv commentedon Mar 13, 2023
@twisterdotcom User should not seen greenish color under Default currency field, or it should completely cover the surface without gap.
twisterdotcom commentedon Mar 15, 2023
Okay here it is. It can only be disabled when the workspace as a VBA added:
Not sure what @Expensify/design would prefer here. Making
External[-]Workspace - Default currency field doesn't look good if the field is disabled[/-][+][$1000] Workspace - Default currency field doesn't look good if the field is disabled[/+]MelvinBot commentedon Mar 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0113fa5fec5ef1c2ae
58 remaining items
rushatgabhane commentedon Apr 11, 2023
@cristipaval this is a feature request to add a disabled style and a hint to
Pickercomponent.I believe BZ checklist isn't applicable here.
cristipaval commentedon Apr 11, 2023
Thanks for checking @rushatgabhane ! We're good then.
MelvinBot commentedon Apr 17, 2023
@JmillsExpensify, @twisterdotcom, @cristipaval, @rushatgabhane, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...
cristipaval commentedon Apr 17, 2023
I think this is on you, @twisterdotcom. Payments are the only leftovers.
twisterdotcom commentedon Apr 17, 2023
Sent invites for payment to you @rushatgabhane and @allroundexperts.
twisterdotcom commentedon Apr 17, 2023
@rushatgabhane and @JmillsExpensify Can this regress now, it's a feature. I suppose we could ensure that the currency field can't be edited once a VBA is added, and it would be fairly easy to add.
JmillsExpensify commentedon Apr 17, 2023
I thought we agreed for these small cosmetic things that we wouldn't create a regression?
rushatgabhane commentedon Apr 17, 2023
im pretty sure we already have a regression test for this.
because i have seen issues that were created whenever it broke.
@kbecciv maybe can confirm if there's a regression test for "currency field shouldn't be editable if a workspace has VBA linked"
JmillsExpensify commentedon Apr 17, 2023
I'll check quickly and see if I can find it.
JmillsExpensify commentedon Apr 17, 2023
I didn't see it in the Workspace folder of tests, so we'll wait for Applause to confirm.
rushatgabhane commentedon Apr 17, 2023
Okay then we should definitely add regression steps
how about?
twisterdotcom commentedon Apr 19, 2023
Nice, cool. https://github.com/Expensify/Expensify/issues/277004