Skip to content

[HOLD for payment 2023-04-07] [$1000] Workspace - Default currency field doesn't look good if the field is disabled #15877

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with expensifail account which has Control policy ( you can use appluasetester+0901abb@applause.expensifail.com)
  3. Go to Settings - Workspace - Tap on Avatar
  4. Check Workspace Settings

Expected Result:

Default currency field looks good if the field is disabled.

Actual Result:

Default currency field doesn't look good if the field is disabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.82.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0113fa5fec5ef1c2ae
  • Upwork Job ID: 1635970689731641344
  • Last Price Increase: 2023-03-22

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2023
  2. locked and limited conversation to collaborators on Mar 11, 2023
  3. MelvinBot commented on Mar 11, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Mar 11, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. twisterdotcom commented on Mar 12, 2023

    @twisterdotcom
    Contributor

    @kbecciv what do you mean by "looks good" here?

  6. kbecciv commented on Mar 13, 2023

    @kbecciv
    Author

    @twisterdotcom User should not seen greenish color under Default currency field, or it should completely cover the surface without gap.

    image

  7. twisterdotcom commented on Mar 15, 2023

    @twisterdotcom
    Contributor

    Okay here it is. It can only be disabled when the workspace as a VBA added:

    2023-03-15_07-44-38 (1)

    Not sure what @Expensify/design would prefer here. Making External

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 15, 2023
  9. unlocked this conversation on Mar 15, 2023
  10. changed the title [-]Workspace - Default currency field doesn't look good if the field is disabled[/-] [+][$1000] Workspace - Default currency field doesn't look good if the field is disabled[/+] on Mar 15, 2023
  11. MelvinBot commented on Mar 15, 2023

    @MelvinBot
    Contributor
  12. 58 remaining items

  13. rushatgabhane commented on Apr 11, 2023

    @rushatgabhane
    Member

    @cristipaval this is a feature request to add a disabled style and a hint to Picker component.

    I believe BZ checklist isn't applicable here.

  14. cristipaval commented on Apr 11, 2023

    @cristipaval
    Contributor

    Thanks for checking @rushatgabhane ! We're good then.

  15. MelvinBot commented on Apr 17, 2023

    @MelvinBot
    Contributor

    @JmillsExpensify, @twisterdotcom, @cristipaval, @rushatgabhane, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

  16. cristipaval commented on Apr 17, 2023

    @cristipaval
    Contributor

    I think this is on you, @twisterdotcom. Payments are the only leftovers.

  17. twisterdotcom commented on Apr 17, 2023

    @twisterdotcom
    Contributor

    Sent invites for payment to you @rushatgabhane and @allroundexperts.

  18. twisterdotcom commented on Apr 17, 2023

    @twisterdotcom
    Contributor

    @rushatgabhane and @JmillsExpensify Can this regress now, it's a feature. I suppose we could ensure that the currency field can't be edited once a VBA is added, and it would be fairly easy to add.

  19. JmillsExpensify commented on Apr 17, 2023

    @JmillsExpensify
    Contributor

    I thought we agreed for these small cosmetic things that we wouldn't create a regression?

  20. rushatgabhane commented on Apr 17, 2023

    @rushatgabhane
    Member

    I suppose we could ensure that the currency field can't be edited once a VBA is added, and it would be fairly easy to add.

    im pretty sure we already have a regression test for this.
    because i have seen issues that were created whenever it broke.

    @kbecciv maybe can confirm if there's a regression test for "currency field shouldn't be editable if a workspace has VBA linked"

  21. JmillsExpensify commented on Apr 17, 2023

    @JmillsExpensify
    Contributor

    I'll check quickly and see if I can find it.

  22. JmillsExpensify commented on Apr 17, 2023

    @JmillsExpensify
    Contributor

    I didn't see it in the Workspace folder of tests, so we'll wait for Applause to confirm.

  23. rushatgabhane commented on Apr 17, 2023

    @rushatgabhane
    Member

    Okay then we should definitely add regression steps
    how about?

    1. Login
    2. Create a new workplace (if you don't have one already)
    3. Connect a bank account to the workspace (if you don't have one already)
    4. Go to Workspace Settings
    5. Verify that the default currency can't be edited
  24. twisterdotcom commented on Apr 19, 2023

    @twisterdotcom
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorWaiting for copyUser facing verbiage needs polishing

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions