Skip to content

[HOLD for payment 2023-04-27] [$1000] The attachment viewer loads every image again when switching with arrows #15922

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open any report with more than one image sent
  2. Click on any one image
  3. Click on an arrow to switch image

Expected Result

The spinner should only display once when the image loads, after that, the image should not need to show the spinner and be shown instantly

Actual Result

The spinner is shown on every image when switching and images are loaded again every time.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.83-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

test.mov
Recording.1689.mp4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1678613459293019
View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0136002576e7090b5b
  • Upwork Job ID: 1636029895829024768
  • Last Price Increase: 2023-03-15

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 13, 2023
  2. MelvinBot commented on Mar 13, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. locked and limited conversation to collaborators on Mar 13, 2023
  4. MelvinBot commented on Mar 13, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 15, 2023
  6. unlocked this conversation on Mar 15, 2023
  7. changed the title [-]The attachment viewer loads every image again when switching with arrows[/-] [+][$1000] The attachment viewer loads every image again when switching with arrows[/+] on Mar 15, 2023
  8. MelvinBot commented on Mar 15, 2023

    @MelvinBot
    Contributor
  9. MelvinBot commented on Mar 15, 2023

    @MelvinBot
    Contributor

    Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

  10. MelvinBot commented on Mar 15, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 15, 2023
  12. 62 remaining items

  13. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
    • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@isabelastisser] Determine if we should create a regression test for this bug.
    • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. situchan commented on Apr 23, 2023

    @situchan
    Contributor

    There seems regression from PR which fixes this issue

  15. trjExpensify commented on Apr 27, 2023

    @trjExpensify
    Contributor

    @situchan can you clarify what you mean. Are you saying the PR for this issue caused a regression?

  16. situchan commented on Apr 28, 2023

    @situchan
    Contributor

    @situchan can you clarify what you mean. Are you saying the PR for this issue caused a regression?

    yes

  17. isabelastisser commented on Apr 28, 2023

    @isabelastisser
    Contributor

    To confirm:

    @kidroca: approved proposal
    @thesahindia - C+ review
    @esh-g - reported the issue

    • Contributor assigned on March 29.
    • PR merged on April 19.
    • Deployed to production on April 20.

    The issue amount is $1000, but does it mean that the payment processed will be $500 because: Merged PR more than 9 business days after assignment - 50% penalty

    @johnmlee101, I got the info above here, is this correct?

  18. isabelastisser commented on May 1, 2023

    @isabelastisser
    Contributor

    Not overdue, still discussing this with @johnmlee101 !

  19. johnmlee101 commented on May 1, 2023

    @johnmlee101
    Contributor

    @isabelastisser This was a fairly complex issue that had a lot of edge cases that were being tested, so I think the 50% penalty might not apply in this case. I'd be fine keeping it as the original $1000 for this.

  20. isabelastisser commented on May 2, 2023

    @isabelastisser
    Contributor

    Update: Payments made in Upwork and contracts ended.

    @thesahindia, please complete your tasks on the BugZero Checklist:, and I will review and complete mine so we can close the issue. Thanks!

  21. thesahindia commented on May 3, 2023

    @thesahindia
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:

    #9279

    • [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #9279 (comment)

    • [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    Will do it soon

    • [@isabelastisser] Determine if we should create a regression test for this bug.

    Let's add tests

    • [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Test steps -

    1. Go to a chat
    2. Send multiple attachments
    3. Open an attachment
    4. Navigate between attachments using the left and right
    5. Verify If we wait for a second before pressing "Next Arrow" - the attachment is preloaded when you navigate to it
    6. Verify going back to a previous attachment is instant
    7. Verify that on mobile devices you can navigate between attachments by swiping left/right
  22. isabelastisser commented on May 4, 2023

    @isabelastisser
    Contributor

    QA issue here.

    All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions