You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-27] [$1000] The attachment viewer loads every image again when switching with arrows #15922
The spinner should only display once when the image loads, after that, the image should not need to show the spinner and be shown instantly
Actual Result
The spinner is shown on every image when switching and images are loaded again every time.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.83-1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
changed the title [-]The attachment viewer loads every image again when switching with arrows[/-][+][$1000] The attachment viewer loads every image again when switching with arrows[/+]on Mar 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@isabelastisser] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The issue amount is $1000, but does it mean that the payment processed will be $500 because: Merged PR more than 9 business days after assignment - 50% penalty
@isabelastisser This was a fairly complex issue that had a lot of edge cases that were being tested, so I think the 50% penalty might not apply in this case. I'd be fine keeping it as the original $1000 for this.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Will do it soon
[@isabelastisser] Determine if we should create a regression test for this bug.
Let's add tests
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Test steps -
Go to a chat
Send multiple attachments
Open an attachment
Navigate between attachments using the left and right
Verify If we wait for a second before pressing "Next Arrow" - the attachment is preloaded when you navigate to it
Verify going back to a previous attachment is instant
Verify that on mobile devices you can navigate between attachments by swiping left/right
Activity
MelvinBot commentedon Mar 13, 2023
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 13, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]The attachment viewer loads every image again when switching with arrows[/-][+][$1000] The attachment viewer loads every image again when switching with arrows[/+]MelvinBot commentedon Mar 15, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0136002576e7090b5b
MelvinBot commentedon Mar 15, 2023
Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.
MelvinBot commentedon Mar 15, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)62 remaining items
MelvinBot commentedon Apr 20, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
situchan commentedon Apr 23, 2023
There seems regression from PR which fixes this issue
trjExpensify commentedon Apr 27, 2023
@situchan can you clarify what you mean. Are you saying the PR for this issue caused a regression?
situchan commentedon Apr 28, 2023
yes
isabelastisser commentedon Apr 28, 2023
To confirm:
@kidroca: approved proposal
@thesahindia - C+ review
@esh-g - reported the issue
The issue amount is $1000, but does it mean that the payment processed will be $500 because:
Merged PR more than 9 business days after assignment - 50% penalty@johnmlee101, I got the info above here, is this correct?
isabelastisser commentedon May 1, 2023
Not overdue, still discussing this with @johnmlee101 !
johnmlee101 commentedon May 1, 2023
@isabelastisser This was a fairly complex issue that had a lot of edge cases that were being tested, so I think the 50% penalty might not apply in this case. I'd be fine keeping it as the original $1000 for this.
isabelastisser commentedon May 2, 2023
Update: Payments made in Upwork and contracts ended.
@thesahindia, please complete your tasks on the
BugZero Checklist:, and I will review and complete mine so we can close the issue. Thanks!thesahindia commentedon May 3, 2023
#9279
#9279 (comment)
Will do it soon
Let's add tests
Test steps -
isabelastisser commentedon May 4, 2023
QA issue here.
All set!