Skip to content

[HOLD][$250] Migrate ArrowKeyFocusManager.js to function component #16110

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate ArrowKeyFocusManager.js to function component[/-] [+][HOLD][$250] Migrate ArrowKeyFocusManager.js to function component[/+] on Apr 13, 2023
  4. kuluruvineeth commented on Apr 29, 2023

    @kuluruvineeth
  5. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor

    Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor

    Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  7. MelvinBot commented on May 4, 2023

    @MelvinBot
    Contributor

    Eep! 4 days overdue now. Issues have feelings too...

  8. melvin-bot commented on May 8, 2023

    @melvin-bot

    Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  9. melvin-bot commented on May 10, 2023

    @melvin-bot

    10 days overdue. Is anyone even seeing these? Hello?

  10. melvin-bot commented on May 12, 2023

    @melvin-bot

    12 days overdue now... This issue's end is nigh!

  11. szebniok commented on May 29, 2023

    @szebniok
    Contributor

    Hey, I'll work on this

  12. roryabraham commented on Jun 1, 2023

    @roryabraham
    Contributor

    I created a useArrowKeyFocusManager hook that accomplishes the same thing as this component without including anything additional in the component hierarchy. I think it's a bit simpler to use. Maybe we should just migrate to using that rather than refactoring ArrowKeyFocusManager to a functional component.

  13. vdem0115 commented on Jul 7, 2023

    @vdem0115

    I'd like to work on this issue

  14. olexyt commented on Jul 7, 2023

    @olexyt
    Contributor

    I can work on this issue.

  15. roryabraham commented on Jul 8, 2023

    @roryabraham
    Contributor

    I don't really agree that we should do this. I think we should just use the useArrowKeyFocusManager hook instead.

  16. rayane-d commented on Jul 9, 2023

    @rayane-d
    Contributor

    Can I work on this issue?

  17. mkhutornyi commented on Jul 11, 2023

    @mkhutornyi
    Contributor

    I'd like to work on this.

  18. dexexpert commented on Aug 18, 2023

    @dexexpert

    I hope to work on this task.

  19. roryabraham commented on Aug 29, 2023

    @roryabraham
    Contributor

    Going to close this. As stated above, this component shouldn't really be necessary in a world of functional components since we have a hook to accomplish the same thing more simply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions