Skip to content

[HOLD for payment 2023-06-29] [$250] Migrate AttachmentModal.js to function component #16114

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a7e287fa36d40c6a
  • Upwork Job ID: 1664795623973076992
  • Last Price Increase: 2023-06-03

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate AttachmentModal.js to function component[/-] [+][HOLD][$250] Migrate AttachmentModal.js to function component[/+] on Apr 13, 2023
  4. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  5. self-assigned this
    on Apr 27, 2023
  6. changed the title [-][HOLD][$250] Migrate AttachmentModal.js to function component[/-] [+][$250] Migrate AttachmentModal.js to function component[/+] on Jun 2, 2023
  7. marcaaron commented on Jun 2, 2023

    @marcaaron
    ContributorAuthor

    Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

  8. rayane-d commented on Jun 3, 2023

    @rayane-d
    Contributor

    @yuwenmemon I can take this one if you don't have time.

  9. melvin-bot commented on Jun 3, 2023

    @melvin-bot

    📣 @rayane-djouah! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  10. melvin-bot commented on Jun 3, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  11. removed their assignment
    on Jun 3, 2023
  12. 45 remaining items

  13. changed the title [-][$250] Migrate AttachmentModal.js to function component[/-] [+][HOLD for payment 2023-06-29] [$250] Migrate AttachmentModal.js to function component[/+] on Jun 22, 2023
  14. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jun 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. joekaufmanexpensify commented on Jun 28, 2023

    @joekaufmanexpensify
    Contributor

    @allroundexperts offer sent for $250!

  17. joekaufmanexpensify commented on Jun 29, 2023

    @joekaufmanexpensify
    Contributor

    This PR was merged more than 9 business days after assignment. But C+ approved on the 7th business day. The time after that was for our internal engineer to review. So we won't apply a penalty here.

  18. joekaufmanexpensify commented on Jun 29, 2023

    @joekaufmanexpensify
    Contributor

    All set to issue payment here!

  19. joekaufmanexpensify commented on Jun 29, 2023

    @joekaufmanexpensify
    Contributor

    @rayane-djouah $250 sent and contract ended!

  20. joekaufmanexpensify commented on Jun 29, 2023

    @joekaufmanexpensify
    Contributor

    @allroundexperts $250 sent and contract ended!

  21. joekaufmanexpensify commented on Jun 29, 2023

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  22. joekaufmanexpensify commented on Jun 29, 2023

    @joekaufmanexpensify
    Contributor

    Issue complete, and all payment issued. Closing as this is all set. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions