Skip to content

[HOLD for payment 2023-04-20] Migrate AutoUpdateTime.js to function component #16117

Closed

Description

@marcaaron

Class Component Migration

Filenames

  • src/components/AutoUpdateTime.js
    • type: React.PureComponent
    • has state values: true
    • has refs: false
    • has context: false
    • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. self-assigned this
    on Mar 21, 2023
  4. changed the title [-][HOLD] Migrate AutoUpdateTime.js to function component[/-] [+]Migrate AutoUpdateTime.js to function component[/+] on Apr 5, 2023
  5. marcaaron commented on Apr 5, 2023

    @marcaaron
    ContributorAuthor

    @puneetlath taking this issue off HOLD as per this Slack post

    IMPORTANT: If anything unexpected pops up during the refactor/review:

    • Take it to #expensify-open-source to get clarification on.
    • Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
    • Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations”
    • Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase
  6. puneetlath commented on Apr 5, 2023

    @puneetlath
    Contributor

    Woo hoo!

  7. changed the title [-]Migrate AutoUpdateTime.js to function component[/-] [+][HOLD for payment 2023-04-20] Migrate AutoUpdateTime.js to function component[/+] on Apr 13, 2023
  8. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.99-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-04-20. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  10. puneetlath commented on Apr 13, 2023

    @puneetlath
    Contributor

    There are no external payments needed here, so going to go ahead and close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions