Skip to content

[$250] Migrate Avatar.js to function component #16118

Closed

Description

@marcaaron

Class Component Migration

Filenames

  • src/components/Avatar.js
    • type: React.PureComponent
    • has state values: true
    • has refs: false
    • has context: false
    • lifecycle methods: componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. self-assigned this
    on Mar 21, 2023
  4. techievivek commented on Mar 31, 2023

    @techievivek
    Contributor

    Waiting on further instructions before I actually started doing the migration.

  5. changed the title [-][HOLD] Migrate Avatar.js to function component[/-] [+]Migrate Avatar.js to function component[/+] on Apr 5, 2023
  6. marcaaron commented on Apr 5, 2023

    @marcaaron
    ContributorAuthor

    @techievivek taking this issue off HOLD as per this Slack post

    IMPORTANT: If anything unexpected pops up during the refactor/review:

    • Take it to #expensify-open-source to get clarification on.
    • Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
    • Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations”
    • Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase
  7. changed the title [-]Migrate Avatar.js to function component[/-] [+][$250] Migrate Avatar.js to function component[/+] on Apr 13, 2023
  8. MelvinBot commented on May 3, 2023

    @MelvinBot
    Contributor

    This issue has not been updated in over 15 days. @techievivek eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions