Skip to content

[HOLD for payment 2023-08-02] [$250] Migrate index.js to function component #16138

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012e1cb4c2da152efa
  • Upwork Job ID: 1686847396210348032
  • Last Price Increase: 2023-08-02
  • Automatic offers:
    • shubham1206agra | Contributor | 25912631

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate index.js to function component[/-] [+][HOLD][$250] Migrate index.js to function component[/+] on Apr 13, 2023
  4. muxriddinmuqimov77 commented on Jun 6, 2023

    @muxriddinmuqimov77

    I'd like to work on this issue

  5. dummy-1111 commented on Jun 6, 2023

    @dummy-1111
    Contributor

    I'd love to work on this.

  6. self-assigned this
    on Jun 7, 2023
  7. changed the title [-][HOLD][$250] Migrate index.js to function component[/-] [+][$250] Migrate index.js to function component[/+] on Jun 26, 2023
  8. marcaaron commented on Jun 26, 2023

    @marcaaron
    ContributorAuthor

    Taking this one off HOLD.

  9. rayane-d commented on Jun 26, 2023

    @rayane-d
    Contributor

    @marcaaron I'd like to work on this

  10. 44 remaining items

  11. melvin-bot commented on Aug 8, 2023

    @melvin-bot

    @sobitneupane, @srikarparsi, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

  12. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 9, 2023
  13. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  14. melvin-bot commented on Aug 9, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  15. srikarparsi commented on Aug 9, 2023

    @srikarparsi
    Contributor

    Hi @lschurr! Can you please pay @shubham1206agra for creating this PR and @sobitneupane for testing this PR whenever you get a chance?

  16. lschurr commented on Aug 9, 2023

    @lschurr
    Contributor

    Sure! The automation says both are $250. Is that correct @srikarparsi?

  17. srikarparsi commented on Aug 9, 2023

    @srikarparsi
    Contributor

    Yup, that's right, thanks @lschurr!

  18. lschurr commented on Aug 9, 2023

    @lschurr
    Contributor

    Payment summary:

  19. lschurr commented on Aug 9, 2023

    @lschurr
    Contributor

    Do we need any regression tests or anything further? Can this be closed @srikarparsi?

  20. srikarparsi commented on Aug 9, 2023

    @srikarparsi
    Contributor

    Hey yeah closing this out! I don't think regression tests are needed because they already covered this case which is why the issue was reported.

  21. sobitneupane commented on Aug 21, 2023

    @sobitneupane
    Contributor

    Requested payment on newDot.

    #16138 (comment)

  22. JmillsExpensify commented on Aug 30, 2023

    @JmillsExpensify
    Contributor

    Reviewed the details for @sobitneupane. $250 approved for payment via NewDot based on BZ summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions