Skip to content

[HOLD for payment 2023-07-24] [$250] Migrate KeyboardShortcutsModal.js to function component #16172

Closed

Description

@marcaaron

Class Component Migration

Filenames

  • src/components/KeyboardShortcutsModal.js
    • type: React.Component
    • has state values: false
    • has refs: false
    • has context: false
    • lifecycle methods: componentDidMount,componentWillUnmount, componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01678291804db5d8d5
  • Upwork Job ID: 1678837080014872576
  • Last Price Increase: 2023-07-11

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate KeyboardShortcutsModal.js to function component[/-] [+][HOLD][$250] Migrate KeyboardShortcutsModal.js to function component[/+] on Apr 13, 2023
  4. muxriddinmuqimov77 commented on Jun 6, 2023

    @muxriddinmuqimov77

    I'd like to work on this issue

  5. dummy-1111 commented on Jun 6, 2023

    @dummy-1111
    Contributor

    I'd love to work on this.

  6. disha-np commented on Jul 6, 2023

    @disha-np

    Can I work on this migration issue

  7. olexyt commented on Jul 7, 2023

    @olexyt
    Contributor

    I can work on this issue.

  8. rayane-d commented on Jul 9, 2023

    @rayane-d
    Contributor

    Can I work on this issue?

  9. changed the title [-][HOLD][$250] Migrate KeyboardShortcutsModal.js to function component[/-] [+][$250] Migrate KeyboardShortcutsModal.js to function component[/+] on Jul 11, 2023
  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 11, 2023
  11. 47 remaining items

  12. iwiznia commented on Jul 21, 2023

    @iwiznia
    Contributor

    Seems this is mostly ready, so not unassigning myself, but if this does not get closed, @dylanexpensify please unassign and re-assign another engineer since I am going on sabbatical

  13. rayane-d commented on Jul 24, 2023

    @rayane-d
    Contributor

    Payment requested

  14. melvin-bot commented on Jul 26, 2023

    @melvin-bot

    Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  15. rayane-d commented on Jul 26, 2023

    @rayane-d
    Contributor

    Waiting for payment

  16. rayane-d commented on Jul 28, 2023

    @rayane-d
    Contributor
  17. dylanexpensify commented on Jul 28, 2023

    @dylanexpensify
    Contributor

    Sorry! Doing now!

  18. dylanexpensify commented on Jul 28, 2023

    @dylanexpensify
    Contributor

    Paid! TY!

  19. arosiclair commented on Jul 28, 2023

    @arosiclair
    Contributor

    I think this is all set so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions