Skip to content

[$250] Migrate BaseModal.js to function component #16175

Closed

Description

@marcaaron

Class Component Migration

Filenames

  • src/components/Modal/BaseModal.js
    • type: React.PureComponent
    • has state values: false
    • has refs: true
    • has context: true
    • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01adcc5d2f587f2657
  • Upwork Job ID: 1691866213671108608
  • Last Price Increase: 2023-08-16

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate BaseModal.js to function component[/-] [+][HOLD][$250] Migrate BaseModal.js to function component[/+] on Apr 13, 2023
  4. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  5. muxriddinmuqimov77 commented on Jun 6, 2023

    @muxriddinmuqimov77

    I'd like to work on this issue

  6. dummy-1111 commented on Jun 6, 2023

    @dummy-1111
    Contributor

    I'd love to work on this.

  7. dayana7204 commented on Jun 27, 2023

    @dayana7204
    Contributor

    I am ready to work on this ticket. :)

  8. olexyt commented on Jul 7, 2023

    @olexyt
    Contributor

    I can work on this issue.

  9. rayane-d commented on Jul 9, 2023

    @rayane-d
    Contributor

    Can I work on this issue?

  10. mejed-alkoutaini commented on Jul 11, 2023

    @mejed-alkoutaini

    I'm able to work on this if needed!

  11. mkhutornyi commented on Jul 12, 2023

    @mkhutornyi
    Contributor

    I'd like to work on this.

  12. JKobrynski commented on Aug 16, 2023

    @JKobrynski
    Contributor

    Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue

  13. 49 remaining items

  14. melvin-bot commented on Aug 31, 2023

    @melvin-bot

    @JmillsExpensify, @marcaaron, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. melvin-bot commented on Sep 4, 2023

    @melvin-bot

    @JmillsExpensify, @marcaaron, @JKobrynski Still overdue 6 days?! Let's take care of this!

  16. melvin-bot commented on Sep 13, 2023

    @melvin-bot

    This issue has not been updated in over 14 days. @JmillsExpensify, @marcaaron, @JKobrynski eroding to Weekly issue.

  17. melvin-bot commented on Oct 6, 2023

    @melvin-bot

    This issue has not been updated in over 15 days. @JmillsExpensify, @marcaaron, @JKobrynski eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  18. JmillsExpensify commented on Oct 12, 2023

    @JmillsExpensify
    Contributor

    It looks like the PR is merged right? Is all that's left here is paying @s77rt for the PR review?

  19. JmillsExpensify commented on Oct 12, 2023

    @JmillsExpensify
    Contributor

    In fact, it might be @parasharrajat as well? All in all, I'd love a summary on where we're at.

  20. s77rt commented on Oct 12, 2023

    @s77rt
    Member

    @JmillsExpensify I didn't review that PR

  21. parasharrajat commented on Oct 12, 2023

    @parasharrajat
    Member

    @JmillsExpensify No C+ reviewed the PR. We are shown as reviewers because we commented on the PR to mention regressions.

  22. JmillsExpensify commented on Oct 16, 2023

    @JmillsExpensify
    Contributor

    Thanks! @marcaaron @JKobrynski can you help clarify whether there is anything else left to do here?

  23. JmillsExpensify commented on Oct 24, 2023

    @JmillsExpensify
    Contributor

    Closing to clear this one. Please re-open if there is anything left to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2NewFeatureSomething to build that is a new item.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions