[$250] Migrate BaseOptionsSelector.js to function component

Class Component Migration

Filenames

src/components/OptionsSelector/BaseOptionsSelector.js
- type: React.Component
- has state values: true
- has refs: true
- has context: false
- lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018a6f55da7cfbd26a
Upwork Job ID: 1727071636393496576
Last Price Increase: 2023-11-21

I'd love to work on this.

I am ready to work on this ticket. :)

@dayana7204

📣 @dayana7204! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

I can work on this issue.

Can I work on this issue?

I'm able to work on this if needed!

I'd like to work on this.

I can work on this

I hope to work on this task.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Piotrfj

I think we're going to revert the PR because it caused many regressions. That said, I did a substantial amount of refactoring to get this component to a much better place in #37353. @Piotrfj I hope you use it as a reference to help clean up this component. and I want to review the PR as well

Created a slack thread to discuss: https://expensify.slack.com/archives/C01GTK53T8Q/p1709156803359359

@roryabraham

Update: re-refactoring is ready to be tested, it fixes all the regression issues I was aware of. Please test it (especially the tags, because I could not yet replicate the scenario on my site).
The fix is based on the @roryabraham solution, so special thanks for him!
Link to PR: #37494

Sorry for the back-and-forth, but coming from this discussion I see that OptionsSelector is essentially deprecated, so I propose that we actually close the above PR and this issue, and plan to focus on removing the deprecated OptionsSelector altogether

@roryabraham

@roryabraham let me know about the final decision about this issue

Yes, let's not invest time and money refactoring something that's deprecated. Let's instead invest resources in removing it completely

Navigation Menu

Repository navigation

[$250] Migrate BaseOptionsSelector.js to function component #16184

Class Component Migration

Filenames

Task

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] Migrate BaseOptionsSelector.js to function component #16184

Description

Class Component Migration

Filenames

Task

Activity

dummy-1111 commented on Jun 6, 2023

dayana7204 commented on Jun 27, 2023

melvin-bot commented on Jun 27, 2023

olexyt commented on Jul 7, 2023

rayane-d commented on Jul 9, 2023

mejed-alkoutaini commented on Jul 11, 2023

mkhutornyi commented on Jul 12, 2023

KrAbhas commented on Jul 19, 2023

dexexpert commented on Aug 18, 2023

23 remaining items

melvin-bot commented on Feb 27, 2024

roryabraham commented on Feb 28, 2024

roryabraham commented on Feb 28, 2024

Piotrfj commented on Feb 29, 2024

roryabraham commented on Feb 29, 2024

Piotrfj commented on Mar 7, 2024

roryabraham commented on Mar 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions