Skip to content

[HOLD for payment 2023-08-01] [$250] Migrate BasePasswordPopover.js to function component #16188

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f9e8929e77cfa577
  • Upwork Job ID: 1678837543177977856
  • Last Price Increase: 2023-07-11

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate BasePasswordPopover.js to function component[/-] [+][HOLD][$250] Migrate BasePasswordPopover.js to function component[/+] on Apr 13, 2023
  4. dostongulmatov commented on Jun 6, 2023

    @dostongulmatov
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Migrate BasePasswordPopover.js to function component

    What is the root cause of that problem?

    No problem, refactor the class component into functional component

    What changes do you think we should make in order to solve the problem?

    Update https://github.com/Expensify/App/blob/main/src/components/PasswordPopover/BasePasswordPopover.js
    into functional component

  5. dummy-1111 commented on Jun 6, 2023

    @dummy-1111
    Contributor

    I'd love to work on this.

  6. melvin-bot commented on Jun 9, 2023

    @melvin-bot

    Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. melvin-bot commented on Jun 13, 2023

    @melvin-bot

    Still overdue 6 days?! Let's take care of this!

  8. melvin-bot commented on Jun 15, 2023

    @melvin-bot

    Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  9. melvin-bot commented on Jun 19, 2023

    @melvin-bot

    12 days overdue now... This issue's end is nigh!

  10. 57 remaining items

  11. melvin-bot commented on Jul 25, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jul 25, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-01. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  13. JmillsExpensify commented on Jul 26, 2023

    @JmillsExpensify
    Contributor

    @rayane-djouah Upwork job is here for when the regression period ends.

  14. JmillsExpensify commented on Aug 2, 2023

    @JmillsExpensify
    Contributor

    Payment summary:

  15. JmillsExpensify commented on Aug 2, 2023

    @JmillsExpensify
    Contributor

    Following on the above, I confirm that the above summary is correct and @sobitneupane is approved for payment via NewDot. @sobitneupane please create a request. Thanks!

  16. techievivek commented on Aug 7, 2023

    @techievivek
    Contributor

    Not overdue, waiting for the payment to complete.

  17. sobitneupane commented on Aug 9, 2023

    @sobitneupane
    Contributor

    Requested payment on newDot.

    #16188 (comment)

  18. JmillsExpensify commented on Aug 10, 2023

    @JmillsExpensify
    Contributor

    We're all good on this one. Payment is approved via NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions