Skip to content

[HOLD for payment 2023-08-21] [$250] Migrate ThumbnailImage.js to function component #16210

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate ThumbnailImage.js to function component[/-] [+][HOLD][$250] Migrate ThumbnailImage.js to function component[/+] on Apr 13, 2023
  4. marcaaron commented on Apr 13, 2023

    @marcaaron
    ContributorAuthor

    Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

  5. kadiealexander commented on Jun 6, 2023

    @kadiealexander
    Contributor

    Not overdue, close to having a PR up!

  6. dummy-1111 commented on Jun 6, 2023

    @dummy-1111
    Contributor

    I'd love to work on this.

  7. kadiealexander commented on Jun 16, 2023

    @kadiealexander
    Contributor

    Created a draft PR to discuss with @puneetlath next week.

  8. 23 remaining items

  9. changed the title [-][$250] Migrate ThumbnailImage.js to function component[/-] [+][HOLD for payment 2023-08-21] [$250] Migrate ThumbnailImage.js to function component[/+] on Aug 14, 2023
  10. melvin-bot commented on Aug 14, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Aug 14, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-21. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. kadiealexander commented on Aug 22, 2023

    @kadiealexander
    Contributor

    Payouts due:

    Issue Reporter: n/a
    Contributor: n/a
    Contributor+: $125 @s77rt

    Eligible for 50% #urgency bonus? No

    Upwork job is here.

  13. s77rt commented on Aug 22, 2023

    @s77rt
    Member

    @kadiealexander We had a regression here. Can you please update the price to $125

  14. kadiealexander commented on Aug 23, 2023

    @kadiealexander
    Contributor

    Done, thanks for flagging @s77rt!

  15. s77rt commented on Aug 23, 2023

    @s77rt
    Member

    @kadiealexander i have accepted the offer. Thanks!

  16. kadiealexander commented on Aug 24, 2023

    @kadiealexander
    Contributor

    All paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions