Skip to content

[HOLD for payment 2023-10-02] [$250] Migrate OnfidoStep.js to function component #16235

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0116d0baefad9a4a03
  • Upwork Job ID: 1703726382146158592
  • Last Price Increase: 2023-09-18

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate OnfidoStep.js to function component[/-] [+][HOLD][$250] Migrate OnfidoStep.js to function component[/+] on Apr 13, 2023
  4. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  5. marcaaron commented on Apr 13, 2023

    @marcaaron
    ContributorAuthor

    Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

  6. vdem0115 commented on Jul 4, 2023

    @vdem0115

    I would like to work on this issue.

  7. olexyt commented on Jul 7, 2023

    @olexyt
    Contributor

    I can work on this issue.

  8. rayane-d commented on Jul 9, 2023

    @rayane-d
    Contributor

    Can I work on this?

  9. mejed-alkoutaini commented on Jul 11, 2023

    @mejed-alkoutaini

    I'm able to work on this if needed!

  10. neonbhai commented on Jul 13, 2023

    @neonbhai
    Contributor

    I would love to work on this

  11. KrAbhas commented on Jul 19, 2023

    @KrAbhas
    Contributor

    Can I work on this?

  12. adhorodyski commented on Sep 18, 2023

    @adhorodyski
    Contributor

    Hey! 👋 I’m from Callstack, an expert agency, and I’d like to work on this issue.

  13. 37 remaining items

  14. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Sep 25, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-02. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    • @adhorodyski does not require payment (Contractor)
    • @thesahindia does not require payment (Eligible for Manual Requests)

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. melvin-bot commented on Oct 4, 2023

    @melvin-bot

    @robertjchen, @mallenexpensify, @adhorodyski, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. mallenexpensify commented on Oct 4, 2023

    @mallenexpensify
    Contributor

    @adhorodyski can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~0116d0baefad9a4a03

    I'm guessing we don't need a regression test for this, correct me if I'm wrong @thesahindia

  18. mallenexpensify commented on Oct 9, 2023

    @mallenexpensify
    Contributor

    D'oh, didn't realize @adhorodyski was CallStack.

    Issue reporter: N/A - internal
    Contributor: @adhorodyski is with CallStack and paid via invoice.
    Contributor+: @thesahindia is due $250 via NewDot

  19. thesahindia commented on Oct 19, 2023

    @thesahindia
    Member

    @mallenexpensify, I am requesting $250 for the C+ review. Can you please confirm that it's the right amount? We need a confirmation before Jason can approve the payment.

  20. mallenexpensify commented on Oct 20, 2023

    @mallenexpensify
    Contributor

    Thanks for the ping @thesahindia , unsure how I missed you, sorry. I updated the post above to reflect

    Contributor+: @thesahindia is due $250 via NewDot

  21. JmillsExpensify commented on Oct 25, 2023

    @JmillsExpensify
    Contributor

    $250 payment approved for @thesahindia based on BZ summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions