Skip to content

[HOLD for payment 2023-06-13] [$250] Migrate LogInWithShortLivedAuthTokenPage.js to function component #16237

New issue
New issue
Closed
Closed
[HOLD for payment 2023-06-13] [$250] Migrate LogInWithShortLivedAuthTokenPage.js to function component#16237
Assignees
francoislabdulrahuman5196adelekennedy
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staff
Milestone
React Class Component Migration

Description

@marcaaron
marcaaron
opened on Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01aa6985456f56863c
  • Upwork Job ID: 1669019963113058304
  • Last Price Increase: 2023-06-14

Activity

  1. marcaaron
    added
    Engineering
    ImprovementItem broken or needs improvement.
    on Mar 20, 2023
  2. marcaaron
    added this to the React Class Component Migration milestone on Mar 20, 2023
  3. melvin-bot
    locked and limited conversation to collaborators on Mar 20, 2023
  4. Expensify
    unlocked this conversation on Mar 21, 2023
  5. francoisl
    self-assigned this
    on Apr 5, 2023
  6. marcaaron
    changed the title [-][HOLD] Migrate LogInWithShortLivedAuthTokenPage.js to function component[/-] [+][HOLD][$250] Migrate LogInWithShortLivedAuthTokenPage.js to function component[/+] on Apr 13, 2023

  7. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    MelvinBot
    on Apr 13, 2023
    Contributor

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  8. marcaaron commented on Apr 13, 2023

    @marcaaron
    marcaaron
    on Apr 13, 2023
    ContributorAuthor

    Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

  9. marcaaron
    added
    DailyKSv2
    on Jun 2, 2023
  10. marcaaron
    changed the title [-][HOLD][$250] Migrate LogInWithShortLivedAuthTokenPage.js to function component[/-] [+][$250] Migrate LogInWithShortLivedAuthTokenPage.js to function component[/+] on Jun 2, 2023

  11. marcaaron commented on Jun 2, 2023

    @marcaaron
    marcaaron
    on Jun 2, 2023
    ContributorAuthor

    Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

  12. francoisl
    added
    ReviewingHas a PR in review
    on Jun 2, 2023

  13. abdulrahuman5196 commented on Jun 4, 2023

    @abdulrahuman5196
    abdulrahuman5196
    on Jun 4, 2023
    Contributor

    @francoisl Kindly assign me this issue for C+ review

  14. francoisl
    assigned
    abdulrahuman5196
    on Jun 5, 2023

  15. 13 remaining items

  16. francoisl
    added
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 14, 2023

  17. melvin-bot commented on Jun 14, 2023

    @melvin-bot
    melvin-botBot
    on Jun 14, 2023

    Job added to Upwork: https://www.upwork.com/jobs/~01aa6985456f56863c

  18. melvin-bot commented on Jun 14, 2023

    @melvin-bot
    melvin-botBot
    on Jun 14, 2023

    Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

  19. francoisl
    added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jun 14, 2023

  20. melvin-bot commented on Jun 14, 2023

    @melvin-bot
    melvin-botBot
    on Jun 14, 2023

    @francoisl the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

  21. melvin-bot
    removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Jun 14, 2023
  22. francoisl
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 14, 2023

  23. melvin-bot commented on Jun 14, 2023

    @melvin-bot
    melvin-botBot
    on Jun 14, 2023

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  24. melvin-bot
    assigned
    adelekennedy
    on Jun 14, 2023

  25. melvin-bot commented on Jun 14, 2023

    @melvin-bot
    melvin-botBot
    on Jun 14, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  26. francoisl commented on Jun 14, 2023

    @francoisl
    francoisl
    on Jun 14, 2023
    Contributor

    @adelekennedy FYI this was handled internally, we just need to pay @abdulrahuman5196 for reviewing the PR. Thanks!

  27. adelekennedy commented on Jun 14, 2023

    @adelekennedy
    adelekennedy
    on Jun 14, 2023
    Contributor

    @abdulrahuman5196 I just made the job public - will you apply? So i can pay you out?

  28. abdulrahuman5196 commented on Jun 14, 2023

    @abdulrahuman5196
    abdulrahuman5196
    on Jun 14, 2023
    Contributor

    @adelekennedy Thank you. Applied for the job.

  29. adelekennedy commented on Jun 15, 2023

    @adelekennedy
    adelekennedy
    on Jun 15, 2023
    Contributor

    Done!

  30. adelekennedy
    closed this as completedon Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions