Skip to content

[HOLD for payment 2023-07-14] [$250] Migrate NewChatPage.js to function component #16239

New issue
New issue
Closed
Closed
[HOLD for payment 2023-07-14] [$250] Migrate NewChatPage.js to function component#16239
Assignees
twisterdotcomthienlnamNikhil-Vatsaimane-chnaif
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.
Milestone
React Class Component Migration

Description

@marcaaron
marcaaron
opened on Mar 20, 2023

Class Component Migration

Filenames

  • src/pages/NewChatPage.js
    • type: React.Component
    • has state values: true
    • has refs: false
    • has context: false
    • lifecycle methods: none

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013e875c428c833da0
  • Upwork Job ID: 1664707231797780480
  • Last Price Increase: 2023-06-02

Activity

  1. marcaaron
    added
    Engineering
    ImprovementItem broken or needs improvement.
    on Mar 20, 2023
  2. marcaaron
    added this to the React Class Component Migration milestone on Mar 20, 2023
  3. melvin-bot
    locked and limited conversation to collaborators on Mar 20, 2023
  4. thienlnam
    self-assigned this
    on Mar 20, 2023
  5. Expensify
    unlocked this conversation on Mar 21, 2023
  6. thienlnam
    assigned
    thienlnam
    and unassigned
    thienlnam
    on Mar 21, 2023
  7. marcaaron
    changed the title [-][HOLD] Migrate NewChatPage.js to function component[/-] [+][HOLD][$250] Migrate NewChatPage.js to function component[/+] on Apr 13, 2023

  8. marcaaron commented on Apr 13, 2023

    @marcaaron
    marcaaron
    on Apr 13, 2023
    ContributorAuthor

    Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

  9. thienlnam commented on Apr 13, 2023

    @thienlnam
    thienlnam
    on Apr 13, 2023
    Contributor

    Thanks @marcaaron! I will have to counter your offer, unfortunately I can only do this for the original $1000. Thank you for your consideration and please let me know

  10. marcaaron commented on Apr 13, 2023

    @marcaaron
    marcaaron
    on Apr 13, 2023
    ContributorAuthor

    👢

  11. marcaaron
    changed the title [-][HOLD][$250] Migrate NewChatPage.js to function component[/-] [+][$250] Migrate NewChatPage.js to function component[/+] on Jun 2, 2023
  12. marcaaron
    added
    DailyKSv2
    on Jun 2, 2023

  13. marcaaron commented on Jun 2, 2023

    @marcaaron
    marcaaron
    on Jun 2, 2023
    ContributorAuthor

    Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

  14. 77 remaining items

  15. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jul 7, 2023
  16. melvin-bot
    changed the title [-][$250] Migrate NewChatPage.js to function component[/-] [+][HOLD for payment 2023-07-14] [$250] Migrate NewChatPage.js to function component[/+] on Jul 7, 2023

  17. melvin-bot commented on Jul 7, 2023

    @melvin-bot
    melvin-botBot
    on Jul 7, 2023

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-07-14. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty

  18. melvin-bot commented on Jul 7, 2023

    @melvin-bot
    melvin-botBot
    on Jul 7, 2023

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom / @greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  19. twisterdotcom
    unassigned
    greg-schroeder
    on Jul 7, 2023
  20. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jul 13, 2023

  21. twisterdotcom commented on Jul 14, 2023

    @twisterdotcom
    twisterdotcom
    on Jul 14, 2023
    Contributor

    @aimane-chnaif not listed here: https://github.com/Expensify/Web-Expensify/blob/main/_devportal/lib/KernelScheduling/Data.php#L242.

    Sending Upwork offer: https://www.upwork.com/en-gb/nx/wm/pre-hire/c/8577561/offer/25535772

    @Nikhil-Vats - Upwork offer here: https://www.upwork.com/en-gb/nx/wm/pre-hire/c/8577561/offer/25535788

  22. Nikhil-Vats commented on Jul 14, 2023

    @Nikhil-Vats
    Nikhil-Vats
    on Jul 14, 2023
    Contributor

    Accepted @twisterdotcom

  23. aimane-chnaif commented on Jul 14, 2023

    @aimane-chnaif
    aimane-chnaif
    on Jul 14, 2023
    Contributor

    @aimane-chnaif not listed here: https://github.com/Expensify/Web-Expensify/blob/main/_devportal/lib/KernelScheduling/Data.php#L242.

    What list is there?

    Edit: Ah, I assume newDot payment

  24. twisterdotcom commented on Jul 14, 2023

    @twisterdotcom
    twisterdotcom
    on Jul 14, 2023
    Contributor

    Yes sorry, it's the newDot payment one. Just for my own sanity @aimane-chnaif!

  25. melvin-bot
    added
    Overdue
    on Jul 17, 2023

  26. twisterdotcom commented on Jul 17, 2023

    @twisterdotcom
    twisterdotcom
    on Jul 17, 2023
    Contributor

    Paid out!

  27. twisterdotcom
    closed this as completedon Jul 17, 2023
  28. melvin-bot
    removed
    Overdue
    on Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions