Skip to content

[HOLD for payment 2023-08-24] Remove dead code: ReimbursementAccountForm.js #16244

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010c6fce1e5ede748b
  • Upwork Job ID: 1689715971823095808
  • Last Price Increase: 2023-08-10

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate ReimbursementAccountForm.js to function component[/-] [+][HOLD][$250] Migrate ReimbursementAccountForm.js to function component[/+] on Apr 13, 2023
  4. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  5. marcaaron commented on Apr 13, 2023

    @marcaaron
    ContributorAuthor

    Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

  6. payal-lathidadiya commented on Jul 1, 2023

    @payal-lathidadiya
    Contributor

    I wish to work on this if goes to external

  7. vdem0115 commented on Jul 5, 2023

    @vdem0115

    I would like to work on this if goes to external.

  8. alpeshl commented on Jul 5, 2023

    @alpeshl
    Contributor

    I can pick this migration issue

  9. disha-np commented on Jul 6, 2023

    @disha-np

    I like to work on this migration issue

  10. olexyt commented on Jul 7, 2023

    @olexyt
    Contributor

    I can work on this issue.

  11. rayane-d commented on Jul 9, 2023

    @rayane-d
    Contributor

    Can I work on this?

  12. to-ai commented on Jul 11, 2023

    @to-ai

    I am able to work on this task.

  13. 37 remaining items

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 11, 2023
  15. changed the title [-]Remove dead code: ReimbursementAccountForm.js[/-] [+][HOLD for payment 2023-08-24] Remove dead code: ReimbursementAccountForm.js[/+] on Aug 17, 2023
  16. melvin-bot commented on Aug 17, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Aug 17, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-24. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  18. marcaaron commented on Aug 26, 2023

    @marcaaron
    ContributorAuthor

    On production now so we can close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsTask

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions