Skip to content

[HOLD for payment 2023-12-29] [$250] Migrate SearchPage.js to function component #16251

Closed

Description

@marcaaron

Class Component Migration

Filenames

  • src/pages/SearchPage.js
    • type: React.Component
    • has state values: true
    • has refs: false
    • has context: false
    • lifecycle methods: none

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015fa113b288776a75
  • Upwork Job ID: 1681356452396900352
  • Last Price Increase: 2023-07-18

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate SearchPage.js to function component[/-] [+][HOLD][$250] Migrate SearchPage.js to function component[/+] on Apr 13, 2023
  4. marcaaron commented on Apr 13, 2023

    @marcaaron
    ContributorAuthor

    Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

  5. dummy-1111 commented on Jun 6, 2023

    @dummy-1111
    Contributor

    I'd love to work on this.

  6. dayana7204 commented on Jun 27, 2023

    @dayana7204
    Contributor

    I am ready to work on this ticket. :)

  7. Piotrfj commented on Jul 5, 2023

    @Piotrfj
    Contributor

    Hi I'm Piotr from Callstack - expert contributor group - will start investigation in this area

  8. melvin-bot commented on Jul 5, 2023

    @melvin-bot

    📣 @Piotrfj! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. disha-np commented on Jul 6, 2023

    @disha-np

    Can I work on this?

  10. olexyt commented on Jul 7, 2023

    @olexyt
    Contributor

    I can work on this issue.

  11. rayane-d commented on Jul 9, 2023

    @rayane-d
    Contributor

    Can I work on this?

  12. mejed-alkoutaini commented on Jul 11, 2023

    @mejed-alkoutaini

    I'm able to work on this if needed!

  13. 93 remaining items

  14. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-12-29. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Dec 22, 2023

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  16. melvin-bot commented on Jan 1, 2024

    @melvin-bot

    @allroundexperts, @isabelastisser, @marcaaron, @Piotrfj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. melvin-bot commented on Jan 2, 2024

    @melvin-bot

    @allroundexperts, @isabelastisser, @marcaaron, @Piotrfj Eep! 4 days overdue now. Issues have feelings too...

  18. isabelastisser commented on Jan 2, 2024

    @isabelastisser
    Contributor

    @allroundexperts please complete this task before I can close the issue. Thanks!

    [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

  19. isabelastisser commented on Jan 2, 2024

    @isabelastisser
    Contributor

    Payment summary:

    $250 to @allroundexperts for C+ review.

    requires payment through NewDot Manual Requests

  20. isabelastisser commented on Jan 3, 2024

    @isabelastisser
    Contributor

    Bump @allroundexperts to complete the checklist above.

  21. allroundexperts commented on Jan 3, 2024

    @allroundexperts
    Contributor

    @isabelastisser I don't think that we have checklists for component migrations.

  22. JmillsExpensify commented on Jan 24, 2024

    @JmillsExpensify
    Contributor

    $250 payment to @allroundexperts based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions