Repository navigation
[$1000] Migrate ReportActionCompose.js to function component #16263
Description
Class Component Migration
Filenames
- src/pages/home/report/ReportActionCompose.js
- type:
React.Component - has state values: true
- has refs: true
- has context: false
- lifecycle methods:
componentDidMount,componentWillUnmount,componentDidUpdate
- type:
Task
- We currently have some class components in our codebase that we would like to refactor to a function component.
- Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
- If you need additional guidance, please ask in #expensify-open-source
- Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01131d62c055beb52a
- Upwork Job ID: 1668304833402220544
- Last Price Increase: 2023-06-12
- Automatic offers:
- 0xmiroslav | Reviewer | 26454734
- situchan | Contributor | 26454736
Activity
roryabraham commentedon Mar 21, 2023
This one seems particularly nasty, so I'd like to take a stab. I'm pretty familiar with hooks but could use a refresher.
[-][HOLD] Migrate ReportActionCompose.js to function component[/-][+][HOLD][$250] Migrate ReportActionCompose.js to function component[/+]marcaaron commentedon Apr 13, 2023
Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.
hannojg commentedon Apr 18, 2023
Not sure if the issue is external but I can help with that refactor? (Need it to happen to unblock another PR 😄 )
marcaaron commentedon Apr 18, 2023
We are going to open these up soon. Our internal team has been slowly chewing through the first round of 30 or so. But would love to have you work on this one or some others @hannojg !
67 remaining items
dylanexpensify commentedon Aug 29, 2023
Should be today!
dylanexpensify commentedon Aug 31, 2023
Hmm, Payment isn't autopopulating, but @marcaaron we're good to pay yeah?
situchan commentedon Aug 31, 2023
@roryabraham is assigned engineer here.
PR was deployed to production on Aug 24 so yeah today is due.
It took much efforts to review 1.3k lines of code and do full regression test as this is the most important component in the app. Also there were tens of conflicts and had to retest whenever conflict fixed.
Hope that would be considered in payment.
roryabraham commentedon Sep 1, 2023
Confirming that this was deployed to prod on Aug 24th so is ready to pay out.
Regarding payment, we actually had two C+ here. My proposal for payments is:
I understand that this was a more time consuming PR to work on, and that's why I quadrupled the bounty early on here.
melvin-bot commentedon Sep 1, 2023
📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon Sep 1, 2023
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
melvin-bot commentedon Sep 11, 2023
@chrispader, @roryabraham, @dylanexpensify, @0xmiroslav, @situchan Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Sep 11, 2023
@chrispader, @roryabraham, @dylanexpensify, @0xmiroslav, @situchan Huh... This is 4 days overdue. Who can take care of this?
roryabraham commentedon Sep 11, 2023
This is done – @dylanexpensify bump to pay plz
melvin-bot commentedon Sep 18, 2023
@chrispader, @roryabraham, @dylanexpensify, @0xmiroslav, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
dylanexpensify commentedon Sep 19, 2023
Paying tonight!
dylanexpensify commentedon Sep 19, 2023
@situchan payment sent! @0xmiroslav can you accept offer please?
0xmiroslav commentedon Sep 19, 2023
@dylanexpensify please hold my payment and just close this issue to prevent further notifications.
I will ping here when ready. Thanks