Skip to content

[HOLD for payment 2023-08-07] [$250] Migrate InitialSettingsPage.js to function component #16281

Closed

Description

@marcaaron

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ed00725204fbc329
  • Upwork Job ID: 1673399218372874240
  • Last Price Increase: 2023-06-26

Activity

  1. locked and limited conversation to collaborators on Mar 20, 2023
  2. unlocked this conversation on Mar 21, 2023
  3. changed the title [-][HOLD] Migrate InitialSettingsPage.js to function component[/-] [+][HOLD][$250] Migrate InitialSettingsPage.js to function component[/+] on Apr 13, 2023
  4. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  5. marcaaron commented on Apr 13, 2023

    @marcaaron
    ContributorAuthor

    Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

  6. muxriddinmuqimov77 commented on Jun 6, 2023

    @muxriddinmuqimov77

    I'd like to work on this issue when it goes to external

  7. changed the title [-][HOLD][$250] Migrate InitialSettingsPage.js to function component[/-] [+][$250] Migrate InitialSettingsPage.js to function component[/+] on Jun 26, 2023
  8. melvin-bot commented on Jun 26, 2023

    @melvin-bot
  9. 85 remaining items

  10. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. danieldoglas commented on Jul 31, 2023

    @danieldoglas
    Contributor

    I don't think we have a fix for this already? @yh-0218

  12. yh-0218 commented on Jul 31, 2023

    @yh-0218
    Contributor

    Sorry @danieldoglas What issue do I fix on this status?

  13. danieldoglas commented on Jul 31, 2023

    @danieldoglas
    Contributor

    Sorry, I just saw that the regression was actually fixed by @mountiny. You don't need to do anything.

  14. yh-0218 commented on Jul 31, 2023

    @yh-0218
    Contributor

    Got it @danieldoglas Thanks for your reply.

  15. sophiepintoraetz commented on Aug 1, 2023

    @sophiepintoraetz
    Contributor

    @yh-0218 - we typically halve payments for introducing a regression - so the updated amounts are:

  16. sophiepintoraetz commented on Aug 1, 2023

    @sophiepintoraetz
    Contributor

    Ah, just realised we're subject to a regression period (@yh-0218 - you've been paid $125 already - let's hope another regression doesn't come through!)

  17. mananjadhav commented on Aug 6, 2023

    @mananjadhav
    Collaborator

    I've raised a request on NewDot for myself.

  18. sophiepintoraetz commented on Aug 7, 2023

    @sophiepintoraetz
    Contributor

    payments done.

  19. JmillsExpensify commented on Aug 8, 2023

    @JmillsExpensify
    Contributor

    Reviewed the details for @mananjadhav. This is approved for payment via NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringImprovementItem broken or needs improvement.NewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions